Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1139563pxb; Tue, 9 Nov 2021 05:49:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxTLgiwmsyk80/3uoc/4BEGeF/WX4sT4wB9y5LBF8AxcYCTNH9d/ooA4BN8dsowVazjWiRU X-Received: by 2002:a5e:9301:: with SMTP id k1mr5202518iom.118.1636465784230; Tue, 09 Nov 2021 05:49:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636465784; cv=none; d=google.com; s=arc-20160816; b=WxPK8pzYXWMjv32aUN/KOEgvfwpljT8DlL0+Hdye/ouJwDzFmWf7meeseqPafDXuHL RfCiDrEX/xjtsYb7Q/4NhJzsLg+F1ybOW95Yiw8dY2GHQWN8ulwNZk/Dz80q+U9eR9VI n2vz7NGS7lVZpc9qAGtyL/MS4lR8OPy4ioxGP7kE11/4zZoIdhinSYQKBwnQsSOJFZgr ZWIg05TpUjEPjX5GveqZg+ClL1Di84B6bGGUWXZau/bza5NVqo0uQelCicwWCxNudvR1 yUqnn5LVeg6z1RPXQzJnxWAdrud6H6coJ27moHGuKDFAxtEj3hmIXNUphG4Q6bFGR0oH Dmpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=dodHiJ/i5+yBi7D79YaFpKUD7A0B39/NZgj04F7HTkw=; b=nEyLb+MpnVsWDT58cd23K9I+bTX+asdOrU0BBkF3+avgTLxeXy/yPBqqYRrTmHEFEq ZMqqAGh2VWcN3haHObpF/UxqsZ4EE2zIEasnRKDHs68CoT5EWAyv6ylh6Fo416zyZVnu /J16E2WJxMemFymn/pMZA74VPwZMuZRgseY2j6cA7rQVLg0+wghiJAbblyPwEXabN0To URW+edpuvyVxcncdBeOZQrwsM7Mm/XUhfEtEglIB5bYT8Mk8Ji8qEg65qdGgu/95Sv8z PhXZSo/RzKcwS5V4gKNt//51ExhmdeGWQ6ls6yk1D2RIXIdPRseghOSwv8YUnL8VRJ1S +nAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bxdem1QF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o4si31404720ioh.99.2021.11.09.05.49.30; Tue, 09 Nov 2021 05:49:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bxdem1QF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242665AbhKIEkd (ORCPT + 99 others); Mon, 8 Nov 2021 23:40:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240672AbhKIEka (ORCPT ); Mon, 8 Nov 2021 23:40:30 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 125ADC061766 for ; Mon, 8 Nov 2021 20:37:45 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id m6so5630908oim.2 for ; Mon, 08 Nov 2021 20:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dodHiJ/i5+yBi7D79YaFpKUD7A0B39/NZgj04F7HTkw=; b=bxdem1QFzTvWY5Y2FugMEGhusz7KtT+Tg2/aELkYspP8+jbBn9eqwHlvusv7pgcd7j 6D6ZszdZelH0gPfDb3eOZuBteKvIglrJWvz1URYC/chQn/SbHArSOzzGEUv45u38bq87 axSySjtpwqup5cMdp2z/PHbwGW6nfLqXAfIInnVA9xfDZyNcTM87yBLQPTNLICf6I6w8 436T6zDADKFoCAUS/d9Xb2gAVNaWuT2h8+isOxYbofYxlpSq5W8X4fzh64opGShFwOh+ +ApkXe/izP+lvWMHLDQpkKS6tlaI8ZVQcySl57rluNzK8LPb0LQJ7M7eKRoCzmUV7Rev XjYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dodHiJ/i5+yBi7D79YaFpKUD7A0B39/NZgj04F7HTkw=; b=bj6JS8PbE1TghHskItb+ORGTFqtDH16WkmSjazp5iEwuceXN8ujiujd525J8RryRch UF3EMAAlQfSabv/OJDD9RxQEkpbELcAM2mjww6i3uBg7Dhlzl0LAWC17w/u8TKpmmYgT 9UDM4HOLzogmC6uNX9sWiBVEqewGIGuZdD/FnZoJhZOaxysnjOmnf7Si1BHi7HGAYnR3 sbeENWlvvd0zZ84VtPRRdHkGEFCaGyZ2/q4UAhkdR6AKjQe4MGz92E8MqPZAun3kKBUA Pf7NjkJ8aqBEH25pf+buHgJ2Qc9DTLYW/DnTnrNm6zRa9JP6vOoAqpn2iAn5RZxPzPbD EdBg== X-Gm-Message-State: AOAM532exyYKcaxoVVa8TSO1/nzRmGAWcbJf/OLBSf90Lb/Dnrnwi6um N9lurzODrWQqVkl1JwwH/RwaIDh/1U8BrlayqjjO0A== X-Received: by 2002:a54:4791:: with SMTP id o17mr3362653oic.114.1636432664361; Mon, 08 Nov 2021 20:37:44 -0800 (PST) MIME-Version: 1.0 References: <20211027181350.91630-1-nikita@trvn.ru> <20211027181350.91630-2-nikita@trvn.ru> In-Reply-To: <20211027181350.91630-2-nikita@trvn.ru> From: Linus Walleij Date: Tue, 9 Nov 2021 05:37:33 +0100 Message-ID: Subject: Re: [PATCH 1/6] input: touchscreen: zinitix: Make sure the IRQ is allocated before it gets enabled To: Nikita Travkin Cc: dmitry.torokhov@gmail.com, robh+dt@kernel.org, Michael.Srba@seznam.cz, broonie@kernel.org, linux-input@vger.kernel.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 27, 2021 at 8:15 PM Nikita Travkin wrote: > Since irq request is the last thing in the driver probe, it happens > later than the input device registration. This means that there is a > small time window where if the open method is called the driver will > attempt to enable not yet available irq. > > Fix that by moving the irq request before the input device registration. > > Fixes: 26822652c85e ("Input: add zinitix touchscreen driver") > Signed-off-by: Nikita Travkin Good catch! Reviewed-by: Linus Walleij Yours, Linus Walleij