Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] erofs: add sysfs interface
To:     Gao Xiang <hsiangkao@linux.alibaba.com>
Cc:     linux-erofs@lists.ozlabs.org, zhangshiming@oppo.com,
        linux-kernel@vger.kernel.org, yh@oppo.com, guanyuwei@oppo.com,
        guoweichao@oppo.com
References: <20211109025445.12427-1-huangjianan@oppo.com>
 <YYnmmla6xh5Y4d30@B-P7TQMD6M-0146.local>
From:   Huang Jianan <huangjianan@oppo.com>
Message-ID: <8ac546a2-25c9-a694-a82d-91984c826436@oppo.com>
Date:   Tue, 9 Nov 2021 15:29:52 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <YYnmmla6xh5Y4d30@B-P7TQMD6M-0146.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3h0Qk1QUWdSdk9oWnl0ZXhBcGtJUEhYUFgxV0JwbzhiTlNqVXNDOFEvYW5H?=
 =?utf-8?B?S1lBbk5iM2RaUTdLQjlHVWNWN1hMc0p1L2V2L250R1ZyQ203b09PYlJzM1ZT?=
 =?utf-8?B?a0NDYUM4OTlnWU9reXJBQ3Q0b1dkYUtISER1YlJXQ1ZEMVAvTFZqQkRSZ0RM?=
 =?utf-8?B?S2dQV3A4Q2NiTjMwZ3dCU2xldXZyMW1VNFhqbnYySnQ1SVNyTnExaWdsKzFU?=
 =?utf-8?B?M0RYbnBNckUrVjNzVmZVSzZqRE93Z0lvU2d6VWFkbFhabkN2SXlPT0J5ekN0?=
 =?utf-8?B?bFZjVTlvcGhKVVZVRTNrRm5ydGhWb25kY01rWlhidDVnTW9xVnhIdWJKaDBa?=
 =?utf-8?B?cmpSenA1U2V4ODlqNXd1TXhOMkpsUXBET3NBZC9zc2VFT2ovb29RalVaVm42?=
 =?utf-8?B?Z05rM3ZJZG4yMjJKRlNLYm5PdVpBeGlVK0NVSVYzTUt2a01VOXNnMHB4Qmt2?=
 =?utf-8?B?VkgwVUdiTjRscHpCZk5TZ294dzhYd3Jwa2lKdXp3STVNNlM0QmFTUzQ1TTNV?=
 =?utf-8?B?NU9SUW1HRyt0NEZXZ0RwWFNITDFpUnhNTEFNb1hHcDhMSDdMUitvaDNPU1Qy?=
 =?utf-8?B?NGZKNDJ5Z2xBWWFGUW1qSU80TUFMVFllVkc1cXRjNWtmdDNacm8xTzNpb0R3?=
 =?utf-8?B?ZXBrN3BlaE9qemZscktYL1FVMmZSM3FWRHFHbFBGTmtlL1FSeGw1MnBRQW82?=
 =?utf-8?B?Q0NhZmdaNllYTzYxQWUvWXVXcFZLV3IyNWpmWmFQRHhIbUxzT0pJSGZLYWdj?=
 =?utf-8?B?SWQwQ3NhTk5BZzdXK0tNMk9LWDJGVDFJRERYUHppQ0VCTnlyZHNzRThFenRa?=
 =?utf-8?B?czhjRW9FblJwTzNibWgwVXlabFZWQ0RueW5HS0xnT1l4YjludHBTYm5TWWc2?=
 =?utf-8?B?TlJ4MXhUY2t4MXVTcjFqRjUwU1pwcnJjb01reCs4RVRtOWp0Y1JxY2V2Uzhr?=
 =?utf-8?B?VG8yNDlQcytWUzNRelZYZWcwVlpTQVZpNFljZFZRKzZUUHozMXRPRFZQbldq?=
 =?utf-8?B?cURYWmxiVFJrTHJpZEtLTUhQTnFWSkk5Zm1EMUk5NzloZHYvN0xvU1hZaktF?=
 =?utf-8?B?ekZMRWRLTnQzQXlqRm43cFI3amQ1SGM5VGx3UjVTWElXb3lyUlYwRzdRdy9T?=
 =?utf-8?B?Uis2NzlFVlpWc3c2TXZMbHE2UTlIRWhHVTYvMjNDZmtPZ0ZUNmYxT0FBQ1JZ?=
 =?utf-8?B?d2JKVTU0S08zWjd1cmxxMU0wdkZxekhIaEROa1VCREJja2FXbUVTaXFPMlVl?=
 =?utf-8?B?UGVZak5VT014MHp2WmE0dGhGckVFTGNieEVnQTQwYWpVRjlVa2l6dTJQTVUy?=
 =?utf-8?B?b1pQdkZwcVBRSk1rTjN5dWhkbTBoM1B2ZE9TcEl6Z29rOUk5MUZuTDg1cWx0?=
 =?utf-8?B?Q2hQMDBYc0VGMFNUS0djSXhUbWZ4MGNlWFozK2s4cVRHdGJOdmU3U1FPREta?=
 =?utf-8?B?NmRNOHRuczhQNjhWOXFiblBFcGV5ZzdOcWZQRWRCOW1oWjJTU0RPeDdNMDJD?=
 =?utf-8?B?bmU2NEsxUitPMUdFRVR4cVNXVHVEdEJjUTMzOXp3NlRWNlZjeWpxUHlkQVRT?=
 =?utf-8?B?bHVONkxDbC9DMmFNUlMrZjJSN0pwWW84WC9QMU1OM1dpS2NuZVdZSFhiVmtX?=
 =?utf-8?B?WWVHanRQZUZVbWxxN0VtdndXOEc0TGZITmZnNE5YblhmV25rVU9KVzk1T1lU?=
 =?utf-8?B?Z3dGbjRCV3dvVmVUWHR2aGdrZytONmR3RnYzOHNrWE1WVlhUeGg5NlFwOVBl?=
 =?utf-8?B?eENhZWFyS1FjM0pQUVB2a2JLMnJXb2FOMnZqTUZpb0xlMmhCRjVCTWN4d1g0?=
 =?utf-8?B?dlZKSDI4MmVvWGJMWnBpRUt6YnlmaWhiQ0l0L3p3Q05sMGc3SGsrQzBkMmZz?=
 =?utf-8?B?MzlKdHFSa3J3RFMrSjAwRGs2TFZ2NitQZjBzaGJnRGw1R3ZCWTdEa3NxeElX?=
 =?utf-8?B?dTJlb3ZnaCtYb05aT1Rza3ZsTjREREY1ZzdSWWVnTmc1cTNMbjZ4RHNSam5Q?=
 =?utf-8?B?MExjWWt0QjZxcGVuUkdWQ0ZvZVhoNkticUFUQmwvb2c3Wk44emd6VkhYY0Fw?=
 =?utf-8?B?bXhSR05NeERydkc3Z01Ma2ZTQVhQYXpPcmFjVVdKY1h2dDZRZE94NWZPQU9F?=
 =?utf-8?B?TDMvbUhBeGc0YS9GdysyamYraTU0STVjSzVQQUFhVW9mQ2VISWo5YSsxQ053?=
 =?utf-8?Q?sWezQbcnunFWUF8oQDLEmME=3D?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a277261f-5a9e-4a4a-0be4-08d9a352c4a1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB4108.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 07:30:13.4408
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 46cFX1FLdNHW6udlquDjOTh6+zpSDaydx8Dsqh/Yj82j6FkWJLb72q5ZC9+OP8IujRQohEKccvpSV026TK+lEQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR02MB2557
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Xiang,

在 2021/11/9 11:10, Gao Xiang 写道:
> Hi Jianan,
>
> On Tue, Nov 09, 2021 at 10:54:44AM +0800, Huang Jianan via Linux-erofs wrote:
>
> You might need to add a "From:" tag here, otherwise, the author will
> show "Huang Jianan via Linux-erofs" due to your mailing server...
I have used --from, maybe I need to add on the patch manually ... ????
>> Add sysfs interface to configure erofs related parameters in the
>> future.
> s/in the future/Later/
Will be fixed.
>> Signed-off-by: Huang Jianan <huangjianan@oppo.com>
>> ---
>>   fs/erofs/Makefile   |   2 +-
>>   fs/erofs/internal.h |  10 ++
>>   fs/erofs/super.c    |  12 +++
>>   fs/erofs/sysfs.c    | 239 ++++++++++++++++++++++++++++++++++++++++++++
> At a quick glance, we might need to add sysfs API documentation
> as well:
> Documentation/ABI/testing/sysfs-fs-erofs
I will attach it in the next version.

Thanks,
Jianan
> Thanks,
> Gao Xiang
>