Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Yihao Han <hanyihao@vivo.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com
Subject: [PATCH] lib/bch:using swap() instead of tmp variable
Date:   Mon,  8 Nov 2021 22:32:49 -0800
Message-Id: <20211109063251.11215-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LXPnOlO/1eJoZSlnzFGZQx4XmBKAcXT69fyuau6kNCclAPS/wekqV+pojGM/?=
 =?us-ascii?Q?cXl1M3TrWFWCjVjOBtr+r9k39M/JHPmGLoR6ZTRZtA3m+8rpZ7c2jzM4wiTA?=
 =?us-ascii?Q?n+w7sHgGdnruPkhybNHKhMtnDRcl9WyftadQG2Fkw8F9t/LXh818CN56JJ9M?=
 =?us-ascii?Q?Mupaiq4qBNFUEUZvrqFRxFzV/wmFTr8CG0M/hidnx7S4FXtEViXG/Olp+1Lc?=
 =?us-ascii?Q?FjuKVtaAESUxyzZcElKRYyNx6eC+XZ7sL4VYDAxF8jc0kC7WmOiOlwmA8cto?=
 =?us-ascii?Q?6tD/3rEk4XOTSHk+wSKhZNvRgLGiHBiOhAPVa6bi7PlUvcb77rtZWS8Ihkcm?=
 =?us-ascii?Q?vbBIdyeAYdngwunzCfcDqKp2KxAvQs66Ht4f7LDDnT2flov0Lco9HRJAoF69?=
 =?us-ascii?Q?V+FPHfn3a4hBysJ7zrefYgJjuZSJnMmXUPeiiqSAMW4ZttEqhOVAGCN98O8T?=
 =?us-ascii?Q?c5WT3UpfcD5XmkFiU5AvqKhZXiqO0b9Oyd8zsKhnGBNoHRLSN6qPJjaIKAkY?=
 =?us-ascii?Q?0le9LdZCS/fJMx3U1ZS4PKi+ckyKyaW3r4NscUjUFxXMPgW6/ba0b6LX4U7q?=
 =?us-ascii?Q?AvpTx/hvne6354v1iEfe4gfmcWnLIA2ajewbQuZ001Wkf4QoiWi4Mq1yePgs?=
 =?us-ascii?Q?g6CVpAFvtyKFWcWtf7WN9q36eCItDIwFdbh0KAKS++3AysD2EHdhTQXGxCn5?=
 =?us-ascii?Q?BYLhEo6vlQs7Vn7ollXiE2RasLf5A1rfGJPJoOtsDSt8VtN+zJ32ookYtROP?=
 =?us-ascii?Q?5lHZ0o3zR8maLyLiuTD6mefIs+m1PCWmT73e5IW0Mbxh9upaATGJ0hm6SPPA?=
 =?us-ascii?Q?M3KC21iZGqeoRSihq1qDjDKUuc/KM6GT7fOHPgC81/47s9vGikCNnX9Jydzi?=
 =?us-ascii?Q?yNqkHv+hNNd9TVLPcab1LEdaHewe6cXQ0gjLe/S8Pu476CQt4p8U8VGFcWV8?=
 =?us-ascii?Q?RH2Af1YRzYp4GDgT0G1LSytaJCYaOrNZdTSs5zLfDSmVIukWnJxuo3WumiSP?=
 =?us-ascii?Q?7EqpqF6846EOR/NHbdSIAc7oHxFWT0Xzs7OkdgI0cI44++t81DCAWb80Ve5a?=
 =?us-ascii?Q?tegbZC7MHXtKwF5ecTLRsvGKv3557gWS5ZzxVoJ5WStphwM+130YdrR7VZyy?=
 =?us-ascii?Q?Yz3JCegcOLKRxXUQ4hL7fom1XKpiPDQrg8rn5g/fUoniRDa8/c4rbhg67DZu?=
 =?us-ascii?Q?jvXiQaRDdby/li4rpcg8kikL/L46EvDDxLJVRyhQEQvwaAY4PQiHKNTqiIJl?=
 =?us-ascii?Q?Ex3Bdci0mNIM01PSR/JmcUtzaUb3LbkM1IPh1559PiJQTa6tkBOjeFzas49V?=
 =?us-ascii?Q?qoERi/zngGSWSWUJbnEZp8FHI7934juQ6yY7hAJaUqzD7yBQFmrlOreR9oXK?=
 =?us-ascii?Q?zxYJfYYqtAS9nasZ+6EzOCtzU8MPgY8vTC1JQqBUNbaeTX3P61kLvmuwVI/D?=
 =?us-ascii?Q?CVbL3gzCW/xW9W+Duc25uB+fkNNVYPs4ExFX/TsgG4/8Y2ZnZxFyHInlqkRN?=
 =?us-ascii?Q?zxmtq14EaYt4vZGgo+2jgTKmdXhm9OGf/WYqWIlyWanEW0858c+sfOubVjew?=
 =?us-ascii?Q?lytdnu7XWyaPcJRjj/5IqbyjUev+aP6Whc8JiQXrLhpv6LHQ6CiyBZgVIk5g?=
 =?us-ascii?Q?N1m/sO77m+ej+9TX87/TyvU=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b7d00f75-1791-4a76-4f57-08d9a34acdff
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 06:33:13.1989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: urvRqXJ9XnzGdV4m42Rp9pRg1LqcIrWDc/wvdW1SM9aGMjOxHtc2d2VZQ75L/9YuzjQ5dxiNuebu5DBiV4gbig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2416
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

swap() was used instead of the tmp variable to swap values

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 lib/bch.c | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/lib/bch.c b/lib/bch.c
index c8095f30f254..1c4ddb2d845c 100644
--- a/lib/bch.c
+++ b/lib/bch.c
@@ -500,7 +500,7 @@ static int solve_linear_system(struct bch_control *bch, unsigned int *rows,
 			       unsigned int *sol, int nsol)
 {
 	const int m = GF_M(bch);
-	unsigned int tmp, mask;
+	unsigned int mask;
 	int rem, c, r, p, k, param[BCH_MAX_M];
 
 	k = 0;
@@ -514,9 +514,7 @@ static int solve_linear_system(struct bch_control *bch, unsigned int *rows,
 		for (r = p; r < m; r++) {
 			if (rows[r] & mask) {
 				if (r != p) {
-					tmp = rows[r];
-					rows[r] = rows[p];
-					rows[p] = tmp;
+					swap(rows[r], rows[p]);
 				}
 				rem = r+1;
 				break;
@@ -833,21 +831,15 @@ static void gf_poly_div(struct bch_control *bch, struct gf_poly *a,
 static struct gf_poly *gf_poly_gcd(struct bch_control *bch, struct gf_poly *a,
 				   struct gf_poly *b)
 {
-	struct gf_poly *tmp;
-
 	dbg("gcd(%s,%s)=", gf_poly_str(a), gf_poly_str(b));
 
 	if (a->deg < b->deg) {
-		tmp = b;
-		b = a;
-		a = tmp;
+		swap(b, a);
 	}
 
 	while (b->deg > 0) {
 		gf_poly_mod(bch, a, b, NULL);
-		tmp = b;
-		b = a;
-		a = tmp;
+		swap(b, a);
 	}
 
 	dbg("%s\n", gf_poly_str(a));
-- 
2.17.1