Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Meng Li <Meng.Li@windriver.com>
To:     dinguyen@kernel.org, gregkh@linuxfoundation.org,
        richard.gong@intel.com, atull@kernel.org
Cc:     linux-kernel@vger.kernel.org, meng.li@windriver.com
Subject: [PATCH] driver: firmware: stratix10-svc: schedule thread out when there is no data reveived
Date:   Tue,  9 Nov 2021 15:46:13 +0800
Message-Id: <20211109074613.13994-1-Meng.Li@windriver.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?LgBKHtwSUTqVi3HJWl1RV4WfGXdClXcAr9LqNvYcqKzND/9eoaIzRSYtkUtc?=
 =?us-ascii?Q?2f1gRowP4zq5Q3AEJ6ue0lZ9IAQWOijSYiDTmbIaYw/2Kr0QTtcASaSp7TSe?=
 =?us-ascii?Q?oM59SLTFRDY3CBOPq4XBUp5lwiOXUxGp9d+8xlwq2dSmJkb0Se041xh1AAPH?=
 =?us-ascii?Q?tYHF05Jc17Tc9gmBlm9oCDPY8PPzxhWzFbm6253Qf9ugpUoc0fQ4tS/rB1RJ?=
 =?us-ascii?Q?KLifE2QKX9YasFe/z1+W8B1efd9Zobe3IPkzRGJG/HXmWqgDHSLjx4NWKQLD?=
 =?us-ascii?Q?oNVKoslSEZAeNS0n0ksH2EgvO7BZTNjbkxM19KJuiCkRTUwDV61s22JnLSG/?=
 =?us-ascii?Q?tbSxWwyr7y7SyVp0mf7uVKq6jdIotS4b2L6VJXf/P6AraCLjelIiEqHvVcQs?=
 =?us-ascii?Q?Wjl/B0CEwd9x9Zf/vc60QDvx6i9FNpZ9iW5SSla1ulDFtlts5NO2EArpRhkO?=
 =?us-ascii?Q?+nTZex8lkwxSxit8pfTmoVeVh3+IDyjNLyxIWEgqSKfO32gUdmP11j2rbJwG?=
 =?us-ascii?Q?ORY1PdYp9crHVRgAhn7fr/qDC523EE0Kh+xDNhZP3oDyxp/9qtARfh2UHEr2?=
 =?us-ascii?Q?X+yEcDcTQDIVLdc/hhqTw8pALVUYkO0GXlBYv+gnhwLb+AS7rrvIBZGW2U5h?=
 =?us-ascii?Q?bpnAqxo0J3ayewV3M6db+q3hNK4GH2kIHnCM8KjUJU8X10nIMchPBPoIeIfj?=
 =?us-ascii?Q?rDXXlhgHHvSFF4K1OjPPfSAkNiS/SO+TndomDy8yjXmFky3RqL68fglaZrfi?=
 =?us-ascii?Q?v4AXFAlLOcSF3dBk99zCMkq/JcDT4fnAUgLu7rs25DJFtXBneEdx9fBkWGbL?=
 =?us-ascii?Q?Dtzo+r+IKU2+f7yJ6Ui921qk7WVpOf8BrEXHs86aMW1ObCXdZu7At2CF1Vof?=
 =?us-ascii?Q?z5GfMpc5RAnPk5DAmlQgAleQFiMDSZbU+Fb4rjs3mVeGiUNoiYshoYwEtipj?=
 =?us-ascii?Q?Z03dM4DhLrR6vNGwuXmD3OnuT30CVhy1RiGD5AiqPqcNNinblWv3rPP/lrnO?=
 =?us-ascii?Q?O9Yn3YZ8s1IPsXrDnad5UFA6049SSqzeiSlBMXq4Wi05K1WGl6fRWMlJ8IV1?=
 =?us-ascii?Q?Bm3wKuTGiWpIZfBdo3ZfeFV3OO/n7vMfDXt4j5StONm4zjO00msjV5IkkhHw?=
 =?us-ascii?Q?K5KcHaRWSMbzdyBqvWyqkOzxJ1jp8Tg4gGnVmAE4qQOLMDuyAI2Xc06/EIwD?=
 =?us-ascii?Q?iPhN/5qUwFil3nDQUyk+RwKABahaYKpAWhH0gCEkeVYZeZEvg4UCQCDfHJeL?=
 =?us-ascii?Q?f/owfkGvyNJIFmWrFX8G+xtcPttcGcWr2IozIPbPVh7D51e5/mwyzLe+cMve?=
 =?us-ascii?Q?tX/jvT9O4qSs1t0bZDNfFuLAtYNrUONJMNrIFnJEmNb82aS2oon4aBgbxHif?=
 =?us-ascii?Q?W5WFtYu/57VU38se5pfbsJE2AbqnVc4W0R0dg18yLg8S7fUZKDJoZHr1KFzc?=
 =?us-ascii?Q?kMeZH8dfIsQsKrA+kPeYDBVDNVBtFpXOiu4zzh6jn1jOuj0LGbdJQkVl5T/+?=
 =?us-ascii?Q?X7P/gelzt6/s2ZFqd2FOpxx6Ayz+wwRdWWJflprs34foR4g0hS0MDPg9/Uo+?=
 =?us-ascii?Q?8W5wclVILItTjwbzWMAQ3wyQiBmxXlAtakfRntQwQ4OXizFMdt/eQVgN0TPD?=
 =?us-ascii?Q?IHfAv/hUAYbzM/jSCus27zE=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07b51a44-0f10-451d-4c53-08d9a3550ad1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5191.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 07:46:30.0095
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 90Mgyr8AG7Si6oOUBQV0ywOLZsRsjOC6pFtoHFxvvjUO1oLCQnatqqZAMj7opAxPUxVNrdopcSvfPhQwZn9SmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4791
X-Proofpoint-ORIG-GUID: syvk4JNkUbMKm6DD_krSN6oVIuPFsCjm
X-Proofpoint-GUID: syvk4JNkUbMKm6DD_krSN6oVIuPFsCjm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-11-09_02,2021-11-08_02,2020-04-07_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1011
 bulkscore=0 mlxscore=0 spamscore=0 mlxlogscore=999 phishscore=0
 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2110150000 definitions=main-2111090045
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Meng Li <meng.li@windriver.com>

In thread svc_normal_to_secure_thread(), function kfifo_out_spinlocked()
always return, so this thread can't release cpu even if there is no data
received, and cause cpu is under heave load status. System performance
is poor.

This issue is introduced by commit 7ca5ce896524("firmware: add Intel
Stratix10 service layer driver")

Therefore, schedule this thread out when there is no data reveived, and
wake it up after sending data to it.

Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver")
Cc: stable@vger.kernel.org
Signed-off-by: Meng Li <Meng.Li@windriver.com>
---
 drivers/firmware/stratix10-svc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 2a7687911c09..ddb86d441726 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -365,8 +365,10 @@ static int svc_normal_to_secure_thread(void *data)
 						pdata, sizeof(*pdata),
 						&ctrl->svc_fifo_lock);
 
-		if (!ret_fifo)
+		if (!ret_fifo) {
+			schedule_timeout_interruptible(MAX_SCHEDULE_TIMEOUT);
 			continue;
+		}
 
 		pr_debug("get from FIFO pa=0x%016x, command=%u, size=%u\n",
 			 (unsigned int)pdata->paddr, pdata->command,
@@ -861,6 +863,7 @@ int stratix10_svc_send(struct stratix10_svc_chan *chan, void *msg)
 	ret = kfifo_in_spinlocked(&chan->ctrl->svc_fifo, p_data,
 				  sizeof(*p_data),
 				  &chan->ctrl->svc_fifo_lock);
+	wake_up_process(chan->ctrl->task);
 
 	kfree(p_data);
 
-- 
2.17.1