Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp170661pxh; Tue, 9 Nov 2021 08:55:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXxJAm76LdBEmc2BH+Z5GOBNWWmF0/6R02TbG7q6Yo3WsSYhYxH9s+Bvn14Bx5dlo2FJ2g X-Received: by 2002:a17:907:9156:: with SMTP id l22mr11541248ejs.220.1636476927201; Tue, 09 Nov 2021 08:55:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636476927; cv=none; d=google.com; s=arc-20160816; b=Ks8szbvGqaX/Ej50T0L6v9a9tWuTnIkIb5NKoNHyaPw5LfNmVWcabkbgSi/UX00CKw rWxz99zsQEZgJnYSpr1ee2JGALhMgHYpGpUcWBSzUWvv3HugaJp/l/PN20DlZgs8nmg5 anAmP5ApAK7qi2WJf7KS48H2STpTHXV25bGAZ1oDkoF4/tvF4EjSfd955uxg6SsAu4Pm V0dNORwVpUjuIklwnq7C8RGNxK+9oQpRVSPsTX6L5+hvlaU7FIt6BRAYmEOiyh398og7 whpd44GXFigY5sSbGIFClw8Q4u+bHZq9r72FJoxFMHm8/xne4iMofK3qiO5VuRJpiFTZ YDlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GN/TiYAGxbJFcwzF452hC/K/+sMsX4GUTUxvtXcs37c=; b=clSo7Q24aiwFyUDKsbpBlNhKrTcDlkQo4TEpBFydcYZE8kIxZOBoL9zoSI3aLP44Q/ 2pgO/TLKYGgdlxZEz/hA7WXvG2a2PIvrBRALc8/Juhn/Ndl+rb6JHlGp3Ceg0a4m/dDR 0Ol2MIG6YbGth5XUuLjs7l8Gb+lYnA4Fxx0dL1nt0OW8QNg6fi1yVfIA53aIdeVc/Lqu xn9PQfv5RKE9lxcLpZw3HLL2Iy4BfjXgdrwjfcDO1+1lIUfmqNrq+kRSvdNV/FX2Ajpv 0zRxyVdGRI02PCIN8SfL/dJvSQ+0KVd6Jli7E4OtR8FwRqoBdisx/zmjIr0JBnIQtkks RKpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gn32si37254272ejc.449.2021.11.09.08.54.59; Tue, 09 Nov 2021 08:55:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243919AbhKIIJW (ORCPT + 99 others); Tue, 9 Nov 2021 03:09:22 -0500 Received: from verein.lst.de ([213.95.11.211]:48976 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243915AbhKIIJW (ORCPT ); Tue, 9 Nov 2021 03:09:22 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 6199A67373; Tue, 9 Nov 2021 09:06:34 +0100 (CET) Date: Tue, 9 Nov 2021 09:06:34 +0100 From: Christoph Hellwig To: Enzo Matsumiya Cc: linux-nvme@lists.infradead.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] nvme: add NO APST quirk for Kioxia device Message-ID: <20211109080634.GA28581@lst.de> References: <20211106020858.18625-1-ematsumiya@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211106020858.18625-1-ematsumiya@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 05, 2021 at 11:08:57PM -0300, Enzo Matsumiya wrote: > + }, > + { > + /* > + * This Kioxia device times out and aborts I/O during any load, > + * but more easily reproducible with discards (fstrim). > + * > + * Device is left in a state that is also not possible to use "nvme set-feature" > + * to disable APST, but booting with nvme_core.default_ps_max_latency=0 works. > + */ Overly long lines here, but I can fix that up. Do you have a product name for this device or is just a nameless OEM controller?