Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211104224033.3997504-1-kieran.bingham+renesas@ideasonboard.com>
In-Reply-To: <20211104224033.3997504-1-kieran.bingham+renesas@ideasonboard.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Tue, 9 Nov 2021 09:29:01 +0100
Message-ID: <CAMuHMdXVBj58ZM3LqCN3cudsE3VJV8AQC5OCOJP96RaqYf4NDQ@mail.gmail.com>
Subject: Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
To:     Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
        =?UTF-8?Q?Niklas_S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>
Cc:     Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Kieran,

On Thu, Nov 4, 2021 at 11:40 PM Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The thermal sensor bindings were not matched correctly against the
> expected naming scheme.
>
> r8a77980.dtsi also used a different naming scheme compared to the other
> related platforms.

It lacked the labels, which you added for consistency.
Is there any point in providing them, as there are no users? Or should
they be removed instead?

> This series cleans up the dtsi files for the CPU target thermal sensors,
> allowing the validation to run.
>
> Enabling this validation shows up a new validation failure:
>
> linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml: thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0: 1024 is greater than the maximum of 100
>         From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
>
> This validation error appears to be pervasive across all of these
> bindings, but changing that will be more invasive and require someone to
> perform dedicated testing with the thermal drivers to ensure that the
> updates to the ranges do not cause unexpected side effects.

Niklas?

> Kieran Bingham (9):
>   arm64: dts: renesas: r8a774a1: Fix thermal bindings
>   arm64: dts: renesas: r8a774b1: Fix thermal bindings
>   arm64: dts: renesas: r8a774e1: Fix thermal bindings
>   arm64: dts: renesas: r8a77951: Fix thermal bindings
>   arm64: dts: renesas: r8a77960: Fix thermal bindings
>   arm64: dts: renesas: r8a77961: Fix thermal bindings
>   arm64: dts: renesas: r8a77965: Fix thermal bindings
>   arm64: dts: renesas: r8a77980: Fix thermal bindings
>   arm64: dts: renesas: r8a779a0: Fix thermal bindings

For the whole series:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds