Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211102165657.3428995-1-robert.marko@sartura.hr>
 <20211102165657.3428995-2-robert.marko@sartura.hr> <CAHp75VdnQq76f5Xeo5LCq83sr4TbcXY_mtZ4x_rFzUkS01BYZg@mail.gmail.com>
 <CA+HBbNEEPHLbJSdWPdxWb5gASha_NavJrEBBRkbvzEW2aDSjmQ@mail.gmail.com> <cd0b876b5a043de21179eea01ca0344c@walle.cc>
In-Reply-To: <cd0b876b5a043de21179eea01ca0344c@walle.cc>
From:   Robert Marko <robert.marko@sartura.hr>
Date:   Tue, 9 Nov 2021 12:17:45 +0100
Message-ID: <CA+HBbNEcHi_tmat28RRNvw6dppv_zKLY3+gC1uELE9STaNqQ6w@mail.gmail.com>
Subject: Re: [PATCH v7 2/6] gpio: Add Delta TN48M CPLD GPIO driver
To:     Michael Walle <michael@walle.cc>
Cc:     Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 6, 2021 at 12:19 AM Michael Walle <michael@walle.cc> wrote:
>
> Am 2021-11-05 12:34, schrieb Robert Marko:
> > On Tue, Nov 2, 2021 at 8:28 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> >>
> >> On Tue, Nov 2, 2021 at 6:57 PM Robert Marko <robert.marko@sartura.hr>
> >> wrote:
> >> >
> >> > Delta TN48M switch has an onboard Lattice CPLD that is used as a GPIO
> >> > expander.
> >> >
> >> > The CPLD provides 12 pins in total on the TN48M, but on more advanced
> >> > switch models it provides up to 192 pins, so the driver is extendable
> >> > to support more switches.
> >>
> >> ...
> >>
> >> > +static int tn48m_gpio_probe(struct platform_device *pdev)
> >> > +{
> >>
> >> > +       const struct tn48m_gpio_config *gpio_config = NULL;
> >> > +       struct gpio_regmap_config config = {0};
> >>
> >> I don't see a point in assigning these variables.
> >
> > Hi,
> > The NULL one isn't required, but the regmap one is, otherwise the
> > devm_gpio_regmap_register call will
> > return -EINVAL.
> >
> > It will fail here:
> > https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpio-regmap.c#L209
> >
> > I see that Michael Walle who did the GPIO regmap uses it as well in
> > the Kontron CPLD driver.
> > Michael, can you shed some light on this?
>
> I guess this was already clarified? Because you don't set
> all the properties of the config you have to initialize it.
> Otherwise anything could happen.

Yeah, I think it's clear now.
Thanks,
Robert
>
> -michael


-- 
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr