Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 14:24:27 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Jiri Pirko <jiri@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
        Ido Schimmel <idosch@idosch.org>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S . Miller" <davem@davemloft.net>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        edwin.peer@broadcom.com
Subject: Re: [PATCH net-next] devlink: Require devlink lock during device
 reload
Message-ID: <20211109182427.GJ1740502@nvidia.com>
References: <YYlfI4UgpEsMt5QI@unreal>
 <20211108101646.0a4e5ca4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YYlrZZTdJKhha0FF@unreal>
 <20211108104608.378c106e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YYmBbJ5++iO4MOo7@unreal>
 <20211108153126.1f3a8fe8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <20211109144358.GA1824154@nvidia.com>
 <20211109070702.17364ec7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <20211109153335.GH1740502@nvidia.com>
 <20211109082042.31cf29c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211109082042.31cf29c3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7pDZT7GXQAm1tmoeMjOI4PKJw3M6PjiVYr4Unv5uE2lXhjv2dHWyLLzg6q7e?=
 =?us-ascii?Q?EuFKt8wbNFrNFDEwp9HhCNxxXERHfsi4DCXcxMpvppVGmBbx6PL+hI2Fr8A6?=
 =?us-ascii?Q?d3RMklX0S85rTGopo1E9FjWJ/7orOeMHsk/hTe1xNpv4ZyMdrbkOroG1ydBD?=
 =?us-ascii?Q?R+aZ0RD0xLYk1/Qz+tWvckwRL3Z7VhomZ+9d77NhTCCSnuyPtKnr7pwFQARo?=
 =?us-ascii?Q?WDs5VMiYJ8s/GJT8N43Wzow5gNWhYw0dCMtJe6i6fb3AI/nb62IIWi9eCs7V?=
 =?us-ascii?Q?/a305wua9A1DWwIw4wLoQ4YvWJw0Zeeb6GrmIdENGvD+DajGaftEYUpw3YhR?=
 =?us-ascii?Q?Vaa3D+bymxkFIrhX/ai+oh17uHyKGgKRaiFWuxtjk3fTZjApWBeAzMssPI2X?=
 =?us-ascii?Q?JKEC8791sXALn6WtNAknKMbBmBkMloL8rAMrmQA4leNfxu8+uXVdPyXfgBfc?=
 =?us-ascii?Q?mnV5eI7rssjqaJaMB1iM/DnrQIyUzZQLXy3J6ycB7L+jilr17b4QHWsLwLEG?=
 =?us-ascii?Q?GtjX/SzfSn+2mjmdFthTfH/th9l9KPyTmlbjzgGwWtlCvH7tecIpCC5z+A0A?=
 =?us-ascii?Q?TS+RG96lOdl9WRbOKL91PuE5jh5vXIBd2yNnZKawnwdLffF3H859wrdSusoU?=
 =?us-ascii?Q?G/NxZHtt/ShBjwew+4Cuw8TuvWcGElvWo7pKcjkIjBFUACgws2i4QRnCtmId?=
 =?us-ascii?Q?ngHWnxfZA/bvV2g4lnrtg316r4rjN+8RlnDOmV8O47fKZSMaVsL88woM36J2?=
 =?us-ascii?Q?m4n8HXGiOHt2kCNTe/gWg292t+buu7PkNTy0gs0x7bovx70UKzfFxqz3Ulvu?=
 =?us-ascii?Q?KH0DSyVnzaqmDyTyCUFDkaDJ5eswIEI0irTZWD3apl837vmlJmZ5ot0GTQVx?=
 =?us-ascii?Q?JbBln3E5UM/Ngp00IwvA6xXJpcEj9VLm7tx/X7+tHVcbr3FI+NWhcDMOHGfM?=
 =?us-ascii?Q?vMXYasheSCvBHPnem/HnEgJT88NdcuWB83bHs4RQZXCUbegG7N3MwLEMXPlf?=
 =?us-ascii?Q?8vEBr9W8/Phq0VuLxVNPKCiDzXiUZcq9VasXwGwiyDlBHYdrZ2D0T8CY3Oiy?=
 =?us-ascii?Q?FVZOpl9NJothfXfo9YwcHgIlLJkWYP+PVV3R3jUJrHtTa4Eme8uXtzIwtl3/?=
 =?us-ascii?Q?VQZ3V1W+SxXuoNhZQV2pYXSCUEqSq6Lm4pRcvITq6iYXzsy9wFhtijb3PUJy?=
 =?us-ascii?Q?PZC7gLtUsizXsQdPFNM8D3A95L41AVtF8TgSovZvkC9hnvPwyy3KC3u7o0jK?=
 =?us-ascii?Q?HDWQ66uPnG34rWwFyV4bJhoqGAzt9/Y1BpbXJMPYTHKfj8DiZjRFqKOzu2vP?=
 =?us-ascii?Q?aLjgw5kckjBpJSD4lXfTZKgYHPh+XWMFZPHtU6cNS9ebBUY+2qaMovGg/QdJ?=
 =?us-ascii?Q?ySGQ88Hc3BpxdTz9m46TAyPTSSFM0E5Gghj2ET0V36pGQI0Q0Ckf6wW4FFBs?=
 =?us-ascii?Q?uPsWhqQZTJxhymjNDu6XqZNk4B8jBvO5dN6HRJd9hrZPD4Q9ufuuaca0iszz?=
 =?us-ascii?Q?ugAM4ZIm9zMjuk6BYLL0MaH/sxuOdGcaBGE9L1u1fng1gRPf7EnfJanP+9QH?=
 =?us-ascii?Q?NmElaXWe2yJsvG+p4LM=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c688f258-0bfb-41ac-c01b-08d9a3ae2ae5
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 18:24:29.0526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L9Cd/LlriKIVVROYP7yuyOOfvgXOsBIIjsepwokTwnyid/b3IyyVKjneq/zB8Yk3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5506
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 09, 2021 at 08:20:42AM -0800, Jakub Kicinski wrote:
> On Tue, 9 Nov 2021 11:33:35 -0400 Jason Gunthorpe wrote:
> > > > I once sketched out fixing this by removing the need to hold the
> > > > per_net_rwsem just for list iteration, which in turn avoids holding it
> > > > over the devlink reload paths. It seemed like a reasonable step toward
> > > > finer grained locking.  
> > > 
> > > Seems to me the locking is just a symptom.  
> > 
> > My fear is this reload during net ns destruction is devlink uAPI now
> > and, yes it may be only a symptom, but the root cause may be unfixable
> > uAPI constraints.
> 
> If I'm reading this right it locks up 100% of the time, what is a uAPI
> for? DoS? ;)
> 
> Hence my questions about the actual use cases.

Removing namespace support from devlink would solve the crasher. I
certainly didn't feel bold enough to suggest such a thing :)

If no other devlink driver cares about this it is probably the best
idea.

Jason