Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211109164549.1724710-1-ardb@kernel.org> <20211109164549.1724710-4-ardb@kernel.org>
 <YYrDkUsJVcOzxMPL@hirez.programming.kicks-ass.net> <CAMj1kXEW72y1p-qR+X6EBqM8Rf5+fZnEs2WSSz7b+eU=zvPt6w@mail.gmail.com>
 <YYrPJXlyQV5pXPHt@hirez.programming.kicks-ass.net>
In-Reply-To: <YYrPJXlyQV5pXPHt@hirez.programming.kicks-ass.net>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 9 Nov 2021 20:45:42 +0100
Message-ID: <CAMj1kXHERUa=btvKfaM7JwXmQM=9+XCtHShHuWBQKiV5V9Qidg@mail.gmail.com>
Subject: Re: [RFC PATCH 3/7] static_call: use helper to access non-exported key
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jason Baron <jbaron@akamai.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 9 Nov 2021 at 20:42, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Tue, Nov 09, 2021 at 07:54:23PM +0100, Ard Biesheuvel wrote:
> > On Tue, 9 Nov 2021 at 19:53, Peter Zijlstra <peterz@infradead.org> wrote:
> > >
> > > On Tue, Nov 09, 2021 at 05:45:45PM +0100, Ard Biesheuvel wrote:
> > > > @@ -196,13 +190,21 @@ extern long __static_call_return0(void);
> > > >       EXPORT_SYMBOL_GPL(STATIC_CALL_KEY(name));                       \
> > > >       EXPORT_SYMBOL_GPL(STATIC_CALL_TRAMP(name))
> > > >
> > > > +#define EXPORT_STATIC_CALL_GETKEY_HELPER(name)                               \
> > > > +     struct static_call_key *STATIC_CALL_GETKEY(name)(void) {        \
> > > > +             BUG_ON(!core_kernel_text(                               \
> > > > +                     (unsigned long)__builtin_return_address(0)));   \
> > > > +             return &STATIC_CALL_KEY(name);                          \
> > > > +     }                                                               \
> > > > +     EXPORT_SYMBOL_GPL(STATIC_CALL_GETKEY(name))
> > >
> > > So if I were a nevarious module, I would look up the above symbol from
> > > kallsyms (it is exported and easily obtainable) and then simply
> > > read the text to discover the key address and we're in business.
> > >
> >
> > Yeah I realised that. So would you prefer to have a
> > .static_call_tramp_key section in each module and look up the keys in
> > the module loader?
>
> Think so... do you actually have a need for this?

Well, not exactly. But the XOR patch I sent earlier today does cover
this use case, and would be broken if we implemented inline static
calls on arm64.

So the easy fix is to allow EXPORT_STATIC_CALL_RO() only from the core
kernel, and require EXPORT_STATIC_CALL_RW() otherwise. That way, this
can never end up being used in a way that breaks at runtime. Would you
prefer doing that instead?