Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 14:28:28 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Cai Huoqing <caihuoqing@baidu.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mtd: rawnand: denali: Add the dependency on HAS_IOMEM
Message-ID: <20211109142828.3e4ec837@xps13>
In-Reply-To: <20211109125457.213-1-caihuoqing@baidu.com>
References: <20211109125457.213-1-caihuoqing@baidu.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Cai,

caihuoqing@baidu.com wrote on Tue, 9 Nov 2021 20:54:55 +0800:

> The helper function devm_platform_ioremap_resource_xxx()
> needs HAS_IOMEM enabled, so add the dependency on HAS_IOMEM.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---

 Can you please add a Fixes tag?

>  drivers/mtd/nand/raw/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 67b7cb67c030..0a45d3c6c15b 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -26,7 +26,7 @@ config MTD_NAND_DENALI_PCI
>  config MTD_NAND_DENALI_DT
>  	tristate "Denali NAND controller as a DT device"
>  	select MTD_NAND_DENALI
> -	depends on HAS_DMA && HAVE_CLK && OF
> +	depends on HAS_DMA && HAVE_CLK && OF && HAS_IOMEM
>  	help
>  	  Enable the driver for NAND flash on platforms using a Denali NAND
>  	  controller as a DT device.


Thanks,
Miquèl