Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 10:43:58 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Leon Romanovsky <leon@kernel.org>,
        Ido Schimmel <idosch@idosch.org>,
        Jiri Pirko <jiri@resnulli.us>,
        "David S . Miller" <davem@davemloft.net>,
        Jiri Pirko <jiri@nvidia.com>, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, edwin.peer@broadcom.com
Subject: Re: [PATCH net-next] devlink: Require devlink lock during device
 reload
Message-ID: <20211109144358.GA1824154@nvidia.com>
References: <20211101161122.37fbb99d@kicinski-fedora-PC1C0HJN>
 <YYgJ1bnECwUWvNqD@shredder>
 <YYgSzEHppKY3oYTb@unreal>
 <20211108080918.2214996c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YYlfI4UgpEsMt5QI@unreal>
 <20211108101646.0a4e5ca4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YYlrZZTdJKhha0FF@unreal>
 <20211108104608.378c106e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <YYmBbJ5++iO4MOo7@unreal>
 <20211108153126.1f3a8fe8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211108153126.1f3a8fe8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i0Tx3zj8WFdoBcwD9UCiVY526G1hdvxTdDuYGbhxf514scLbuoQ2aJDTNxQa?=
 =?us-ascii?Q?7eeMRIoEDYg820UCADoKCsUw/RMib3+xhfVuux9ls3KDUtuioGMZE82874y6?=
 =?us-ascii?Q?ePl2JKhM5GBUSAkWF8PTgwtX3q0PFbG/6fNzSNb4UAw6GECe84SO8mL89lsv?=
 =?us-ascii?Q?lU51/wk0ZsGtb7f9CJT3soAGtNDlNXpiK24spkg/tAr5U0uZ7tx8eTlq40Gy?=
 =?us-ascii?Q?LYy6DyhU1LJbCxtSeRmExP3/dJolj75Exo+3DV09jwYvPsVOi/fZor7WjmRF?=
 =?us-ascii?Q?+QN+t5bzLDydvj1NYqN8lcL9YLO0yor2ApcW7cVZylKCn8QDjtR8bKYc4TWM?=
 =?us-ascii?Q?K2vcRtsWi3FE/zpHZjgJdNMIQ0qbN0kXELEksz7+obCKoZhI7TkbGkc9TmIn?=
 =?us-ascii?Q?cgM0hvybN51UOODweEiQ5PQvVkwBUNPzELvEYFbK0AC13nS0fyTKjk+6muXl?=
 =?us-ascii?Q?uyTeqvXTC/N7jUiMs3vddqx+91TL7wP2MddnX8dBzYaFy8EB1y0SHyEo3EPm?=
 =?us-ascii?Q?TsfLZqWqlVtezrb0PlMhEWXD1wA1H6mpz6L6hm7u5nFyYQT8dzdvEoIcscCD?=
 =?us-ascii?Q?eDsQf5/c1pz/0zuvIOTUOMbgDykWAg7jwF/55vNS9hlbpPdyLXo/adH18pIH?=
 =?us-ascii?Q?HzBPsA9cnzhLwqO2n51U9k4Lpf6xV7mmjjRU/SwFQiDsiBFC3SOstp8VPesn?=
 =?us-ascii?Q?ausMlHI//YaUYshZQ05ODXT47frOqlO7CQJ0940m6DlKZcorfb/pxkj9zK53?=
 =?us-ascii?Q?bpodzhdel/gwLAVPkYtLPycYFnJuYEbU5jC8SGE+LtIkTuBsa20hi43ms6AW?=
 =?us-ascii?Q?9MWbTudsQHTtXYjka+Ndzw6AF2VrbUGpn+TlxVsiFE+5gTFVu8LvftuZzsAW?=
 =?us-ascii?Q?6c5KKah6uEFt9X2tkIz/+bxj3iU8cd5ZioDJw2FCOxjvhyu0VY0J9ViKUznl?=
 =?us-ascii?Q?bL93DIW3ty3KnKOhCjzbFWAy+c6TKSqzpni3FQew3umNh0N8VK1dZK9sEGQb?=
 =?us-ascii?Q?W1BMR4QQj1Epp2Cyrux6MuCcpNje8a58cdCwU0gYAI7l6kx9tmhdA1V1It1P?=
 =?us-ascii?Q?9dp+CMR7M+KNQ4u34LDuBa02ISFMAGcTQY2XgaGpNpYF9aGaw+XShFSM9du3?=
 =?us-ascii?Q?Y11Md2JqZMkKZyiYPYc5W/cknCQIc2Z1RSxVZn/lYlc9x6mIAK8nHp14lxBe?=
 =?us-ascii?Q?4JP0y1EQAqHk/ifRZEI2tVZSI7n3OnWks+mjtmyqtNoIWFuMAI9XoljF3U01?=
 =?us-ascii?Q?O99BsumFaxa6QrpmvoXsWv2Se3XMDNvgr4K7G9CIFpv6TjDg/rFKNvQVtM7t?=
 =?us-ascii?Q?JZn4AplBCeviTOJXtNZYoXpGWrM6r+kHm12ndcldnFwgVWeX0k0HEFlTtC6y?=
 =?us-ascii?Q?6gPqX1G3WggTfsVKJDDMACo8QEexCCj4l8T6ZIdlF6p1gRCppBG7SDRTI1r8?=
 =?us-ascii?Q?RjFVJrjYKmyh2ihp81NYLYFQ3G8lOuAzmV2zHdmZrMYcuQZ8vixuBh3F2GEb?=
 =?us-ascii?Q?Vc0tyVwl2NGztokMLh61E7oNo3uZeeNyvXW9YD2rmrMXYAVbrlY6pm1PMXPM?=
 =?us-ascii?Q?gjSzvb98pDxiZuz90/M=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f3ebe99-9dc4-49c6-b3fe-08d9a38f5db9
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 14:44:00.0675
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FFTG1BB4RqA7a0q+TEzOo2APKZeqjfKeV9E/a0RH0c3zKjrZ9mEt+jsbRG7Ol69J
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5362
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 08, 2021 at 03:31:26PM -0800, Jakub Kicinski wrote:
> On Mon, 8 Nov 2021 21:58:36 +0200 Leon Romanovsky wrote:
> > > > > nfp will benefit from the simplified locking as well, and so will bnxt,
> > > > > although I'm not sure the maintainers will opt for using devlink framework
> > > > > due to the downstream requirements.    
> > > > 
> > > > Exactly why devlink should be fixed first.  
> > > 
> > > If by "fixed first" you mean it needs 5 locks to be added and to remove
> > > any guarantees on sub-object lifetime then no thanks.  
> > 
> > How do you plan to fix pernet_ops_rwsem lock? By exposing devlink state
> > to the drivers? By providing unlocked version of unregister_netdevice_notifier?
> > 
> > This simple scenario has deadlocks:
> > sudo ip netns add n1
> > sudo devlink dev reload pci/0000:00:09.0 netns n1
> > sudo ip netns del n1
> 
> Okay - I'm not sure why you're asking me this. This is not related to
> devlink locking as far as I can tell. Neither are you fixing this
> problem in your own RFC.
> 
> You'd need to tell me more about what the notifier is used for (I see
> RoCE in the call trace). I don't understand why you need to re-register 
> a global (i.e. not per netns) notifier when devlink is switching name
> spaces.

This becomes all entangled in the aux device stuff we did before.

devlink reload is defined, for reasons unrelated to netns, to do a
complete restart of the aux devices below the devlink. This happens
necessarily during actual reconfiguration operations, for instance.

So we have a situation, which seems like bad design, where reload is
also triggered by net namespace change that has nothing to do with
reconfiguring. In this case the per-net-ns becomes a BKL that gets
held across way too much stuff as it recuses down the reload path,
through aux devices, into the driver core and beyond.

When I looked at trying to fix this from the RDMA side I could not
find any remedy that didn't involve some kind of change in netdev
land. The drivers must be able to register/unregister notifiers in
their struct device_driver probe/remove functions.

I once sketched out fixing this by removing the need to hold the
per_net_rwsem just for list iteration, which in turn avoids holding it
over the devlink reload paths. It seemed like a reasonable step toward
finer grained locking.

Jason