Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp613843pxh; Tue, 9 Nov 2021 16:11:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJwIx9KlqJjfJVqV8YzGhU6C55how042X0FZrJBhT2CtosiZXMrnfWzcbvrniQbEcbv2jLO0 X-Received: by 2002:a05:6638:1923:: with SMTP id p35mr9175745jal.16.1636503107116; Tue, 09 Nov 2021 16:11:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636503107; cv=none; d=google.com; s=arc-20160816; b=fsSXY1sNK6PwoCJZ937Au9uShzcOEIW3dctiuGk205wm2fbPNBdt5w+YhG9q772t3m WUjPHipqnSYRfbV9YPTy9gFKMJI8OQzBbW5diQFhCapXySIdmxInQ8iTEvLKcjeuSnP7 lWwdESOSZlBtEi+eF9k9mOb/87QSldIpRYg+hE0dTrO1EfUI3WuizOVvRSrUaVl1AsaC Yt4DlayrpHdEpgSWTqw/lw9ITXoOTbAKwtk6kXyFTui/NPw75g1XvtRd886NLWUevX+6 yQA6qSzebuLP4q+frQZ+KevuGrMi7PuI1Lo2RWotseGzrXbHwJKAPN3QZej/D1txnMSU ow0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=iPx8PtVjRAEJKaeRj9ASLlLQi+k77E7ZU8+NhiKqr+4=; b=xtQACdma5w46R1iEq0DnuEZt6Weuyl0oOos5QqI8DXV/naPoBjo14eoiCwGWeRhoLy dj2xkRzNnpK7j5DFO3U9K8HeHAGBeaMCnkQ7r6KutfkOmXo9EjATwkWSCF3EGW2HrTeh HHe2EX92qjRBs9u6lLXi3NijryDg9R7QVotQB40KJ4vmQwk/+/1r3tnn8DJwhXttgYxy 3mqaAAwBG+mSvw0cA22Jj9DDgyJdMsgdqtr0izCks9ZIz5/wfv+jvaJYvm06pGIThv4z 1z/PhnYnZwRFGGaGEwM4yhWt3OGQDc6GMjKHpQgICL9hTLAgce+wd8vipHIGMKGv+QL3 mhtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="K/rq1xmr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si30338546jac.101.2021.11.09.16.11.34; Tue, 09 Nov 2021 16:11:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="K/rq1xmr"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241576AbhKISIl (ORCPT + 97 others); Tue, 9 Nov 2021 13:08:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241503AbhKISIj (ORCPT ); Tue, 9 Nov 2021 13:08:39 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8540C061764; Tue, 9 Nov 2021 10:05:53 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id v20so22383738plo.7; Tue, 09 Nov 2021 10:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iPx8PtVjRAEJKaeRj9ASLlLQi+k77E7ZU8+NhiKqr+4=; b=K/rq1xmrnqRYOU8htMZi8icnBxQVoLaIMcP3+xEYScFUOmRScZSgrW4NVsF4wt75G+ EVpvVjPWqUwqlEVSG1K6d2o5+mfLZNLNMwXCdqnt0/d6JU+VHn4SUuLCjoO8z/xT9vyH zwoQvUBg8ckkk/FX5lK/DGbXrMf0nSORPSAug2Z1U+gFf4A8e9sdf+SXrBZXTMfmzZmV O7br7BigyvmGO1gNxBDg6MKc41Yb2ktULIlgchTCAiGeZNTh1ORNJukdyUV0gmT1wH91 RHTd3gWMzwipii10Q1j/OAKY9OUaadKxnuCkEIr4lGlq+v98VVmPXkb2DqoaBS5gCARL sbRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iPx8PtVjRAEJKaeRj9ASLlLQi+k77E7ZU8+NhiKqr+4=; b=jTfC+QRQsT3FEvJB+01L92uJIiA6144hm4dx8/UFypWbU1jtcIOqH2M4uqgj1btTek kZnTxwDB+ffTuY3T08uMEW7du//F1Rbyqh5OHj6eUG2hEabKTWPaITFKw7jagnEp2Llq tP2lvArh+QHALcPXt9MZZssXlZW+vqKqqY/RsuubGwtMhUcAbqmkbNkbyxFawQ3apy7p vnM6mPi2s0kFQuD2dr+ylMQUwjPQHpTRG72gJZ+Vl5C76Meq8qTueoYv84DDV1MoFe2n dAHxvlZtnYISpLEi3V/LsRHjzEoGtly+JVFD4sIJ9KCDlDWXnoByoCVGmvWeU8tKGZNh pVYA== X-Gm-Message-State: AOAM532YkJp6zpt6GGTbo+jmQbDikuP5A7W5Z4aoxuMfJzgBpbiNM0fF dXzK0rFS6xwPc8lROrIxZ3wiQN3Ueus= X-Received: by 2002:a17:90a:8c0a:: with SMTP id a10mr9259230pjo.58.1636481153003; Tue, 09 Nov 2021 10:05:53 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z2sm21384375pfh.135.2021.11.09.10.05.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 10:05:52 -0800 (PST) Subject: Re: [PATCH v2 2/7] net: dsa: b53: Move struct b53_device to include/linux/dsa/b53.h To: Martin Kaistra , Andrew Lunn , Vivien Didelot Cc: Richard Cochran , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , John Stultz , Thomas Gleixner , Stephen Boyd , Russell King , Marc Kleine-Budde , linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20211109095013.27829-1-martin.kaistra@linutronix.de> <20211109095013.27829-3-martin.kaistra@linutronix.de> From: Florian Fainelli Message-ID: Date: Tue, 9 Nov 2021 10:05:51 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211109095013.27829-3-martin.kaistra@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/21 1:50 AM, Martin Kaistra wrote: > In order to access the b53 structs from net/dsa/tag_brcm.c move the > definitions from drivers/net/dsa/b53/b53_priv.h to the new file > include/linux/dsa/b53.h. > > Signed-off-by: Martin Kaistra > --- > drivers/net/dsa/b53/b53_priv.h | 90 +---------------------------- > include/linux/dsa/b53.h | 100 +++++++++++++++++++++++++++++++++ > 2 files changed, 101 insertions(+), 89 deletions(-) > create mode 100644 include/linux/dsa/b53.h All you really access is the b53_port_hwtstamp structure within the tagger, so please make it the only structure exposed to net/dsa/tag_brcm.c. -- Florian