Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zi Yan <ziy@nvidia.com>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     akpm@linux-foundation.org, shy828301@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: migrate: Fix the return value of migrate_pages()
Date:   Tue, 09 Nov 2021 13:10:04 -0500
Message-ID: <4A56EBD2-A839-44F2-8C7A-11C8058AD685@nvidia.com>
In-Reply-To: <6486fabc3e8c66ff613e150af25e89b3147977a6.1636275127.git.baolin.wang@linux.alibaba.com>
References: <cover.1636275127.git.baolin.wang@linux.alibaba.com>
 <6486fabc3e8c66ff613e150af25e89b3147977a6.1636275127.git.baolin.wang@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_C5B8A2F1-1E00-4D0A-BF3F-BE6B09D50CD1_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jNBDZQllKeOs5VgbwDl6y64M3ZrTpNqgll8ajIR0pveIfl+BTqM1mduht3Kw?=
 =?us-ascii?Q?NaYchxSgrPILQbIL59kexcbLDlKXfl02u7kvB6eUgB3u0VRUFT80Cd3IUMCA?=
 =?us-ascii?Q?yId0y9S429aD4/NwEQ85SqkJhi5tiPZKWfG28PLj5GBe6iNBZit5rg8ugALx?=
 =?us-ascii?Q?PSsKDNEi5BsjnMIiWh5cP03LT137gjfxbHbQc3OCz4hzDWoBJYGZegxw8zXn?=
 =?us-ascii?Q?G0wHFeOQmVCpZGw4YUsNC8+zWyq9XHLHwLaFSpR+itKszFQa9eDKJq5/hyMX?=
 =?us-ascii?Q?iuvOAY/YC7TCOtP00SiDz4cRXlEYeEfgSBq96CtTBMsZ16L1W2Owknx6JDlW?=
 =?us-ascii?Q?CpuwZiG3fy9vVvhhXceX/yiyTdRPBwcQqgGQaBLT1TI5/T+1aZrvSUyMdNen?=
 =?us-ascii?Q?TDYlxUB00unzZSVcQC0pGx+dm3Zy/+6fa4dZV7QpV6UM73J9WLviq5goo8gi?=
 =?us-ascii?Q?g+UgxX2I7HoqBsuPv9bFJQbDBWYp/jTG2+2YtF3y1AKG1DLKrJMOjMVI5GKX?=
 =?us-ascii?Q?Rw5WjMy9crmeUslQWqLTwJzYULzM9VU8Dm42AaSFrBbkCv+LLA9yFiyCtmFa?=
 =?us-ascii?Q?wpC7n5mTCOuAklwK+U+JMrMM1YvSxwmxJ63fi7ptXPWixTCBCLC/WsvGQeF6?=
 =?us-ascii?Q?8Vsd9O3wxXI42J+Xfn55q3pVawQIBnovMqDMziuNT066hbLt8u1XkkR0X7fs?=
 =?us-ascii?Q?tArMv/ziDk7URiYDDbpNwe0UQFsg3cBRWK0/QEhDLfML++yP3ZxNwm3PIiMG?=
 =?us-ascii?Q?OCR3msJCFTtelnO5OOi6NK8ErncgrmZ3AzCjl+CXdrNEKxFx2RlSKncIkg4L?=
 =?us-ascii?Q?JwX/ymRo6dGrO64+SqRJ3pZLW1NAh2AQPrJpZHq6kqGRpY0hSHHJU86qMyq1?=
 =?us-ascii?Q?hHjTMQEHt+OeMa2ZcPJZapmIxcUr1Ls/fwNdqueVaZgXKO40i+Hv5L1qfSt4?=
 =?us-ascii?Q?gXajyOD2nhkGuHZOxR+6sdAgDaoaVJtxqaZ/69GCH1XhqiIYzdK3cOE1/ChG?=
 =?us-ascii?Q?xakHn2bJFBUEsKLPgPBRTZfL/h58SFNXpxmm/ImKQG3vBMP+rhzmHj7YsTE4?=
 =?us-ascii?Q?UVGP57R4J0EhnmBKlXOy4AoC2foSOXMCxYEOGLHsmly4YdOQoYpuAz2G8l4j?=
 =?us-ascii?Q?GmqYSE9A8tefu3Z0cyjSJJTt8+q5W9VAP3jIyLPauWAL5TB793YgwomVmeOt?=
 =?us-ascii?Q?lyX/vDTydF/ALsjJg/Mr4dDQmfPsiFr/M1SDh+hM4KHnQlk/Ke9qaEG505J5?=
 =?us-ascii?Q?EKnnHklFrMysBnBWlNROameDxc3tg+WJn5xMz9+zPTlq3i+XTgO5B5rvTM9F?=
 =?us-ascii?Q?05VzgTlo5rlcMdNz/TJwypz2RI96x1myAV66+g5fsjuNUI5N48nWD6reJdhN?=
 =?us-ascii?Q?gzbx7BHryQAuBbopd8nrvgOpUlv/WpxI1u1MtQor0ekNemFeKgtdKhy77Pu8?=
 =?us-ascii?Q?GqQPcdNrsx5oyzH+jxuax12kKJGgc1nPv0u2UzVhPLZcOk6l0OXQqP8RcRsr?=
 =?us-ascii?Q?/lO3F9a4B2KUoPkWAlcl3ZWgDYOnc1UCN+mXBU5AgAc29Fjj4KJvhWwN7u6e?=
 =?us-ascii?Q?M1nMVNQcteyfqN7TP3M=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79c05c1d-5099-4238-0410-08d9a3ac2a79
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3823.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2021 18:10:09.3501
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jtwO1OZ358jQ+R+DKqPK5La4k96wni/LzOgAzvjOmo8h0t77bDa3DzzbsWNVzbbz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2337
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=_MailMate_C5B8A2F1-1E00-4D0A-BF3F-BE6B09D50CD1_=
Content-Type: text/plain

On 7 Nov 2021, at 3:57, Baolin Wang wrote:

> As Zi Yan pointed out, the syscall move_pages() can return a non-migrated
> number larger than the number of pages the users tried to migrate, when a
> THP page is failed to migrate. This is confusing for users.
>
> Since other migration scenarios do not care about the actual non-migrated
> number of pages except the memory compaction migration which will fix in
> following patch. Thus we can change the return value to return the number
> of {normal page, THP, hugetlb} instead to avoid this issue, and the number
> of THP splits will be considered as the number of non-migrated THP, no matter
> how many subpages of the THP are migrated successfully. Meanwhile we should
> still keep the migration counters using the number of normal pages.
>
> Co-developed-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/migrate.c | 63 +++++++++++++++++++++++++++++++++++++++++++++---------------
>  1 file changed, 47 insertions(+), 16 deletions(-)

LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_C5B8A2F1-1E00-4D0A-BF3F-BE6B09D50CD1_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAmGKuXwPHHppeUBudmlk
aWEuY29tAAoJEJ2yUfNrYfqK870QAKZ1bePaxzWpQPw2jrlNO2+XyBaKP4c7uZX4
Ji1m5+GD9Ko5971WtcFZiHC4tQvqKnKBHt00IjvN3buxXRJYflXCrW7YUbsPRq4d
2Th2RB1ipxcCDkIiKuzlVa1BLAJ0/FihmT6qQKnXDnKjPS4Nj6AY9/shQpOoc7rL
Rfs6pN89N/skNGpraUn/Cs1N6P3Qa+SimlcbUluVosuP0v+aHCwQdMkoklhWPw54
GcIvCduTlIb1eWg6JhaR1FKOhw0BtyW046VWAA78h82gq03ohk9QYdsUk4aw3170
g2IPWvsyHB1TcBIzT85liQCBxRlmY+dUyDtYrtWpTLoeVVRnzw0mVUC5h4gyVitz
p2OjOIifAS6ra3UN1skA3I71xlZs6Aq5oslz0s/lVD+JHJRfvROdRIQkWEJSi4d6
HDLkOt4+m2CGKspadSCIhoIEz0oPLIuhQ9UenDgpZpxcRbsrh/MMQE4MBnSJStTT
rKKjva3VWAW5lbKjTnYv1jQu5kwreC50kLsSNWoQW65d0EOP+CPrfzbLp8LZYcNm
VX2kruV9wYS+k98hp2pXqfIkeTi7tMLz9bJ2VAtKNnxonh6TcOQ5NW0nLWyV4Wz1
ZpcQqCgcwi/a3riwc58srxysZ8uaoYB6oJlKsDvCqS0ZoESaaKagFQaRVLYNUmv1
oZQ1do5q
=IzCt
-----END PGP SIGNATURE-----

--=_MailMate_C5B8A2F1-1E00-4D0A-BF3F-BE6B09D50CD1_=--