Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211109164549.1724710-1-ardb@kernel.org> <20211109164549.1724710-7-ardb@kernel.org>
 <YYrFOZT+6bNTfP+t@hirez.programming.kicks-ass.net>
In-Reply-To: <YYrFOZT+6bNTfP+t@hirez.programming.kicks-ass.net>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Tue, 9 Nov 2021 20:03:52 +0100
Message-ID: <CAMj1kXHQ3YjNNrZE_rS5qYgCoOqXHmPy=q_Ncp-iYmcFfZG50w@mail.gmail.com>
Subject: Re: [RFC PATCH 6/7] static_call: rename EXPORT_ macros to be more self-explanatory
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jason Baron <jbaron@akamai.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 9 Nov 2021 at 20:00, Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Tue, Nov 09, 2021 at 05:45:48PM +0100, Ard Biesheuvel wrote:
> > So let's rename these macros to
> >
> >   EXPORT_STATIC_CALL        -> EXPORT_STATIC_CALL_FOR_UPDATE
> >   EXPORT_STATIC_CALL_TRAMP  -> EXPORT_STATIC_CALL
> >
>
> Ok, let's pain this shed a bit.
>
> How about:
>
>         EXPORT_STATIC_CALL_RW
>         EXPORT_STATIC_CALL_RO
>

Works for me

> respectively. OR.. alternatively, have both:
>
>         EXPORT_STATIC_CALL_KEY
>         EXPORT_STATIC_CALL_TRAMP
>
> and those that want to export both get to use both.

Yeah but whether a trampoline even exists is an implementation detail,
which I would like to omit from the API.