Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 20:32:32 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jason Baron <jbaron@akamai.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kees Cook <keescook@chromium.org>
Subject: Re: [RFC PATCH 1/7] static_call: get rid of static_call_cond()
Message-ID: <YYrM0JLelRacIXHN@hirez.programming.kicks-ass.net>
References: <20211109164549.1724710-1-ardb@kernel.org>
 <20211109164549.1724710-2-ardb@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211109164549.1724710-2-ardb@kernel.org>
Precedence: bulk

On Tue, Nov 09, 2021 at 05:45:43PM +0100, Ard Biesheuvel wrote:
>  static inline
>  void __static_call_update(struct static_call_key *key, void *tramp, void *func)
>  {
> +	WRITE_ONCE(key->func, func ?: (void *)&__static_call_nop);
>  }

Ha, yes, I suppose that ought to work.