Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp622945pxh;
        Tue, 9 Nov 2021 16:21:00 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwY2E0BlZim72Vv3oqGQkyOhyfRS2FHoYOrr0dTR2rjZ5BXQRyfTqCTsgfKeo89mPsfzENm
X-Received: by 2002:a5e:cb0d:: with SMTP id p13mr8087867iom.71.1636503659726;
        Tue, 09 Nov 2021 16:20:59 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1636503659; cv=none;
        d=google.com; s=arc-20160816;
        b=mAe+5NC7TONAoARwbRNR5U85iYdrJGTYtRAd3qZemS+pqhF4Cvms33bFt4WJBjaM1D
         aVsUueMcdyNgv2t9dP9q2WS2iEURSuPUU8hnalfnzkGjQ7LPTA35UaloRBClHuPIDUWb
         fTLVxtykYEjWGsNvhiLJjGzVuI2fVnIc957Ag5SxaJUvbgKrGectdy571yl/Gl/xajAt
         deVKG0EMYOOl70CqUgej5H6CgHXkHyzTQz+N/+sxrfd05uktCRNp9jtnKn3iA7SYfUOf
         wdtlBIPkIBLOCZjsr1gUTI5V2sjf8Oo8oqSCQDMeq7/u/VdB0Mq4AvyS9RoG6PvHbgJY
         jL4Q==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=ISdBaAAZxQUmmew+eT+xWQieHGeAsJuSmIgOUah8Lms=;
        b=phQNqmZ60yeb50x6/FeEbUTMBYLeV3ER/EqJ/qhtmvImS5qdtrW7QLgubCoyypuV46
         uVrYWhNhHog+MLEQoMQXcOq4onFcHyn0YW5IHw0+D+apLl32wOvH4FIRvXrngqPyzQCu
         bS9c1CE2W1BfqJMgjjZFhxXiYli1os/pvUNvqdTGCFLStPj3AeqAvU18jdCtS+vax6zj
         dsbTBEYozMl487QaQQdsgNbkROOnfyOtMyPVnAdVJ7bqJu627yDIjFIEF2KGbWSd6Q0S
         eSZ1YsqRnHSmRC41AyMPHyLlUS7FeGMGm+cz1B97odAeaHqy4nUIa31AltOaEwz7drya
         4hqQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=4IFwaa3M;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id f40si11009019jav.41.2021.11.09.16.20.47;
        Tue, 09 Nov 2021 16:20:59 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=4IFwaa3M;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S245052AbhKIVZt (ORCPT <rfc822;ly15351151@gmail.com> + 97 others);
        Tue, 9 Nov 2021 16:25:49 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:53450 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S239453AbhKIVZs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Nov 2021 16:25:48 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=ISdBaAAZxQUmmew+eT+xWQieHGeAsJuSmIgOUah8Lms=; b=4IFwaa3MVWpYnj01oTr2Wgr/jm
        IBgAQezGpVubUMmjUSGBPbVJd8QA/VRAfOnOWe9+nnL4Ohr15dF0fIah4JL1msufZx8DZzfDx4nme
        wkia3A2ZLrz3ErWyCk39BCKqOF1KYPpBfttHHgaYvHCFGt1J6Sg4gvmCm5DpYpHh/oPM=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1mkYa1-00D1ZM-1r; Tue, 09 Nov 2021 22:22:57 +0100
Date:   Tue, 9 Nov 2021 22:22:57 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Ansuel Smith <ansuelsmth@gmail.com>
Cc:     Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Pavel Machek <pavel@ucw.cz>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-leds@vger.kernel.org,
        Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>
Subject: Re: [RFC PATCH v3 7/8] net: dsa: qca8k: add LEDs support
Message-ID: <YYrmselghIy+qtn8@lunn.ch>
References: <20211109022608.11109-1-ansuelsmth@gmail.com>
 <20211109022608.11109-8-ansuelsmth@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211109022608.11109-8-ansuelsmth@gmail.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static int
> +qca8k_parse_netdev(unsigned long rules, u32 *offload_trigger, u32 *mask)

This is a rather oddly named function, given that it is not actually
passed a netdev. netdev has a very well defined meaning in the network
stack, struct net_device.

       Andrew