Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp624708pxh; Tue, 9 Nov 2021 16:23:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJy88TiUnDSjCGutaUNk/Rs+ADh/RG+UaJxYMbZBwxw/n6PRxawJV5fBldsmUTGNZ4bKJX1I X-Received: by 2002:a17:906:3385:: with SMTP id v5mr15414373eja.45.1636503781625; Tue, 09 Nov 2021 16:23:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636503781; cv=none; d=google.com; s=arc-20160816; b=NbxsEoDSrELL+y1nJyQ+yd4EuXVHIuK5a/hfFTb/U6lMk1EVM2/LRb0oI/QsNTPK25 B4wEHsJuB5nAyTn8l3xEtFlKqbtgeIQHJwoNFINhL0R+vaNeEfug9YCvDzoaru+4aV0H u9xhVVtbEmMtfuE/TzIkNmwid7FYUklNLuDjrvCL8nb8dGlGh59r7E2QGUH2iMTtdkZ5 EO+weRMAsOclBmrJrVUF96I7fPJjDdUhHy2Lw4Hl5nO+6h5SGDJgNqhNrU7hCQarPEMK By+FuuPzU504IvfhuBi/JeGQof+6mcTZc6xQMiiKZPlpan3dhcRSMxSM5J+XLrzj+y+s VDvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version; bh=E8Y2jyNg7h9soMk4rEm6rzTo1BjlaELOxyIkvTVeIKc=; b=mbgnqMGKgvoM+QuRgmjfqnq+HVrTS1JxGEq0Ci48kgKY3aKIpXVsV6eqGpB8SB7FNG tA6hxnJsIktM/2hZggDi5yedQ8riuf7kS8vpzcKZBjj1acMuEW7zC42kmI4QSzL6b1jc ER7UN3aF1f5V++jZDCqffNO8mRJkn1xc8CS4EwNX03PY7c/i5QSNFftrd4kbRjFFq8/Y rCIopLBFy3/Fg2sEHjGtZNA1X5nA/YaW7rmI9VEJTD5xalNgmLPmsKbiKDa3AaYKW7pZ +ZLqXKuOtM0lDBlELY+vRzq611x2vEj1daE7LOVA36NxDr2JdAkv4J0iv5NllWF1qs9b +bqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si39485311edk.96.2021.11.09.16.22.39; Tue, 09 Nov 2021 16:23:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244878AbhKIVHX (ORCPT + 97 others); Tue, 9 Nov 2021 16:07:23 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:37585 "EHLO mail-pf1-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244853AbhKIVHV (ORCPT ); Tue, 9 Nov 2021 16:07:21 -0500 Received: by mail-pf1-f182.google.com with SMTP id y5so563779pfb.4; Tue, 09 Nov 2021 13:04:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E8Y2jyNg7h9soMk4rEm6rzTo1BjlaELOxyIkvTVeIKc=; b=qFzg41KmFXXKxf0e7AIwCA80Vj91V/b5yxTOjkUyLj5g3HujBNOJ7qrqd9N4Mwa/P6 Sfl4ATULDY2ywqS3ruJg80zTSHpWY+zb9UQJHt9dZcQYnLqvb0dXt2mclUIlsiLZQnaV vpBioGPkcymA/Ri3sCrAlRn2ZtIKOWZLVgqHuXnDtZ00y1DKMg72Uea8lMEFLivX/r8r skk6f/aqTmMGnO0XocjxfLvBrD26RTW9NVGyGIaXbx5VfqMHEQukO8CGEbBUeoprVB4B 6M8YuUDbHJK5Yc0SNtY0OQt/eMN8VvyubtqwmF3xoltLU/GBmcMOrJ2TjZLYqJvEYcgf UCXg== X-Gm-Message-State: AOAM530BGgMaRBQAP2cGf2AjT2BkjSOVO9gELRy1PUJFVIlumTA8KId7 /ajj9eER+M1Szon1rqPIXnQN+ZeMNAy0fTh2z6g= X-Received: by 2002:aa7:8883:0:b0:49f:f87a:95de with SMTP id z3-20020aa78883000000b0049ff87a95demr9062124pfe.53.1636491875224; Tue, 09 Nov 2021 13:04:35 -0800 (PST) MIME-Version: 1.0 References: <20211102161125.1144023-1-kernel@esmil.dk> <20211102161125.1144023-13-kernel@esmil.dk> In-Reply-To: From: Emil Renner Berthing Date: Tue, 9 Nov 2021 22:04:24 +0100 Message-ID: Subject: Re: [PATCH v3 12/16] pinctrl: starfive: Add pinctrl driver for StarFive SoCs To: Linus Walleij Cc: Andy Shevchenko , linux-riscv , devicetree , linux-clk , "open list:GPIO SUBSYSTEM" , "open list:SERIAL DRIVERS" , Palmer Dabbelt , Paul Walmsley , Rob Herring , Michael Turquette , Stephen Boyd , Thomas Gleixner , Marc Zyngier , Philipp Zabel , Greg Kroah-Hartman , Daniel Lezcano , Andy Shevchenko , Jiri Slaby , Maximilian Luz , Sagar Kadam , Drew Fustini , Geert Uytterhoeven , Michael Zhu , Fu Wei , Anup Patel , Atish Patra , Matteo Croce , Linux Kernel Mailing List , Huan Feng Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Nov 2021 at 21:29, Linus Walleij wrote: > On Tue, Nov 9, 2021 at 10:40 AM Emil Renner Berthing wrote: > > On Tue, 9 Nov 2021 at 10:34, Andy Shevchenko wrote: > > > > > The order the different states are blinked depends entirely on > > > > how the pinctrl framework parses the device tree. I still think it > > > > would be more natural to cleanly go to the end result without this > > > > blinking. > > > > Hmm.. but if going through the different states is what you want, then > > wouldn't you need the device tree to have an ordered list of the > > states rather than just a single node and also a way to tune how long > > time the different states are blinked? > > In a way you are correct that the DT is a functional language and it's > a bit lite a style sheet or prolog or something in that the end reduction > is what counts. > > In this case, I would say something is weird if there are interim states, > the yaml validation should not allow you to set the same thing back > and forth in your DTS file. Yes, exactly. > Alas we are not perfect as in yaml validation isn't perfect either. > I can't see what the problem is really, just write proper DTS files > and there will not be any interim states, right? No, I agree. I think it's only that Andy wasn't sure if these interim states might be meaningful/useful. > And if it is possible > to write DTS files that have states and sequence requirements, > these should be caught in validation. Should be. > > Yours, > Linus Walleij