Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Nov 2021 16:04:47 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Miroslav Benes <mbenes@suse.cz>,
        Julia Lawall <julia.lawall@inria.fr>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>, jeyu@kernel.org,
        ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
        kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, nathan@kernel.org,
        ndesaulniers@google.com, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        clang-built-linux@googlegroups.com
Subject: Re: [PATCH] module: Fix implicit type conversion
Message-ID: <YYsMn6HpYHyJZ8c9@bombadil.infradead.org>
References: <1635473169-1848729-1-git-send-email-jiasheng@iscas.ac.cn>
 <alpine.LSU.2.21.2111081925580.1710@pobox.suse.cz>
 <YYrghnBqTq5ZF2ZR@bombadil.infradead.org>
 <20211109212556.GX174703@worktop.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211109212556.GX174703@worktop.programming.kicks-ass.net>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Tue, Nov 09, 2021 at 10:25:56PM +0100, Peter Zijlstra wrote:
> On Tue, Nov 09, 2021 at 12:56:38PM -0800, Luis Chamberlain wrote:
> 
> > If we're going to do this we we must ask, is it really worth it and
> > moving forward then add a semantic patch rule which will pick up on
> > misuses.
> 
> Please, no!
> 
> This guy has been going around sending silly patches on his own, but the
> moment you add this script all the robots will join him, adding to the
> pile of useless crap we get to wade through each day.
> 
> I've yet to see one of these patches fix an actual problem.

Glad we were able to swat this fly fast.

  Luis