Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp656507pxh; Tue, 9 Nov 2021 16:58:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzajHTwVHqWV1LK1S1i4G6vi3FHucrr58XPzlHKM4qgGmi56cBemRgzwENCRHHKAPKfjS0j X-Received: by 2002:a05:6402:327:: with SMTP id q7mr16202034edw.126.1636505907845; Tue, 09 Nov 2021 16:58:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636505907; cv=none; d=google.com; s=arc-20160816; b=C9HMyAoYH9u6cN9l41/dr0l4j9na2XHVN6TK5IBcJlmX6Mt+PFA7nC5pDSH1fc2VMH wFs8fXAH+uZZdy/fWoDWJ/aX3SZND0CzwSy6Rwn1OpC4Yh30WMkSeeiXZtBu0zT0z1xf YtsZatfpH5UI9/UoaZyPgDiO04Dfujf/cHUU/iLosuwMLCOwwxHtz1Cncn+2PClZjmsX VHhDC4Skv81yklrTkohOy2fAF/EV6V1upSApGALz+H2uFoXeet8N/oSay5CKxpAyzM7P pM3eWw7SaVlsOTxt5kXCnFwQs6YW6W66yNF57jIVA+oOFp5mooHa6RHCkOmlvQ/fJS72 Yy6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=kf/FYN+gVGrcd1+PdmA4E4ZA2ZSxzGsOl4BVqKVilsQ=; b=sd5osuwahJpXVc8n1BHENjIn51RnOBb04mfCLo6LBQ1181SgdFqYwmepy90jgd4o5K ZjzK+Gj10PufJkgNU9OLZx8ZT/DWkEzhtbN0f0jBS7i/LAUFWVgnDtor59z5mwXHpO8t OpsEgc0XgAgg1IdkVQ3glTGaekbTkX6Hbs69HBGzKuyr+d9mJqlwRXuAs8g8g7XzVm2G A34QiEUFpH5iIHBlOcE9ntbJMVcDQG11AZsBN8CwYosjA4byQ4NapWhk+D7xpTt/r2yK 2/BVdatsrSFymUxZk9S5lXgkVgNEPtAdyHCbhs6BueZiBaZefWrevD328RwJPUOJdx4/ TZVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h19si32075014ejt.292.2021.11.09.16.58.03; Tue, 09 Nov 2021 16:58:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbhKJA5O (ORCPT + 99 others); Tue, 9 Nov 2021 19:57:14 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:41714 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229506AbhKJA5N (ORCPT ); Tue, 9 Nov 2021 19:57:13 -0500 Received: by mail-pf1-f174.google.com with SMTP id g19so1045608pfb.8; Tue, 09 Nov 2021 16:54:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kf/FYN+gVGrcd1+PdmA4E4ZA2ZSxzGsOl4BVqKVilsQ=; b=HB8pxVJCX7C+4jsbxsD1jjooFnm48mDJPn6ZMxIOx7ZTKQ+yqMWr65voG6iRN2jamt 9TRUnkOEALHkEvyXdJFv/G5yvNqclQp+UxwUpqcthM9GUPXR7agjp12q0xdfcNh/oHnZ 2pHI4vhY00BgNHkiXg9QRmcxBvHs0S8OkHbYtAbFwfejwdA4Zf/dYXQQturvLjMeFvW1 M/k09wyf5MNBpTT0ZUqLxeYI6zUXO1NpDyMm1VpMlpzGED2IkI926GfUDYk6N7b6p4Ul HjauKU4qzTSYA2M9hbO146enOBxq77RauyBSW7/dDBk6CBm0d0yHPht+cgDm5y97lINq 25/A== X-Gm-Message-State: AOAM532CRQvQgeFwCNLu3Y8X88Xt5ToBsyoYbcvdllgMRwSbZRkm/qh3 gDoDl/O2PPh+czLSnQnlJvg= X-Received: by 2002:a63:4a24:: with SMTP id x36mr7518498pga.67.1636505666927; Tue, 09 Nov 2021 16:54:26 -0800 (PST) Received: from bvanassche-linux.mtv.corp.google.com ([2620:15c:211:201:a582:6939:6a97:9cbf]) by smtp.gmail.com with ESMTPSA id l1sm16190987pgn.27.2021.11.09.16.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 16:54:26 -0800 (PST) Subject: Re: [PATCH] block: add __must_check for *add_disk*() callers To: Luis Chamberlain , axboe@kernel.dk, hare@suse.de, hch@infradead.org, jack@suse.cz, tj@kernel.org, ming.lei@redhat.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig References: <20211110002949.999380-1-mcgrof@kernel.org> From: Bart Van Assche Message-ID: <00619aeb-94c0-85a9-4c11-68dec0345188@acm.org> Date: Tue, 9 Nov 2021 16:54:24 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211110002949.999380-1-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/9/21 4:29 PM, Luis Chamberlain wrote: > Now that we have done a spring cleaning on all drivers and added > error checking / handling, let's keep it that way and ensure > no new drivers fail to stick with it. Reviewed-by: Bart Van Assche