Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211110022258.2358-1-chun-jie.chen@mediatek.com>
In-Reply-To: <20211110022258.2358-1-chun-jie.chen@mediatek.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Wed, 10 Nov 2021 14:59:37 +0800
Message-ID: <CAGXv+5G5vnOuW46q7b7m6BDS+R4vCLJehrofjfv95uOFbwyzEg@mail.gmail.com>
Subject: Re: [v1] clk: mediatek: use en_mask as a pure div_en_mask
To:     Chun-Jie Chen <chun-jie.chen@mediatek.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Nicolas Boichat <drinkcat@chromium.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
        srv_heupstream@mediatek.com,
        Project_Global_Chrome_Upstream_Group@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Wed, Nov 10, 2021 at 10:23 AM Chun-Jie Chen
<chun-jie.chen@mediatek.com> wrote:
>
> We no longer allow en_mask to be a combination of
> pll_en_bit and div_en_mask, so remove pll_en_bit(bit0)
> from en_mask to make en_mask a pure en_mask that only
> used for pll dividers.

AFAICT this looks like it continues the work done in commit 7cc4e1bbe300
("clk: mediatek: Fix asymmetrical PLL enable and disable control") and
commit f384c44754b7 ("clk: mediatek: Add configurable enable control to
mtk_pll_data").

It would be nice if you could mention this in your commit log to provide
more context.

> Signed-off-by: Chun-Jie Chen <chun-jie.chen@mediatek.com>
> ---
> This patch is based on v5.15-rc7 and [1].
>
> [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=546235
You can now base this patch on Linus's tree as the latest changes have
been merged already.

> ---
>  drivers/clk/mediatek/clk-mt2701.c |  8 ++++----
>  drivers/clk/mediatek/clk-mt2712.c | 30 +++++++++++++++---------------
>  drivers/clk/mediatek/clk-mt6765.c | 20 ++++++++++----------
>  drivers/clk/mediatek/clk-mt6779.c | 24 ++++++++++++------------
>  drivers/clk/mediatek/clk-mt6797.c | 20 ++++++++++----------
>  drivers/clk/mediatek/clk-mt7622.c | 18 +++++++++---------
>  drivers/clk/mediatek/clk-mt7629.c | 12 ++++++------
>  drivers/clk/mediatek/clk-mt8135.c | 20 ++++++++++----------
>  drivers/clk/mediatek/clk-mt8167.c | 16 ++++++++--------
>  drivers/clk/mediatek/clk-mt8173.c | 28 ++++++++++++++--------------
>  drivers/clk/mediatek/clk-mt8183.c | 22 +++++++++++-----------
>  drivers/clk/mediatek/clk-mt8516.c | 12 ++++++------
>  drivers/clk/mediatek/clk-pll.c    | 12 ++++--------
>  13 files changed, 119 insertions(+), 123 deletions(-)

Code-wise,

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>