Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp178291pxh; Tue, 9 Nov 2021 23:39:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnl5hjMq8Cgactcs8U8nRjuGsLp5rMIm9pYaj/vy5F0Aymfk4sm+bBDtbLNqa3aE+e64a1 X-Received: by 2002:a92:1304:: with SMTP id 4mr9971049ilt.119.1636529994719; Tue, 09 Nov 2021 23:39:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636529994; cv=none; d=google.com; s=arc-20160816; b=nfzXjTpnCFq+q642n9zTNL27PCe1608ifT9mhapKtqok+cfz6+e8GJ70j6/Ii9YkJA gEI2rGCY6pRcepdQFlnkyZ1fH5xccEARWLUWdrVf+/BCJeY9CjPqRZ2LMSuNSlVrfPGQ DcbrqeoKzM6ugo1naznHrPENsB7HE3bKp/+IlzcQrAohmZtuBX+9o90m+gao6MYIIelM lspb8zkDxY908pDs0R3fq0oW/T3BAtd8yljpfIM5/1IMZ2FQUeCue9Gko/3K29QAc8BV CBkBcV84qgBBvFzIXcC3ou/FkjCHDg6BMjQ60ISji1R4nh0EUb5OnCoudNDf3qGKCexV RymA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0Sl35YyP2vcKk8Xcy9vsgJAsaWV0tvjJ1YKLZctmqo0=; b=YkTL2HAoBpuoNZSRwm0eYwoKS4FdN9h7zhOKlhxUobJoFcaQjIyE77NiNLGf2dXHJH vRBFUYB6DSpQjeuULLSdVY7s6bpOiehP0Vr2Ptp3jS59BTwUcUrqiiqNW3HILezrtWnG pmG99/WCeRvvFEv3Vhu6oLg8hmd44x2MgYpF7k5r9OkF5i0E85liSdbqRZlF+AbhdhXZ D3noLfY5FmZwSYYxmtAn7fG2yoCvs2A3353eWeNa9lj3PM5fdBO8uL/H/C9CapHvWmRT nGqAd8GXiIQN4Yw6Q85GM2JlaWZ/i21yCsWU6Wemsd6vh+51tyz8qbzY2ca9CEHM8SvQ MpIQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XyRKsg8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e12si14166593jap.58.2021.11.09.23.39.18; Tue, 09 Nov 2021 23:39:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=XyRKsg8W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229699AbhKJHjM (ORCPT + 99 others); Wed, 10 Nov 2021 02:39:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbhKJHjL (ORCPT ); Wed, 10 Nov 2021 02:39:11 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65463C061764; Tue, 9 Nov 2021 23:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=0Sl35YyP2vcKk8Xcy9vsgJAsaWV0tvjJ1YKLZctmqo0=; b=XyRKsg8WgZtFBMshL9AhAPUzEH BMVFb12qPQsmu1PUcBgI1X7KKrfIJrpgtIp4gJtzKSkBTxwAs+5pG2pL1AyCTxYP/ucFxUa/RMwaf 8aN7VK6h2ySQK8cW/ZZ4WuHDjG1dkbxIswWf6ePVpnPdTgTOI3+ZexpN9DrfTgov5ie80MsA5Q72v 73JW3WkJp0azwRpGulITHrVBzOLS2xUXOYCzJhDmUhX3x78361sAnRQpC9TpD8ejm7fQJ0Usm68d9 tCTmu4wqnuQIi9pRnlmjiMO6XgmE2bEDxrLQXu04kZg5sIilQOz2bPrJe+l/G1U19CFjB8KmfUF9g wQaoziWw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mki9Z-004hAZ-Dk; Wed, 10 Nov 2021 07:36:17 +0000 Date: Tue, 9 Nov 2021 23:36:17 -0800 From: Christoph Hellwig To: Kishon Vijay Abraham I Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] PCI: keystone: Set DMA mask and coherent DMA mask Message-ID: References: <20211110073343.12396-1-kishon@ti.com> <20211110073343.12396-4-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211110073343.12396-4-kishon@ti.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 10, 2021 at 01:03:43PM +0530, Kishon Vijay Abraham I wrote: > + if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(48)) && > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32))) { There is no need to fall back to a smaller mask, the core DMA code just cares about the addressability of the device.