Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Nov 2021 10:43:46 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Hans de Goede <hdegoede@redhat.com>,
        Vadim Pasternak <vadimp@nvidia.com>
Cc:     Mark Gross <markgross@kernel.org>,
        Michael Shych <michaelsh@nvidia.com>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: [PATCH] platform/mellanox: mlxreg-lc: fix error code in
 mlxreg_lc_create_static_devices()
Message-ID: <20211110074346.GB5176@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.10.1 (2018-07-13)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U48myfLiBPtQQWL848WZjjlUDEQdripXFwPjUNsT/xFZppcILiRtVLT0jhvN?=
 =?us-ascii?Q?Ii//zOV5VQ0o/RAEOm7KHc5FsuJP4WrZakka+CIvcbU/SmwXZBeESBhe5xXc?=
 =?us-ascii?Q?kfHA9TsHsxMQThX5PI8bfvbSO35TBf3JYe9kzCLLoyAwfy7v09Zejwzy9Kuz?=
 =?us-ascii?Q?dwF9lo4OFSNzopj8zN6amDmo2hl4BWDQ74JGzv7cYeoHM/HUjg5SVP6vfMoW?=
 =?us-ascii?Q?fbJq0r3RbsAhCS8vpJO69spfeUEREkuobKDxjMfYyQDErLas58PXlXAA/BeF?=
 =?us-ascii?Q?ofmglRpJav2CoCiYohsf9/nmALzFLPcgE2665UgDq2OnW1fbp2NvPl++l9r0?=
 =?us-ascii?Q?XaYuhCccvU7t4OdgWXIiJSGJ6dRNxkxd4cPZpEtsgwnK9iLydiOcUpP2SUGF?=
 =?us-ascii?Q?s6PxcmNiwwrTU0oTarcYvFnQ3ZE6vE/MPtg3zsceFd97y/5FMYQ6XYUPfXPW?=
 =?us-ascii?Q?Qxj9uZGy3iahW3tCv4Yzy0DUMeGXQGPoy/CcVAX+Md3ZSVtsfnPJ6lo1kqsa?=
 =?us-ascii?Q?ch8sz0f8OIKT+QH/nStvEBCmYg7ioCsp5Hjdd/G84Ukx8u1vXE2GBmSouQ/H?=
 =?us-ascii?Q?rVqI3tg4hpjLPLSrXLslYuGoHV5cGLUO6jJqyzb8UoY2tiZGjaH6xiAJZpFU?=
 =?us-ascii?Q?nolTSu5rSNuYbuc2NKcPgFluYP7jweqs4Bz2OIk/cQcxNWiBBtqYL8ywO4nB?=
 =?us-ascii?Q?CGASH9LcSassPonfmDKAsY1oz0BM/7x5Of9gO7YGffdvVHpfuaVxspUXmUHI?=
 =?us-ascii?Q?rwUzFcfUa3kL6b60ozutt61NLTzRtHqZ1fT2l7qqBBGZeBSLFCn9s8G9ICpM?=
 =?us-ascii?Q?UMKqSGj+Z2LmRUK/v3CnTs6JoEgAqffa7kz8xgyRFQV9x+IdyeCECo0ZUErs?=
 =?us-ascii?Q?KLpPm6V8TqMvwSblNarl1AGKx7VgAqO3iTOQx49eG9qsF3N7ZBRtMyOw7SHc?=
 =?us-ascii?Q?gLS1wccB2XPYSMR5rqUOjfrTxGOoffc/E96ZzXvOIxEnH+EdtaUJI9kpG1V9?=
 =?us-ascii?Q?/B77JsB7sjSJTjkeRpcFQSaCt+8INdkKArzXTdLdlCQEwyi+QUhezA58LK4v?=
 =?us-ascii?Q?aXX6FQ/bEGNXsQXzVmYNzv0xXxUdVOPL51/jP+gWUYJRr6i2cRvHRGS4QVny?=
 =?us-ascii?Q?0pnBLY/yg+aoN/uIfRSRoM1Zar37q0JtVbk2u3Tg4PqSh0/nyFsP7DP7MB2F?=
 =?us-ascii?Q?8WVPmIbuAIX9BYYk3k4tphdu21qAJvdeC4EhmF9AfbLH08ajV9PSnhKGABP/?=
 =?us-ascii?Q?NBSvEOg1JwGr/+uRdinsjyZCQ94XvfL0tNmFUufTuyvD7B+ab8NAL6jfpadO?=
 =?us-ascii?Q?csvR5QyNb8jG8fte0RHnJXp8sAXoOHFRRaeT11m+4hgHiqNAhDewrUHyudMz?=
 =?us-ascii?Q?VnVTaWZUBTqeT/AoEhnRMIBn6ZeJxkqUwhyaHf9ItP9UXE1Ym9XsDu9a9dlK?=
 =?us-ascii?Q?1pgHhXIJzbBfU+Eeg0I1yz6sNWDebIs516OT+aw6bvWN+9JZxFuXger8z2l/?=
 =?us-ascii?Q?PjKsbGZekhw0bNPIjny2+IMY/yGe9VueauLPSoWTRGIKXv56Wd46BVXlbdqX?=
 =?us-ascii?Q?IRnA/655dx0KciVa2TWDBMrh8OkSshg3Qxw868tWY/qqKOEKJ+kmapBTL3Cf?=
 =?us-ascii?Q?wbofke44zcaYW082IRKMCD4faoNrlSrlAv1Gb7NJk0tOBJ/nHZZ3M5w34LMb?=
 =?us-ascii?Q?M1kqL/0q8lGAJntBwMNB8Y8/BBw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dde019ff-377c-4313-d29f-08d9a41ddb52
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 07:43:59.1370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PBOnrzTXYb8yXD2OTFW/10GuOFQogD/FIBlWeDVkMrmay5tv9wytZu2wJp2oj7D8uEkMBWFwpg79dWzhTs9lSyubRlmaC4k5yBbtlfGyGmw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4513
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10163 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111100040
X-Proofpoint-GUID: P1XUrGDsxWpcjhlTfQ7UyDktDP6u0pWt
X-Proofpoint-ORIG-GUID: P1XUrGDsxWpcjhlTfQ7UyDktDP6u0pWt
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This code should be using PTR_ERR() instead of IS_ERR().  And because
it's using the wrong "dev->client" pointer, the IS_ERR() check will be
false, meaning the function returns success.

Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/platform/mellanox/mlxreg-lc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/mellanox/mlxreg-lc.c b/drivers/platform/mellanox/mlxreg-lc.c
index 0b7f58feb701..c897a2f15840 100644
--- a/drivers/platform/mellanox/mlxreg-lc.c
+++ b/drivers/platform/mellanox/mlxreg-lc.c
@@ -413,7 +413,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl
 				int size)
 {
 	struct mlxreg_hotplug_device *dev = devs;
-	int i;
+	int i, ret;
 
 	/* Create static I2C device feeding by auxiliary or main power. */
 	for (i = 0; i < size; i++, dev++) {
@@ -423,6 +423,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl
 				dev->brdinfo->type, dev->nr, dev->brdinfo->addr);
 
 			dev->adapter = NULL;
+			ret = PTR_ERR(dev->client);
 			goto fail_create_static_devices;
 		}
 	}
@@ -435,7 +436,7 @@ mlxreg_lc_create_static_devices(struct mlxreg_lc *mlxreg_lc, struct mlxreg_hotpl
 		i2c_unregister_device(dev->client);
 		dev->client = NULL;
 	}
-	return IS_ERR(dev->client);
+	return ret;
 }
 
 static void
-- 
2.20.1