Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp211562pxh; Wed, 10 Nov 2021 00:21:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJz8FNAE7nOL7Nl32ab1WWVnD4WtrG+V46lhk8xxz7WCNf41CT6zFx347XC3TmsaQwgh/cB7 X-Received: by 2002:a05:6402:278e:: with SMTP id b14mr19019281ede.362.1636532506853; Wed, 10 Nov 2021 00:21:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636532506; cv=none; d=google.com; s=arc-20160816; b=ba8Yaiz5tuziUuTO/a/blM6zM4YQ9Haes+VBugdJWsRSku3Yaj2eWb8KsJNdxStP2v UpY9qVl51GkqKviTO7OtvF+u4CjNeE7Z1DIqrULcGrYNTqd76zY49vVEQ2/NKtmgI9Rx MCpTKbKfngT6uUSinmDvHYUzSIwhHd9xVKkpEtG1sPufKkuXw4lDbEnhZLXeEqP7Oixi PejecFRtDO2ngVYR3yhHHllqpnvHTA/TynQIkTdM5VPM0kKA/GmOnbpSS/1+PSVhwCu2 i2pj+ZbNsJwGwElzq6pCOovPsLiLoLBz7+0pw+tN7WtOwSA5jjEjzZtGNECB0ulgdyRr BMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:mime-version:date :dkim-signature:dkim-signature:message-id; bh=BN0MsiNbgeRKb+wkl1o9CWyi634gHXLRKnp+TwIJuMo=; b=XrYwpFPVyPUxIUgDlNnM/j/JabaRF1IZCoAEVDZTrD8syFu9xX27iY67+dDvBseSeM b7nXEAvVoODznbaYSvvnnqIeng/XeHzWbIrxYzGtmwQ0spweeoU1glLtA2cagfCkTZOz Ciz7oYg55JAdb6+M08A3SgRnnXoSGq7j6LRZNT5zKgaCwQDty35UPKys02Bp/BS+hAwV 7wAuKougWGNVhYQ4n+4Aw4lx1Nz9mPbTYFe7BjoqhHDsySbi5YaG87iOU32UrsFQxecO oWaI/Eomo5B4PW92SsdVqYHYxr1AsbW7p/8uTEhd4EWDBYL7i+NomthQzgC5RoxcbTPS F9YQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2jdebMqM; dkim=neutral (no key) header.i=@linutronix.de header.b=T5DrVa8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr12si28149619ejc.715.2021.11.10.00.21.22; Wed, 10 Nov 2021 00:21:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=2jdebMqM; dkim=neutral (no key) header.i=@linutronix.de header.b=T5DrVa8i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhKJIVy (ORCPT + 99 others); Wed, 10 Nov 2021 03:21:54 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:41408 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230136AbhKJIVx (ORCPT ); Wed, 10 Nov 2021 03:21:53 -0500 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1636532345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BN0MsiNbgeRKb+wkl1o9CWyi634gHXLRKnp+TwIJuMo=; b=2jdebMqMvjbryDpOrBpDXQUQiTiL/S+JXKDJMKO3RJSXmVPI76It05CXknKsVBf2Oy77jn Ymgsk64r+QZnCwiXlZ0I2lDZH5Wgsh0YnfF19Ro6TKOJkJ8SIisSVXgZ0BYDj0SerJBh/h nAFmOYN6PnXtpx6Bz/UmJHcyOQ/uvpn79MpVFPvVpQBmhhYPj2yuXbe2UHrm1i4I3zQ4H+ ZZUuwysRn+eFjGR/H3c0eKlJ/KYR5rUImOwycRZQC9TmtISKEi8GEp6Ow2zMxqk+mHr1Tm sRc7LMONau9rQQXXMHv4M8gE/yxly4utyFxY43GLIPIJUXzyOJJjgkq2VwSVDA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1636532345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BN0MsiNbgeRKb+wkl1o9CWyi634gHXLRKnp+TwIJuMo=; b=T5DrVa8i7km/keaSIh/JD0Zt7lo6ne8WiNRjMVgAoz6JJ0FrbPR34+ri4LBep3Jpqfg5oF 4zByVAA3oQK1OrAQ== Date: Wed, 10 Nov 2021 09:19:04 +0100 MIME-Version: 1.0 Subject: Re: [PATCH v2 1/7] net: dsa: b53: Add BroadSync HD register definitions Content-Language: en-US To: Florian Fainelli Cc: Richard Cochran , Kurt Kanzenbach , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , John Stultz , Thomas Gleixner , Stephen Boyd , Russell King , Marc Kleine-Budde , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot References: <20211109095013.27829-1-martin.kaistra@linutronix.de> <20211109095013.27829-2-martin.kaistra@linutronix.de> <6839c4e9-123d-227a-630d-fae8a2df6483@gmail.com> From: Martin Kaistra In-Reply-To: <6839c4e9-123d-227a-630d-fae8a2df6483@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 09.11.21 um 19:04 schrieb Florian Fainelli: > On 11/9/21 1:50 AM, Martin Kaistra wrote: >> From: Kurt Kanzenbach >> >> Add register definitions for the BroadSync HD features of >> BCM53128. These will be used to enable PTP support. >> >> Signed-off-by: Kurt Kanzenbach >> Signed-off-by: Martin Kaistra >> --- > > [snip] > >> +/************************************************************************* >> + * ARL Control Registers >> + *************************************************************************/ >> + >> +/* Multiport Control Register (16 bit) */ >> +#define B53_MPORT_CTRL 0x0e >> +#define MPORT_CTRL_DIS_FORWARD 0 >> +#define MPORT_CTRL_CMP_ETYPE 1 >> +#define MPORT_CTRL_CMP_ADDR 2 >> +#define MPORT_CTRL_CMP_ADDR_ETYPE 3 >> +#define MPORT_CTRL_SHIFT(x) ((x) << 1) >> +#define MPORT_CTRL_MASK 0x2 > > The mask should be 0x3 since this is a 2-bit wide field. > Correct, thanks. Currently, this mask is not used, as I am just writing MPORT0_TS_EN | (MPORT_CTRL_CMP_ETYPE << MPORT_CTRL_SHIFT(0)) to the register. Should I keep the definition anyway?