Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Hongxing Zhu <hongxing.zhu@nxp.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Topic: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Index: AQHXwllGUAnFZVoMdkqW8DriEOlDKqv8maNw
Date:   Wed, 10 Nov 2021 08:45:28 +0000
Message-ID: <DU0PR04MB94175710BE0DD8D08725B62888939@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ddHlcxvdTtYLrVp0bMuhhQFE6dmgpZGUGlrapeY++bR5SIaZ8lCBOL+wi/E0?=
 =?us-ascii?Q?qGUk4GCioYiSQpFhE0JSIlz/dnMnsBlgLoudUf9zfNHIOv4m3uB5/BC1Qkda?=
 =?us-ascii?Q?PBGYm83hp7pDVrF4K2zSRgC3LCMRccFkrnQvz8H2kPTV3QfoNuhBV1RNNM8T?=
 =?us-ascii?Q?fy7h/eI6jWfR6rBGRIZLdSJTG8+Q7MklNLAILR+GcNLGRv5Y5MxMLju0Q9PG?=
 =?us-ascii?Q?mRad+3s2xLBEVz1v8btwvv4Ymf/PEnDdBe58XL2bixR5+EKzKuMP1Lg1/VAk?=
 =?us-ascii?Q?LwVQ8UUzeskfy7fEX+d6Hp93PFVcw0lR0rzio2bDLhCYjWVPYNMCJY0sxHPV?=
 =?us-ascii?Q?PGyQP6Iu/S73Wi1gVbVeXMH7GNgegSjLny5sGtZDzip4BSGbput4Wy4ReslG?=
 =?us-ascii?Q?iJOlGbWxTHsRwtwDe7wyhe7HOP0MiK0cngz7D57F9osllB3ZoFUH3a7FSDL7?=
 =?us-ascii?Q?T8JPw2qACuA9aJ2dPPsHYFSsf/SuigZ9GXXxqR7+CXnSUcd7NIVpUy0zHAG+?=
 =?us-ascii?Q?SBBfo1zVrPiJRo3qtIG4uN4W5hp9qX1wX9DPDBgyVABEDh4LsBofb0YHPaEj?=
 =?us-ascii?Q?TeMKY16l4FaalIjKwjICJw6v1JL1Z7mqYdrdh+Q2/D/IhQB6OL3VxtLQE3Km?=
 =?us-ascii?Q?qtr3kXf3ZBHp7GaQogU/MfnOXrWybuHF1ASLGhHl1VY3XL81WTE+tohPXLJy?=
 =?us-ascii?Q?nbrKA55w9xPR3t9qeEfFeF9XlPYNPVgBP8cMfrSGtar99IzWUcQgSMN9R7k/?=
 =?us-ascii?Q?WQpVRrJDxBXtgV/uX8+tINSuiGpqw47LwDdEF3LEuCCFrqbZ8C8gkQwemk2m?=
 =?us-ascii?Q?17Gg6hLjBHNEdw64LS+VCJ9wkIxK5qf41aOyqIbIszhi6gaL4dp2DEhmVVMa?=
 =?us-ascii?Q?si71D7Oximv2GsELpwrKaNighjM2lAyB+YB7m9YjHFvSkpob7EH1CgWiJYD7?=
 =?us-ascii?Q?3EAWwRKAgUw+LAQGhchXskDcV9Cv5gjbxNpRW883u5e8RSJSSo8Tu59Ty7rW?=
 =?us-ascii?Q?TdPRwI0NZGLnslw9SsF5h01xmDWoNg7/8rYr92G/SZoQTa3ngBHfNDR5GPqZ?=
 =?us-ascii?Q?mCocOs39yoKPfSZdG5a6h6ZwRARd95v+nR4w4GiLTXCdMVQe/9QeV0rnw3IR?=
 =?us-ascii?Q?wzw0o9nZNMO0N/e7TdrxRsjFTFmK8ZbuY4iAr9VGhxHc/2f2q/96Is59JXAZ?=
 =?us-ascii?Q?Lok2o9LtfK59C03fhcWtcmPaQYspyCv2mD9qbZdoXS6JJjgTktAtY0k/XkgZ?=
 =?us-ascii?Q?BmA+ODp9v3VBouyX7jNBOo0MbegayWEBLsD/m6TEKX0zqwCC8IIjFZpBGF2y?=
 =?us-ascii?Q?a2qpwnCLcXtwqhuZfL96w+NEc8QrjnHa2ZxAMSVy3E8fGW7mNTVeenkPkjwW?=
 =?us-ascii?Q?yA6y+I61Evy3qlE3eGDvp7+SbOP+3QggVh4jlcdF4EnR3IPj+TcjeVYV0SvN?=
 =?us-ascii?Q?k4KXGlajzMjGrQSA609XoLOA5NHf6ecH8xirBXUwxbIpADYB8N5eQjVtsZPE?=
 =?us-ascii?Q?dEbd+dT/ov+h3elhWbCHpmauMsxM+FmpwpZO/aA+4ZJuhHwQW8Bqz+5zW5dh?=
 =?us-ascii?Q?ZP0oKk1SRAkBKjbUYOJ8700xDzLP3Q/KtmZJ4sddBn/KD6MUSDQouRIbJ6Wd?=
 =?us-ascii?Q?NosISz5QPHIbrSLgjTqnoOY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb11b5f-763d-4854-886c-08d9a4267263
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 08:45:28.3368
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 667km8hn6NUG7IgN93xvGLLi62FeWxVlQOYBt5jDPinfvKLNLYPfliyc9yFW+Ff8Ar6oz186tf6KfSxHwBHigg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9233
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
> function
>=20
> 'priv->workqueue' is destroyed in the error handling path of the probe bu=
t not
> in the remove function.
>=20
> Add the missing call to release some resources.
>=20
> Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>


Tested-by: Peng Fan <peng.fan@nxp.com>

> ---
> This patch is speculative. I'm not sure if the added function call is at =
the right
> place in the remove function.
> Review with care.
> ---
>  drivers/remoteproc/imx_rproc.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index ff8170dbbc3c..0a45bc0d3f73
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device
> *pdev)
>  	clk_disable_unprepare(priv->clk);
>  	rproc_del(rproc);
>  	imx_rproc_free_mbox(rproc);
> +	destroy_workqueue(priv->workqueue);
>  	rproc_free(rproc);
>=20
>  	return 0;
> --
> 2.30.2