Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>
CC:     "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Hongxing Zhu <hongxing.zhu@nxp.com>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Topic: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Index: AQHXwllGUAnFZVoMdkqW8DriEOlDKqvdwPEAgB7Y+qA=
Date:   Wed, 10 Nov 2021 08:53:21 +0000
Message-ID: <DU0PR04MB941768B7C12EA715D0BB553D88939@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr>
 <20211021174104.GA3562838@p14s>
In-Reply-To: <20211021174104.GA3562838@p14s>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zx8OpoVz9cpeXGgczGE4nl7HyW/p7BshlS0Wm4pojVcpCNHZSav+bpptcto5?=
 =?us-ascii?Q?e/u/QGK2RcHHzYNGl5I4nCwI41j1USII9rPx07Lvni8mslW4JPrSZ18CWqnw?=
 =?us-ascii?Q?d3Lna/28GuSAo74M82GN6jPIROG5XhMKppSrjR+gCSrRKa2xnJeNc7/8OQAY?=
 =?us-ascii?Q?9zxrl85ZYD7fgpnvZbhfYfbRm4i2wUkDfj6TAEFaJ/WhVE9bZNQF4f+Kx1nD?=
 =?us-ascii?Q?yfeWxcsFd5nrljZs4Izvu95eZjhAOBL3DfjJ+66cLvGJJYkjVPx+1INhd3Mb?=
 =?us-ascii?Q?FMvn7JjWxkkVOkVenmEgmWf5RxXs2CSCfIz4BCMbwuDdPpDZBSimsxw9Gbh5?=
 =?us-ascii?Q?6PHyjaECMSo3kvp5lrg+uczdF1YFf4R3FDwnGBiukMwk0ifuozEu8GzafT5k?=
 =?us-ascii?Q?7iiY1jn33UwdEAQ9dNPOknP1LWTpiSK836OkunTC+AtYK4y2EQ7GNN63MYEJ?=
 =?us-ascii?Q?K6rP8ZM4vOYxc2b3tdece4p4+jozgXxDqRxxPybBu25Eey41WWpdYCDHqLCo?=
 =?us-ascii?Q?xEo2fEoktosOvKryHRbnKFOJIVI1iR+dLM7IpOWihGGKI65FHLabyCE82Sxl?=
 =?us-ascii?Q?Ej8Evdvaiy8o3hZ3blHeJYIuZZU3K7jjUIaQ6wo87IuZhW+rjsv07FhHVHwh?=
 =?us-ascii?Q?YTAQu2VSeoqNAn07/am09MoklFZ17goXnNRswLUw7XKmHyjj727p8r4DQ1ya?=
 =?us-ascii?Q?iY4LmpkfWLMszoW0P7PG/8hYKu/MyhGr4Bus/0V7UGbX+gFtmyQQTW6t1KCF?=
 =?us-ascii?Q?KtIKHMXmZWwOPoCMoqOtPWR1EAUCc4YZQqISds9Xp46ZQPytcYLKIhT56/Qm?=
 =?us-ascii?Q?y/JfjR56wxhxZ0OUjMX7Lj+UFHsUdsRHLJzk4YgsEAR+0HVg4LwIsYUiguqF?=
 =?us-ascii?Q?c6/V8lLfAQ2dNGE88vRw562XHd6tDfLUD9aoZjf37HPKyg/tj6sxdmzlutQb?=
 =?us-ascii?Q?gagNnJT/ZVK3Yl+HqG7k188aA489hbfDiplUMHIjVJAVWdw5/OHYQLPNwDUe?=
 =?us-ascii?Q?IjbvyXK7Tzc3IZxgCD+jl+eqFFZeJI1TfJmhe5o4NdRBgG1EklAQu4c2EQ0j?=
 =?us-ascii?Q?N3JuXjXft9cQgnFBOpUMncvQGzAIcr8y8GTFPtS6mQFUR+ARFr6hwXg4dXcY?=
 =?us-ascii?Q?5CXD3PIm8g4VsISx8HvlWU+O+B0vUUqGjLSJ6AcIREKHzr28q9PnQzLeh5h7?=
 =?us-ascii?Q?AzhooWLKdjOr2xGYEGzNt4J6deAu7Y6pMBtGtoKwJGy7JDAiWgYEU8Iv6h11?=
 =?us-ascii?Q?RVjVDmEAR75C6wuW3ddVKrSiBOd+R+dKvIn45nGkwRc5cnWLv71UcMQV09/K?=
 =?us-ascii?Q?DhCO/yNbTqCsp7uGWUapC3GNmo5a4y48gQCBu99/PlJ0+/6P8STVdlJSrRtz?=
 =?us-ascii?Q?krl4MDoQo5TO8zQVC6RMmXihIH8sUoso/S1Lu0iIUqYlNqKGpMtMWq8syO0v?=
 =?us-ascii?Q?tdW1hrke3Pdp0EbeKwGcmb9TLqqoZn4sLpHylbm/20qM2j+UfsB7OPaxHT6U?=
 =?us-ascii?Q?/4kWYmRMZfFrwakYQiC5o4YQeBO15HtKyAUZGwxQAuUmXhw+JB/NQgxTv6KI?=
 =?us-ascii?Q?yrEIg6mIYU5xs2GAGfeWvK42OgOa4BlpuHyfUENP42t3NRWB1mN5sn6uwLP0?=
 =?us-ascii?Q?CmCG375VWvoIS829mjnA5LU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1929c75-d1c0-4c05-0408-08d9a4278c5b
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 08:53:21.4234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: XFtvViQbzlWHMio+Tci2oaedzYgvVsPyIXH2/ZSw6qMHR4n2Tu12+mmUJAzDexmpMVHEmE8o7Z2yviciBBjA3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8855
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: Re: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the
> remove function
>=20
> On Sat, Oct 16, 2021 at 08:44:28AM +0200, Christophe JAILLET wrote:
> > 'priv->workqueue' is destroyed in the error handling path of the probe
> > but not in the remove function.
> >
> > Add the missing call to release some resources.
> >
> > Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > This patch is speculative. I'm not sure if the added function call is
> > at the right place in the remove function.
> > Review with care.
> > ---
> >  drivers/remoteproc/imx_rproc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c
> > b/drivers/remoteproc/imx_rproc.c index ff8170dbbc3c..0a45bc0d3f73
> > 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device
> *pdev)
> >  	clk_disable_unprepare(priv->clk);
> >  	rproc_del(rproc);
> >  	imx_rproc_free_mbox(rproc);
> > +	destroy_workqueue(priv->workqueue);
>=20
> This seems to be the right thing to do. Peng - please review and test on =
your
> side.

Sorry for late reply, I built the driver as a module with this patch. And n=
o issue found.

THnaks,
Peng.

>=20
> Thanks,
> Mathieu
>=20
> >  	rproc_free(rproc);
> >
> >  	return 0;
> > --
> > 2.30.2
> >