Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        Hongxing Zhu <hongxing.zhu@nxp.com>
CC:     "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Topic: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
 function
Thread-Index: AQHXwllGUAnFZVoMdkqW8DriEOlDKqv8nCWw
Date:   Wed, 10 Nov 2021 08:54:07 +0000
Message-ID: <DU0PR04MB94173DCAA87A0B24E1C7073388939@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <d28ca94a4031bd7297d47c2164e18885a5a6ec19.1634366546.git.christophe.jaillet@wanadoo.fr>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JwKq05RSndWRDBSsR5u34sLzz456gBbDfkNgfQB/xCaMRyW09HE4mMHuV4uP?=
 =?us-ascii?Q?AtflUb/10JgV299DaCZFRQTsZL57mErCGqm9Y5MPdCrV+j9GMX+1RmTQJDJR?=
 =?us-ascii?Q?CoXrjh8nrVsXzY+MdNY0C4zrfWRQdJRAg4yd5T4GZet5fBxF93yVgo1yq51d?=
 =?us-ascii?Q?O6tKMF9baTdU4hEMQs/802CAs+tLZyK5WInPk8Avr21ZNxmUKqF+zMVtVQVQ?=
 =?us-ascii?Q?mtYJnmSV/Fng1jB/aepECiH1QlCcl581uBCTU4m3dnHc+E7t/q70HIIIexOo?=
 =?us-ascii?Q?dMXdclpN90NnFiZAXsz0h4y6YxP2QEli96v4PW6HZ4dqpDUBQPtKr29PcGpP?=
 =?us-ascii?Q?OJbERzeDhVVIrC+NvPGIEdcOTstbbMhlLm54H8GJzwlpuxH9dJEuj7w54MfV?=
 =?us-ascii?Q?Qu5YlouvB8IHTOEs0XdPdi0HZUiMnB4jfSvWsa/1L7k22UKLb2U2UsB+7KI5?=
 =?us-ascii?Q?XjZBPaxgN7Z6P64uJ+KaUYRSNwx6weFBnPEyPIRjjI54N8J2+ZixeFEGIq11?=
 =?us-ascii?Q?bS+Ki82nUjzPHtoqVrQaEdyJmJNLfhrTdoxPQijbDNg+CKLvKXkvjgrt3Bvj?=
 =?us-ascii?Q?jehTEstLZTm56zZnDjQmRHkzdQSpUuWZfmFvO35hyonQCPVcf6fmeo9nLe1Z?=
 =?us-ascii?Q?4YCHJhQbV0igT7kK2mLnkcaFGadF0/iX4dTS1I4pti93sNL7xWnA/o3Sla6a?=
 =?us-ascii?Q?8iTR/B0DlFNl70R/cfudM5tx5nj4c99HvI6fIx1jlmZmd/8e9bfnLVQLV9nj?=
 =?us-ascii?Q?BC8l9qK3iHndfSMi7Qq0z3o4vJtWmA7r5JGz83Nd4PFFMPUDqtar2o0qdMYJ?=
 =?us-ascii?Q?2F/9C23tprdhIup1D5I/i5cPH99T6Q3t07QtjzU003xm4DTO5dv+WhJnRNT8?=
 =?us-ascii?Q?2CNWIp4tleTlhfwonk3ZecD8aA2I1cKeDDAR3eBfcTWXEisA4wroFjegl2EW?=
 =?us-ascii?Q?sKGTpzKzAhuiLwtm2/E+IbkyvVrFflVXhgF/mUcb0ULOp1C/Sug4N+5ltbB7?=
 =?us-ascii?Q?6xhpVEqbEKb3XL0g2CyygzJrL5+kHWZxSibaUuXIdowxmaVPaBcjgUCvCTbJ?=
 =?us-ascii?Q?KyDUrJ0/R2T9WUgIfUZa1lce2wU6UhZsPFNV2Hm58aozsWyB/tOoGG73BBk8?=
 =?us-ascii?Q?t77elgn7lXbpce/Y9Tf5kCx5d0Acqv9UVz1LJ7+0sCqeqULjkYZBHWERUVNK?=
 =?us-ascii?Q?mJwjBYK91eq9PQB57nbS3aEXTBPOVauhQpbTGHYaS8aOLryiqIQmfL09vQ8A?=
 =?us-ascii?Q?zXlTfbPxoDI+4hOIQWRVqxQU+I9bRfQccT0Q8v5MKM2HkMw8M4gwEC7Z4M1V?=
 =?us-ascii?Q?bXSxHL6QbyjnznDe1YJUAcD4zDaQyHQ9IcwHY59AmgTED9lq3j5uv6avIsTy?=
 =?us-ascii?Q?cU/MvcIOdHU3Bqd7jU/2lOOWMNWAx66gWdk0ftHLzT/cV/jU2ZVdM82TgmeV?=
 =?us-ascii?Q?KJTfEZCZxm3XC0VxFLoQNVQHeokTeiDlvx3oGMBRaVtf7l0q27aRBW1+6tQN?=
 =?us-ascii?Q?U0wXMCABuqQgsi2ByiMzsfwyNMHbQMZcfSHdQ0RJSYsN+WLWSTxg5VYv1xTs?=
 =?us-ascii?Q?s0jjOESejdJ1nyAYcaoAPKXSiXwb/gFaCykc0ru/QfKYCDb2HJbntoi8qADR?=
 =?us-ascii?Q?sBLkFSoOINJ5ErlIBG7M9oU=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d357e0b-31e2-4a1b-e69d-08d9a427a816
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 08:54:07.9771
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6UTEEzzPCYnFvy7orr7PHjRIFMdjtumUuzwKcP5NL3FHHzXoVeqXWSBLtjLXwNH+/TyDnU3pYcg2+G5zIkNbLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9332
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Subject: [PATCH] remoteproc: imx_rproc: Fix a resource leak in the remove
> function
>=20
> 'priv->workqueue' is destroyed in the error handling path of the probe bu=
t not
> in the remove function.
>=20
> Add the missing call to release some resources.
>=20
> Fixes: 2df7062002d0 ("remoteproc: imx_proc: enable virtio/mailbox")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-and-Tested-by: Peng Fan <peng.fan@nxp.com>

> ---
> This patch is speculative. I'm not sure if the added function call is at =
the right
> place in the remove function.
> Review with care.
> ---
>  drivers/remoteproc/imx_rproc.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index ff8170dbbc3c..0a45bc0d3f73
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -804,6 +804,7 @@ static int imx_rproc_remove(struct platform_device
> *pdev)
>  	clk_disable_unprepare(priv->clk);
>  	rproc_del(rproc);
>  	imx_rproc_free_mbox(rproc);
> +	destroy_workqueue(priv->workqueue);
>  	rproc_free(rproc);
>=20
>  	return 0;
> --
> 2.30.2