Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp332661pxh; Wed, 10 Nov 2021 02:32:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyvLxSWfAix5sHjGYk2VF3AcKMkXBoz8epUTsw08rTdzOIqq9+edCAHHnBH3wgdghg6epIN X-Received: by 2002:a05:6602:2b83:: with SMTP id r3mr9757869iov.8.1636540350128; Wed, 10 Nov 2021 02:32:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636540350; cv=none; d=google.com; s=arc-20160816; b=joJ3m3hRxp9IL/tFGKsMSdDUnoZ2YbVaRhaeAJ7l49k8vBRKJp4DRwysOzipoLXt9q CGUUF2cMN3sOpE6Y1vuxWt4m+wheZ2SJTT/iHjTTCT8rtObhR8aSooeZ+4Z2RpRA77af wlZmCBPu2QflUVobAuGd+5OAOWs3KgFQRCSeygwcKytOhHPDqRx7Ts9MZ8Odr+D4y4De OXFXJHS8BzHSq+w/umKQVMnO6Ey7Hijity/CjnOkVc2RC4/BO60alKPLDYkNB0WSEXtG MkxDJPsvArRmyKiT0SZ6AFpYWX/oPVRwh6+/QpF3pCXfy9I/EWFLJbbysAUEMk3e78HB zRqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=/H97nPqB7O+Ha49bdQqeIeu5pMRHp/3DE9p9icaUgqM=; b=TNn2rgXxR+tuKh2ir94qv4dy83SahNFqgJhHfgtAmfL4eAIXzjqvyC039Mxhk98wpP chnJF4UNEhxQpX8KQllKRHL7oLvQNrPz2G4CSC2t8bL+cntP9ObxRVpXd7Cp+DKWOQc8 bdqKGHUO6JI17NiZUX7H9FTPNBZJcg1+/rIPlGnqv9Xkw+EdA5wTW7FbAFA+nCCURQTM LIYkijwSJElkE7PmjmHzjqQKQGmw3WZbnm7nXejz+uM2Dz+eiKi4/EB1gVdhRH1D2rpf g4DEItbBzOAHS7TCyupiF5LDliM+jLI9SboEpnZy6t3xzGnIRK8EEgwTXEUBngzxmwFT UVxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=PUuEyw9X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b6si13779203jat.81.2021.11.10.02.32.17; Wed, 10 Nov 2021 02:32:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=PUuEyw9X; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbhKJKdI (ORCPT + 99 others); Wed, 10 Nov 2021 05:33:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231239AbhKJKdF (ORCPT ); Wed, 10 Nov 2021 05:33:05 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D408C061764 for ; Wed, 10 Nov 2021 02:30:18 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id v20so2609213plo.7 for ; Wed, 10 Nov 2021 02:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/H97nPqB7O+Ha49bdQqeIeu5pMRHp/3DE9p9icaUgqM=; b=PUuEyw9XBots469I4b/mSNfuAjfpd7qQMzH59EqV6M8zrGuW5q/CfOy/XJM/r7hsaF ndro4ZRi2k2UFXbYR7Y2TD+wsPKHpZaqWMHSaQC5u0vRq/R4W4M75LnQ6wwHqTSRhgjA gNhSq0Dc8jWZWpqCIgVAsX8h+/O3mbrRqDeGIUv2lwZ2U3bRdIAyjPOH7bVnTrFrFM5/ FjN72YqxEMlv/SAj8JL4+P+sZFmb9ZhnqE0y/Dg5uFA/hcBKG1196tdQW2bAJXYHe/fz wZWqGkamOre8skZ1KLmAgmEvyTB8aiEzTVhVd5dmXMR4WSLYYi9i0jUTIq125egaczwZ gM+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/H97nPqB7O+Ha49bdQqeIeu5pMRHp/3DE9p9icaUgqM=; b=YuHw7nREDcIr02cPtU6COoPwISbh/ytmdZA0Bfy/zKKMBFZTdHp0ChJQuywXOYq0dW hEPXZqBS9m6ebgjrMnH5OBjbvS9TNZ8GFQP4TxUk4STFMhr7t/Yn+bWwmRTvkkJI1+0q MVSDoFEMPmOChRnrynVChlnJ8KIOwdsZKvwKGk/zjrEwdBbja5Ea+HHhBbxCCKvf26+f o7u3Fv//VUpXhrH6kQm6g+6c5MDzUdMqXhHRzsgmOjZZO2/p+UfsXfl2OpX3TTOQ/m23 V3pRNuu8/rrui5e621BhaOkbtdmj3FEiZRLc6vpm+l64itEtwXxOsTZFGbCV8zJzXWa1 Z1Pg== X-Gm-Message-State: AOAM530NdDf7A1M22ErUx2Ho1tgW7stVAa4e5RhwCxFwfV71GmaBhXA/ WEnRdM15bOG153j7foFPf0TNVHeM+oIMYh/M4wV5Pw== X-Received: by 2002:a17:90b:4ac1:: with SMTP id mh1mr15543616pjb.30.1636540217454; Wed, 10 Nov 2021 02:30:17 -0800 (PST) MIME-Version: 1.0 References: <20211109125030.26299-1-yunfei.dong@mediatek.com> <20211109125030.26299-5-yunfei.dong@mediatek.com> In-Reply-To: <20211109125030.26299-5-yunfei.dong@mediatek.com> From: Tzung-Bi Shih Date: Wed, 10 Nov 2021 18:30:06 +0800 Message-ID: Subject: Re: [PATCH v9, 04/19] media: mtk-vcodec: Build decoder pm file as module To: Yunfei Dong Cc: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Dafna Hirschfeld , Benjamin Gaignard , Daniel Vetter , dri-devel , Irui Wang , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2021 at 08:50:15PM +0800, Yunfei Dong wrote: > Need to build decoder pm file as module for main device > and subdev use the same pm interface. Why does it need to be a module? Could you provide more explanation in the commit message? For example, any compile errors under some circumstances?