Received: by 2002:a05:6a10:8395:0:0:0:0 with SMTP id n21csp426509pxh; Wed, 10 Nov 2021 04:05:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJzU7A0DDQgK1Ia2eowuRJnDdKNx71w1GjMnGtE6id27dRkbN+X2Il/SV2yJhTvIu6g3GzhY X-Received: by 2002:a17:902:ab47:b0:141:95b2:7eaf with SMTP id ij7-20020a170902ab4700b0014195b27eafmr14967225plb.40.1636545912508; Wed, 10 Nov 2021 04:05:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1636545912; cv=none; d=google.com; s=arc-20160816; b=KVSLya+sRB3BDAjesAICoWx+8xWozqZWRVVQTG4Bs96Y6KJTLyUxiugpk2+rrlppHI S346Ls+pkb9ZABpq7hwcMzFQChHgLZoO0xvlMFNd73dELaMjiEdzCrN2gTZokYnLzUaa kuzRzJ4BwmACb2SKeczEgNIH2izGu7zdsO2xTVWr7C2raPudG0KEQmLs1hl7cSbjPIsd n4npDBDtLUmgo2IU2XZCDtctwErlTKbignjSJ1pVIGjPoiCKCMciQXpeIrEgPQXuq5CT mazY2c3v7BTShvjDpetZdCUkTMeKz5v3dNK8yUvd70cvJ5xgn7JVP5izxrn7iS7nsHKL z0AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Fi5LEJC966P67PNBIIhbeHLSWiolc3NsYfar0dw8aGU=; b=jnnv5hGhqyhDwysvYS7QUJmMf1PZPC6BzupW8EeKOayUzJOxwChxn9DGe48+R6qqol mbKJZ5XEdLC4K6+BhodCOUGldk0pYAqOdhVJokYOIcqVqjZzvlQ1D24CQf1jp9UM7Bkn o4bio1ZQHOn2cgjXHUE/gcBQxx4OF0sZLRyIOLNcoIDwDwPbNavfT24oSS72AK0NuVi9 jEmQuHg46oDTTqflIfOwrRBR+QPp9PWuNa8s15o+lTXjMxidTkEyLVRKW6HRZMvOYwIA sR/GpC7+uQoAm0N1ZKqqJHCB3uvZ8TCdEih+soR9LFdKo6V/goDmJwgZzSZbKHCRPREa TvyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VQ0x8tHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pc11si12088511pjb.182.2021.11.10.04.04.54; Wed, 10 Nov 2021 04:05:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=VQ0x8tHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231566AbhKJMDx (ORCPT + 99 others); Wed, 10 Nov 2021 07:03:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbhKJMDm (ORCPT ); Wed, 10 Nov 2021 07:03:42 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24FD6C061764 for ; Wed, 10 Nov 2021 04:00:55 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id gb13-20020a17090b060d00b001a674e2c4a8so1481546pjb.4 for ; Wed, 10 Nov 2021 04:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fi5LEJC966P67PNBIIhbeHLSWiolc3NsYfar0dw8aGU=; b=VQ0x8tHmk+flLo5jDFR+07CbiunePcpbPiPbMUklELvXanCuFy2BIbRfBl4oIwLdtG 8kCotOAHlospEPqoDnI9iJveVLAKW7tBAxP5+/ISew+WgWLEcWwOpzjmFksENSlGOUOz ZVLyGniGbjUrb0jQ1jvSuvr8F8DDynGPAGfxcAEmlJExk3UGh8Qt8Xuz0qdpBPF91akq oBljgEYjw4FVjjljTqoZZ+mUleeQ6QN6fWiOzHkHyKU4YfMYG4ZGc+LJQkBrwddKFibU UYlpsAVV26uGB9ZDCI2c4NfdciLq2uJzd+PnIHA6UUYYzu2RGepAYDtntFdRVa7icLN7 yovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fi5LEJC966P67PNBIIhbeHLSWiolc3NsYfar0dw8aGU=; b=07FkJ/ZvNYHV7XJL8+lEaW191wly6fM3Cop2gIvcTuMB+a0futD4Too/+PGtR8/afo L0CfsbBHwNedFj+hcRkybFGAoDmi5XEXL5auufC4VJ4yos20ZzHFy40ELQPno4qr//tm u3kYlLtU9XQ/lIhVDgfGfMC2ZtgltgmmRHG6wBFrl3VZcdZm4FsuIU0rVlo/ijrNCksd oB/aP93lONCY3BS2hpPTLV3RQniNVNolfjxEWOBFU1bBDaBQLrEXPtuPh41VGjWxxcTF /My7Wss2l+5+LdB6E20j2Lp00UCf371x8LV/o2LNCGbblUVihLp4n5UH/qFyTZMHWzxi 2qqQ== X-Gm-Message-State: AOAM530+b2uSYPyvTWMSd0PhPJaUm/WJWCYTds74bozYlI5cRxkHdcxj bs/zrZqiTgOp/PiHFK0onTP2vewWtv8= X-Received: by 2002:a17:90a:d192:: with SMTP id fu18mr16639553pjb.177.1636545654494; Wed, 10 Nov 2021 04:00:54 -0800 (PST) Received: from localhost ([198.11.178.15]) by smtp.gmail.com with ESMTPSA id f16sm12321061pgi.28.2021.11.10.04.00.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Nov 2021 04:00:54 -0800 (PST) From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: x86@kernel.org, Lai Jiangshan , Peter Zijlstra , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH V5 33/50] x86/entry: Add the C version ist_restore_cr3() Date: Wed, 10 Nov 2021 19:57:19 +0800 Message-Id: <20211110115736.3776-34-jiangshanlai@gmail.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20211110115736.3776-1-jiangshanlai@gmail.com> References: <20211110115736.3776-1-jiangshanlai@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lai Jiangshan It implements the C version of RESTORE_CR3(). Not functional difference intended except the ASM code uses bit test and clear operations while the C version uses mask check and 'AND' operations. The resulted asm code of both versions are very similar. Cc: Peter Zijlstra Signed-off-by: Lai Jiangshan --- arch/x86/entry/entry64.c | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/arch/x86/entry/entry64.c b/arch/x86/entry/entry64.c index 283bd685a275..5f47221d8935 100644 --- a/arch/x86/entry/entry64.c +++ b/arch/x86/entry/entry64.c @@ -11,6 +11,7 @@ * environments that the GS base is user controlled value, or the CR3 * is PTI user CR3 or both. */ +#include #include extern unsigned char asm_load_gs_index_gs_change[]; @@ -30,6 +31,26 @@ static __always_inline void pti_switch_to_kernel_cr3(unsigned long user_cr3) native_write_cr3(cr3); } +static __always_inline void pti_switch_to_user_cr3(unsigned long user_cr3) +{ +#define KERN_PCID_MASK (CR3_PCID_MASK & ~PTI_USER_PCID_MASK) + + if (static_cpu_has(X86_FEATURE_PCID)) { + int pcid = user_cr3 & KERN_PCID_MASK; + unsigned short pcid_mask = 1ull << pcid; + + /* + * Check if there's a pending flush for the user ASID we're + * about to set. + */ + if (!(this_cpu_read(cpu_tlbstate.user_pcid_flush_mask) & pcid_mask)) + user_cr3 |= X86_CR3_PCID_NOFLUSH; + else + this_cpu_and(cpu_tlbstate.user_pcid_flush_mask, ~pcid_mask); + } + native_write_cr3(user_cr3); +} + static __always_inline void switch_to_kernel_cr3(void) { if (static_cpu_has(X86_FEATURE_PTI)) @@ -49,9 +70,20 @@ static __always_inline unsigned long ist_switch_to_kernel_cr3(void) return cr3; } + +static __always_inline void ist_restore_cr3(unsigned long cr3) +{ + if (!static_cpu_has(X86_FEATURE_PTI)) + return; + + /* No need to restore when @cr3 is kernel CR3. */ + if (cr3 & PTI_USER_PGTABLE_MASK) + pti_switch_to_user_cr3(cr3); +} #else static __always_inline void switch_to_kernel_cr3(void) {} static __always_inline unsigned long ist_switch_to_kernel_cr3(void) { return 0; } +static __always_inline void ist_restore_cr3(unsigned long cr3) {} #endif /* -- 2.19.1.6.gb485710b