Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Michael Olbrich <m.olbrich@pengutronix.de>,
        Holger Assmann <h.assmann@pengutronix.de>
CC:     Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
        Holger Assmann <h.assmann@pengutronix.de>,
        Yannick Vignon <yannick.vignon@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        Jose Abreu <joabreu@synopsys.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [Linux-stm32] [PATCH net] net: stmmac: allow a tc-taprio
 base-time of zero
Thread-Topic: [Linux-stm32] [PATCH net] net: stmmac: allow a tc-taprio
 base-time of zero
Thread-Index: AQHX1N9HLp/45dXZAUyXM5qWRykZXav6262AgAAlfgCAAD6yAIAAAPeAgAF1OIA=
Date:   Wed, 10 Nov 2021 12:38:43 +0000
Message-ID: <20211110123843.3u4jo3xe7plows6r@skbuf>
References: <20211108202854.1740995-1-vladimir.oltean@nxp.com>
 <87bl2t3fkq.fsf@kurt> <20211109103504.ahl2djymnevsbhoj@skbuf>
 <6bf6db8b-4717-71fe-b6de-9f6e12202dad@pengutronix.de>
 <20211109142255.5ohhfyin7hsffmlk@skbuf>
In-Reply-To: <20211109142255.5ohhfyin7hsffmlk@skbuf>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pnqwgwMg/WXFu4GiYHfjCYfYYWYHZuvL8VNRpdoLWeli1nfYzhWy57LZgebK?=
 =?us-ascii?Q?8DxarNsldyvOn5L8HpDsiKwW8q5auyEe9yjMWPlImbzkN4UQYG1YeV3hpjnf?=
 =?us-ascii?Q?etlbnwmsN8CmItRW4It893Eb24EDL5OhdkBC9yvaDkbrxoLgTxf+Q3/LtHxt?=
 =?us-ascii?Q?UfsvORuUGLPzuo4R1LhohvfOypOVpFpRy5Fk9JyxZ1aPsVwz4FCCAScddHXw?=
 =?us-ascii?Q?E13J+JoZfsvqoq89PC0sYVTPXVYjofANSf5rhC5WaAn5nDju4SS2qUo20es4?=
 =?us-ascii?Q?PVplOdfhHRml9bY76lEnWJ3sTYkaHQwi7i3SFblLLpy5wNvY6U7/z1wUGwXA?=
 =?us-ascii?Q?qk2gXpns1ywX7929WGUpHj68gSuvgJEbmPykYVmq4a6E3yWRytzJVl5R8QWC?=
 =?us-ascii?Q?7LmLVS2ajv+kX0iLxizGn0ojVyM7NWSN367iVrJyWd1sCNaGNj158/nPkx4d?=
 =?us-ascii?Q?+4+HXSCskdKSKF2K7Q65eg7wwqcNODno9tn719zfZrJ89R6wU61M+TJo2CJE?=
 =?us-ascii?Q?MQD+u6ftFwsj/rtLWfr864WARru/uxbKkmmXpbgcUefSM4+8bRhcp2LXHg6e?=
 =?us-ascii?Q?hztt4wbxdP/XmBJMQ597/WhVs4JhQL3YYbmLy2OFWN8K+aP6e7XqwXJrQrx4?=
 =?us-ascii?Q?BUk5dzuDVVQbN1i5IzIHUngjULfmh5u9GO2r+hKqkiZMjr+SVB6tTgg5O4DF?=
 =?us-ascii?Q?agoDOkWTCycrZJxK1l0pyQMVeWLYFnbAsfJxxOSiUk8UNiDetZlp7OufyCbz?=
 =?us-ascii?Q?hA9FOeR0CkEsOSzNzy+BGP8uiC8N2ugbfU5LqHzTn3wYIu9a05g5fjPl1wMC?=
 =?us-ascii?Q?IWJqtvyfcBRJliJkSeQ5nhIB/QUmazX/Cs4qBSUFx5FxKHRwZevop4yDuzrw?=
 =?us-ascii?Q?btwCSvCII0I/IdmVHXMOicdnBoUhQ8SB358kQj5oaDB+Go24P8kFKt3EO15J?=
 =?us-ascii?Q?jzwGVkAZLLl8UOsHtI0YHE2dzN6uUTQs8tyUHNkvKjvXcZbZ3NByCQMCeaft?=
 =?us-ascii?Q?QPuKGm0nf7K9SZXOP35C9eTB4on/OU3k8PLIPRPSpGl/op17TMs7w0wGSCiZ?=
 =?us-ascii?Q?e41Ir9WImLRjR7SbEG/riOepu2ueunUSQmcv7UurrZAlWmMIudLqKNbcWOfy?=
 =?us-ascii?Q?duUg4DlO4Bqx1gRfoJrs0R1OXETceX3O/L34ONyc3CrqPw6nbsvCXG99OfrR?=
 =?us-ascii?Q?G1l+HSVGutiLAzTK5nzrNWyyMqwXM+e374wqXP9P0wmqYMrDvBshY68gHPEP?=
 =?us-ascii?Q?NlEXSxDR5ENBSWZuTErjyPiaP56KetatoN7LzP4Dgqsvb/lrlXEorNIBA72Y?=
 =?us-ascii?Q?1SbnmqHndD7+OOFkK1dLfsuO3FFNOL7Yqanl5gf08Wbck4ywPjN1JFp81rXz?=
 =?us-ascii?Q?4pMWxiWktdhiyIKQPTBMREhT5TWgBZh5TVx9gJH/WmnV8ELa2D5MO31v8mIf?=
 =?us-ascii?Q?9l0ix+T42YY7p1ty3nyf6m/FByOAJG1KQWuz8UDCYHyNkOFc5VqyA9QVsMIk?=
 =?us-ascii?Q?0F1HS2YRkytn28wM56wlw2fVQoh882prxe6MYS11gD4O53GsdaSlb7ZmwPsh?=
 =?us-ascii?Q?yBKLn0s+EUm0l3RvjAZdVkh61mDsXaX1SlbCl0Y8iFJp3Y1wgI59vFZjC85w?=
 =?us-ascii?Q?vo4T4o/iXEVlw30J49ZJTuY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A81652E6B8EE054D99F851AD69956E1A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9474c9b-0ffe-4663-8eed-08d9a447086d
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 12:38:43.9887
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: huAkNNQ5V1YP8MSJzxhvC2d5nO+beXNB4DpzhPpou/RGIBuf0cVF46CPr+zxTH3XrH8oD0/UJCxpgkHGVY3/gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 09, 2021 at 04:22:55PM +0200, Vladimir Oltean wrote:
> On Tue, Nov 09, 2021 at 03:19:28PM +0100, Ahmad Fatoum wrote:
> > Hello Vladimir, Kurt,
> >=20
> > On 09.11.21 11:35, Vladimir Oltean wrote:
> > > On Tue, Nov 09, 2021 at 09:20:53AM +0100, Kurt Kanzenbach wrote:
> > >> Hi Vladimir,
> > >>
> > >> On Mon Nov 08 2021, Vladimir Oltean wrote:
> > >>> Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
> > >>> base_time is in the past") allowed some base time values in the pas=
t,
> > >>> but apparently not all, the base-time value of 0 (Jan 1st 1970) is =
still
> > >>> explicitly denied by the driver.
> > >>>
> > >>> Remove the bogus check.
> > >>>
> > >>> Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO schedu=
ler API")
> > >>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> > >>
> > >> I've experienced the same problem and wanted to send a patch for
> > >> it. Thanks!
> > >>
> > >> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
> > >=20
> > > Cool. So you had that patch queued up? What other stmmac patches do y=
ou
> > > have queued up? :) Do you have a fix for the driver setting the PTP t=
ime
> > > every time when SIOCSHWTSTAMP is called? This breaks the UTC-to-TAI
> > > offset established by phc2sys and it takes a few seconds to readjust,
> > > which is very annoying.
> >=20
> > Sounds like the same issue in:
> > https://lore.kernel.org/netdev/20201216113239.2980816-1-h.assmann@pengu=
tronix.de/
> >=20
> > Cheers,
> > Ahmad
>=20
> Indeed. Was there a v2 to that?

FWIW I've applied that patch and made a few fixups according to my
liking, and it works fine. I can resend it myself if there aren't any
volunteers from Pengutronix.=