Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Nov 2021 08:59:36 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     akpm@linux-foundation.org, tglx@linutronix.de,
        kirill.shutemov@linux.intel.com, mika.penttila@nextfour.com,
        david@redhat.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        songmuchun@bytedance.com, zhouchengming@bytedance.com
Subject: Re: [PATCH v3 02/15] mm: introduce is_huge_pmd() helper
Message-ID: <20211110125936.GR1740502@nvidia.com>
References: <20211110084057.27676-1-zhengqi.arch@bytedance.com>
 <20211110084057.27676-3-zhengqi.arch@bytedance.com>
 <20211110122945.GO1740502@nvidia.com>
 <18fa08bf-847b-1c47-10ee-01c92caeb0cc@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <18fa08bf-847b-1c47-10ee-01c92caeb0cc@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IL6Q/9Xxzu6xvXktHLkJRuCfPDlARdK72x5D/yx0HgLc09ZkcOFo5GA7AgFd?=
 =?us-ascii?Q?52AnPFR93jDDEYMnAJru3cJ2dsxrDcEKg36GUspf97EmJLVHduT2KA/gryuP?=
 =?us-ascii?Q?uFtHaQHI8MOs5OnuZqS0m+AvFzFfTJkbeuvs1lZWDfsJlTbXItWxme4jFgKg?=
 =?us-ascii?Q?WE0CLj5F60sWvPosoZti3zTrWoXJkwhop3UM/KE0nLdw33oZ5mCL41XRgPRi?=
 =?us-ascii?Q?8DQMnG/pWnJDBdpn1RzX4PDjCwxSPph1hkPQe1tNj4siRMNaRqHMo3ZrylWs?=
 =?us-ascii?Q?4NUGHuwHSRlJ+mEmKrIuJVxYTqVX1HhxvTojaOuqdhucLlFlPTo6j3gwnmo1?=
 =?us-ascii?Q?kPPUCsVxCdaEZdMOhaGSubG0qbi+CSCDBpEKuHVfJ/mAk4OP82DK138H8mNO?=
 =?us-ascii?Q?MorWsc/vJdZ9Hfyu1pOHnw+45HVRXDuXOOBJYgrDrDczaKDB5Yu6jFVY6cvZ?=
 =?us-ascii?Q?TQFmw77c38/9t1z3sLl3vvWu3R5zPjHeDsij/tabvf4c/qj9QYl38Icyd6Kj?=
 =?us-ascii?Q?VRgS23LcPtT9zXz1PBRvQIq4Lq/cDinE+yfTTN4IYiz+K3pVFoP9LVQpRXNJ?=
 =?us-ascii?Q?K7KfoIhI9nyVI6UAcymxRbD9lLWrtSrnGf3UzSD3vaBkfsGw4AOc7ebG4FRK?=
 =?us-ascii?Q?NTfKwTPSzuAE0bUhooYPnRvnlKwxsUGeIGiI7JhiVocQprwOH3AKyPGP9aRR?=
 =?us-ascii?Q?B8EJOA8xqL5clB86WKTREZXIf/QZD/gNx7N7vpDpDEM04UHdSpb290/voHrZ?=
 =?us-ascii?Q?CR0RBCL2rs9WGQa5OxEbyc3phF+CJTQYw05nEayiTyAKu+kCf3wUuX74R4gl?=
 =?us-ascii?Q?Ds9ngXbLrkk8zxbZBe6vgIcRoj15bsWgCKsti8mxXTpTV2TROKOzbQJDAs/Y?=
 =?us-ascii?Q?IcmGO1khhXVVYiVWV8ygzDsBux/0gT4qvqLtrG0voBIp4lN2tlWGt/wyWX3p?=
 =?us-ascii?Q?R7wsdCaDkBHMZTUXV3N4frf9nyDbg+A2t8qEqpV7lKLksk1H4W1zpmIQdBcu?=
 =?us-ascii?Q?K+M0IjjjWtG51sq/t3mwPoSPjXPR5/HXyxY3DcFnA1sXzVwvgoSI1k96eKWf?=
 =?us-ascii?Q?63/g1tBr0YbLFgRG3ozWNC8cbrECwQQHmdUSxk0UOqChF8eD/cOkp0KIPTrT?=
 =?us-ascii?Q?UsjdHuRsksf7i4+zRdyM5OhUWeyqkHQCsjxZ8FIZnkiTbXZr3f6/zp3KKb//?=
 =?us-ascii?Q?zaSmCuO7DRCQ83lLbYiSBR5DQ3NcSSRcvALXO7IFAxIkHt714qGytc4kv8ZX?=
 =?us-ascii?Q?T+I5zA880xwUQ5tofhxVFoXiObztOWWdZhuyTvPSgTfjojJxB+HsX0bvo1X7?=
 =?us-ascii?Q?9ePgeVXSmZDZVx2BkyokPCyrgq/OeZw7ocDoDqm7zIw52FcbDcLXgqyTtTC+?=
 =?us-ascii?Q?AOXohBYy6fkNZpLYvYMdSI8i8Y9yzjR5cujLC2znCoNMOSZfVg+iSQQqDH8D?=
 =?us-ascii?Q?VkSF4+/Qjc0s/hoZYVdx7Qf7CJzYdQqEl5Z3D6AgtLiQ2SkXfkJbXO3xfn/2?=
 =?us-ascii?Q?Ou83GU7T2jww1mX3mw12KLMab6bK5lJXf+LTdVJGTUF3/1JvjH+cGJhOI+JR?=
 =?us-ascii?Q?A3ru7/rNIEs4scTS1io=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18d8e16f-af4b-44e8-ef38-08d9a449f3be
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 12:59:37.9386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rj50IIDm23VhCp73G8MVsYkSRQZHCHvdjfPRofC6Wkn0tLI8yjwDAilIWedzjEWD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5192
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 10, 2021 at 08:58:35PM +0800, Qi Zheng wrote:
> 
> On 11/10/21 8:29 PM, Jason Gunthorpe wrote:
> > On Wed, Nov 10, 2021 at 04:40:44PM +0800, Qi Zheng wrote:
> > > Currently we have some times the following judgments repeated in the
> > > code:
> > > 
> > > 	is_swap_pmd(*pmd) || pmd_trans_huge(*pmd) || pmd_devmap(*pmd)
> > > 
> > > which is to determine whether the *pmd is a huge pmd, so introduce
> > > is_huge_pmd() helper to deduplicate them.
> > 
> > Isn't this pmd_leaf() ?
> 
> Currently, the implementation of pmd_leaf() does not include
> pmd_devmap() checks. 

Are you sure? I thought x86 did via the tricky bit checks?

> But considering the semantics of pmd_leaf(), the "devmap" pmd should
> also belong to "leaf" pmd. Maybe we should modify pmd_leaf() to make
> it more semantically consistent?

I would prefer that..

Jason