Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Nov 2021 16:19:33 +0100
From:   Heiko Carstens <hca@linux.ibm.com>
To:     Stefan Haberland <sth@linux.ibm.com>
Cc:     Qing Wang <wangqing@vivo.com>,
        Jan Hoeppner <hoeppner@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390: replace snprintf in show functions with sysfs_emit
Message-ID: <YYvjBWx1vgdsktJ1@osiris>
References: <1634280655-4908-1-git-send-email-wangqing@vivo.com>
 <1955ef45-d30f-5354-e514-2bc8f7d9cfb6@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1955ef45-d30f-5354-e514-2bc8f7d9cfb6@linux.ibm.com>
Precedence: bulk

On Wed, Oct 20, 2021 at 04:44:01PM +0200, Stefan Haberland wrote:
> Am 15.10.21 um 08:50 schrieb Qing Wang:
> > show() must not use snprintf() when formatting the value to be
> > returned to user space.
> > 
> > Fix the coccicheck warnings:
> > WARNING: use scnprintf or sprintf.
> > 
> > Use sysfs_emit instead of scnprintf or sprintf makes more sense.
> > 
> > Signed-off-by: Qing Wang <wangqing@vivo.com>
> > ---
> >   drivers/s390/block/dasd_devmap.c | 74 ++++++++++++++++++++--------------------
> > 
> 
> Thanks for the DASD changes. While I am totally fine with the change itself
> I agree with Joe's remark.
> Would you like to improve your patch? Otherwise I can add a small follow on
> patch. Just let me know.

I translated this to Acked-by. Please provide an addon patch if you
want to have this changed.
Applied, thanks!