Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ASoC: SOF: build compression interface into snd_sof.ko
To:     Arnd Bergmann <arnd@kernel.org>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Colin Ian King <colin.king@canonical.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Bud Liviu-Alexandru <budliviu@gmail.com>,
        Paul Olaru <paul.olaru@oss.nxp.com>,
        sound-open-firmware@alsa-project.org, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
References: <20211108111132.3800548-1-arnd@kernel.org>
From:   Daniel Baluta <daniel.baluta@nxp.com>
Message-ID: <dd1031ba-5867-1392-4fe7-b09ac0d71fa0@nxp.com>
Date:   Wed, 10 Nov 2021 17:27:26 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20211108111132.3800548-1-arnd@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEdDbWQvUVRFRGtvV1VFUXJYSllLTFVtVXVZOFJ3c2NUbS9xTSt0QWRZRTIw?=
 =?utf-8?B?MXFDa09NRmkxeUt2eHZNaE1Fajd4NHZnSXVUbFNqTzIrd3hJVWtTa0lnT3JN?=
 =?utf-8?B?TTBSWi9IaEdZSVlVODVjVmF5TEZmOURhQzR2QUpOSk0vYXhaU1JNbHA0TTBV?=
 =?utf-8?B?eUlWVXVHVFU1OGt1Sk5wdmY1SklEbVZCSGVFd3JVKzNkMVVyeHl5eEdlODVp?=
 =?utf-8?B?T01TUGxXRmxhaUpTYlhseU5tZkRBV2o4WHA2UlVGN3VzMFFCRjhmWmIxWVo1?=
 =?utf-8?B?VGpNWXFLNVQzQTFWRTk2cFNBNHZialU5bmpyTC9xUkZsM0tuaHRVekM0M3Zz?=
 =?utf-8?B?SHZqY3BMMmR5b3BUaGZKT3UveU45c0dhRHkrZEhoSFIzRjMrY3JQSk1GdEdX?=
 =?utf-8?B?Z2RZUG5yNXFFWlB0NzVzUXEzajloVmk1WllHa2c2c0t1WXlRWUJVdUVSZjA0?=
 =?utf-8?B?UUVSZTlhOVVZV1dqVWhXRk9kYzJhV2U5cWwrbmlLblplRkEwWTdycFNlT00w?=
 =?utf-8?B?NFFuRjQvcmtDYVNIM0t1QXFMdVk2MURhb2FhNnkxV3N3ZVptYWdEelFBaHNN?=
 =?utf-8?B?aVFnOWFYT3dpbWgwVk5Uc2Faa2NTaElJb2pBSnp0N3MwMHJTMDc3TDFYQldi?=
 =?utf-8?B?bnZ2R0hHdTNwVWV5aTZ5V3UrR094amlhRHVXTTBaQ2lwNlF2ZEJXWGR5dUZu?=
 =?utf-8?B?SXo5OVRoakN2RFptWWJmVUQ0ODQ3dVZNVy9VY0d6OWVMcC9ON0hUSmpyTm1q?=
 =?utf-8?B?cTZ1RTkzRDRWSEZGdTVDVHROZHY0WVcxZ0xhQ0NwbG5ZY0oxbGs3STRDR01E?=
 =?utf-8?B?SHUwdmt4cDVXcnlCYWxSa0U1dEtmbXBGczY3anJlM3RNU1kzTG5jdlVxcjQr?=
 =?utf-8?B?TzViSlZNUXJ2MmIwVVZnZHBjaFNzck9HMEVVUnJORUQ3OGMyZmUxekx0U1Ex?=
 =?utf-8?B?TlVDTFYwamRwMk15dVhSYWczUGNjcE4reWdRS0x2bWM4S3Z2Ym5JRFQya3lV?=
 =?utf-8?B?ajAwRXU5Q2g4NXhzdkJVTnFERzduNU1qVUw4WE1HR0FVbC9uVUVSeURPMzY1?=
 =?utf-8?B?bHhyWU9weHBNYVh1eThBbU1lWkVwbm83RDh6cW1KaGdrL1graVNESjhHMmpY?=
 =?utf-8?B?Q1IxTm5hekU5MDFqZFZhS3F2cEhNamVkY09TeFc3WjV0OWM1U2VkeW9sU1Bw?=
 =?utf-8?B?eCs4WElYWkpzT09PZ0syT0gvR0FoNXJDSHFpUjUwRTBrVC9CZkMxUHBhajZY?=
 =?utf-8?B?bEVyWDNtZVNrclNnSjMrWStvVjJOTmRDNi9oR0tlZnpPTmFUUHdURkJvaTRE?=
 =?utf-8?B?eGdxRVJaN2dxemU0czFvbkRBZHNPcWU3RlZQVXJuZURYVzlEeTczY3Vva2tN?=
 =?utf-8?B?SU83TzgvZ0pUN0lwczF5UThCVlhCMVcxYm83TDdkcFNISk5nalhrZ1lvejdP?=
 =?utf-8?B?T2ljZFRuQ0pxNEVtZTI2Nk01RHc2Z04yT0xMR2EvNEZ3NE1mSWFaa0NPVFZs?=
 =?utf-8?B?WElXNTVPc1pJNS9BSjFrTzN0MkEwMjRRRWRYYzM2QUJtWG1MSHZYdzkzSnNo?=
 =?utf-8?B?OWNmT0FXamFFV3pBbkFCeHI5SmV4a0JYZFUzME1yQ0piTU9qaGtiRzFEa3pl?=
 =?utf-8?B?dndKSmpod3VCWHRFRzhmOVY1L1U0OGlSSFhoY2VtQy9xRFdDY1ZWZW9WeDN0?=
 =?utf-8?B?WVNkd3JDeGN1cUhPK2lwbUFqcnBSU0lNY1dBaXI3K1NhT3ljMnBXeDhXRTRW?=
 =?utf-8?B?NVpUUlllb0pnbVY2aG93cG8vb2JXN2JzVFpjbjlpUnhCMW1NV0IweXV5WC9m?=
 =?utf-8?B?bDg5aFVNdkNBQnhpSWVVdVVPZUg2ck90Z0lBMlZTczMyeXprMUxKRC9qcWRz?=
 =?utf-8?B?UldUQXUwQVBYT1Y5NFh6NzFSTGd4N0hBQmVuWjRxUXVVeVNwNEhxc1I0OXNm?=
 =?utf-8?B?STFBMDVSOFlaVUFvREhsS2FMWXVtL0JuY2JYNTlmUjYyTXdyTEtKVG1Oblkz?=
 =?utf-8?B?SnFNVUtJa3lHZXdiem4wenpvemw3Z1pOZ1V4dzJxR2Z4T1RtRkc2c3BTZDdT?=
 =?utf-8?B?QnFRYVJMajhhL0hZZUdSR0toRkJBYWJQYjRycGp5YkJrR2J2MTBxMFZWK003?=
 =?utf-8?B?MUF0V1F3RzV5Ti93bS9XNE4yRm1mNUVmMHdoRFpaUmt4Z1VKcTB3aFg2WmlU?=
 =?utf-8?B?WDVPejRMSkZPR3dLOVovMkpIR3NUVjA1Qkt2VFZrc0YyYk11bmFTRDJsMXZB?=
 =?utf-8?Q?gUH/gMN5YhyP4lcSz2SbGm41Zf2aIOKtTdTGY7Wp7A=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 803df9a5-8b83-4977-a0b1-08d9a45e9bb4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5151.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 15:27:29.8181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P2MuA5xbO2ebOemjvgHkTSZ7iRwUhfFJs8kUQpkbXM67lmyl0vVwCtcMqTjGbcRMIno8LX1vGO+FUz+SPAhOvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2653
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/8/21 1:11 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> With CONFIG_SND_SOC_SOF_COMPRESS=m, the compression code is
> not built into a the main SOF driver when that is built-in:
>
> x86_64-linux-ld: sound/soc/sof/ipc.o: in function `ipc_stream_message':
> ipc.c:(.text+0x5a2): undefined reference to `snd_sof_compr_fragment_elapsed'
> x86_64-linux-ld: sound/soc/sof/topology.o: in function `sof_dai_load':
> topology.c:(.text+0x32d1): undefined reference to `snd_sof_compr_init_elapsed_work'
> x86_64-linux-ld: topology.c:(.text+0x32e1): undefined reference to `snd_sof_compr_init_elapsed_work'
>
> Make this a 'bool' symbol so it just decides whether the
> code gets built at all.
>
> Fixes: 858f7a5c45ca ("ASoC: SOF: Introduce fragment elapsed notification API")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Indeed this is a bug and must be fixed. Thanks Arnd!

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

> ---
>   sound/soc/sof/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
> index 6bb4db87af03..041c54639c4d 100644
> --- a/sound/soc/sof/Kconfig
> +++ b/sound/soc/sof/Kconfig
> @@ -47,7 +47,7 @@ config SND_SOC_SOF_OF
>   	  Say Y if you need this option. If unsure select "N".
>   
>   config SND_SOC_SOF_COMPRESS
> -	tristate
> +	bool
>   	select SND_SOC_COMPRESS
>   
>   config SND_SOC_SOF_DEBUG_PROBES