Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965253AbXAGXnx (ORCPT ); Sun, 7 Jan 2007 18:43:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965251AbXAGXnw (ORCPT ); Sun, 7 Jan 2007 18:43:52 -0500 Received: from chilli.pcug.org.au ([203.10.76.44]:51808 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965253AbXAGXnw (ORCPT ); Sun, 7 Jan 2007 18:43:52 -0500 Date: Mon, 8 Jan 2007 10:43:47 +1100 From: Stephen Rothwell To: Kyle McMartin Cc: Christoph Hellwig , akpm@osdl.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, parisc-linux@lists.parisc-linux.org Subject: Re: [PATCH] Common compat_sys_sysinfo (v2) Message-Id: <20070108104347.83a004aa.sfr@canb.auug.org.au> In-Reply-To: <20070107154045.GD3207@athena.road.mcmartin.ca> References: <20070107144850.GB3207@athena.road.mcmartin.ca> <20070107151319.GA23478@infradead.org> <20070107152213.GC3207@athena.road.mcmartin.ca> <20070107154045.GD3207@athena.road.mcmartin.ca> X-Mailer: Sylpheed version 2.3.0beta5 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Mon__8_Jan_2007_10_43_47_+1100_m6PjlmpmWyD=I.wq" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 58 --Signature=_Mon__8_Jan_2007_10_43_47_+1100_m6PjlmpmWyD=I.wq Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: 7bit Hi Kyle, Looks good. Just one nit and one comment. On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin wrote: > > diff --git a/kernel/compat.c b/kernel/compat.c > index 6952dd0..cebb4c2 100644 > --- a/kernel/compat.c > +++ b/kernel/compat.c . . . > + __put_user (s.uptime, &info->uptime) || ^ We don't put spaces in here ... > +asmlinkage long sys_sysinfo(struct sysinfo __user *info) > +{ > + struct sysinfo val; > + > + do_sysinfo(&val); > > - out: > if (copy_to_user(info, &val, sizeof(struct sysinfo))) > return -EFAULT; People have complined before that this adds a whole stack frame to the "normal" syscall path. Personally I don't care, but it has been mentioned. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Mon__8_Jan_2007_10_43_47_+1100_m6PjlmpmWyD=I.wq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFFoYXCFdBgD/zoJvwRAvt5AJ4vBigJICMLJanO+YBo1S+xZzJFEQCfbXi8 TEwHcaCFk6+/ul3Z/RmGpE0= =fF8z -----END PGP SIGNATURE----- --Signature=_Mon__8_Jan_2007_10_43_47_+1100_m6PjlmpmWyD=I.wq-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/