Subject: Re: [PATCH V2 4/4] crypto: ccp - Add SEV_INIT_EX support
To:     Peter Gonda <pgonda@google.com>
Cc:     David Rientjes <rientjes@google.com>,
        Marc Orr <marcorr@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211101172127.3060453-1-pgonda@google.com>
 <20211101172127.3060453-5-pgonda@google.com>
 <952fa937-d139-bd90-825c-f7dfca8d8cb9@amd.com>
 <CAMkAt6qdNWP-Ka1N=0d16Q1TrbHPXPEkdLoxC8ndsyid-dqA6Q@mail.gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <d6fc38fa-1caa-289a-ae92-102a96638560@amd.com>
Date:   Mon, 1 Nov 2021 15:02:22 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <CAMkAt6qdNWP-Ka1N=0d16Q1TrbHPXPEkdLoxC8ndsyid-dqA6Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UExvUHpJdnczTFBhcEsyOHpDOFdMY1Y5QXdRMTU0NGRRbVZtNHRhcmVvTmZ4?=
 =?utf-8?B?NUVUbmtRaVdjemlGUTFRcWhaWGN2dzEvNXVOWDhJQVNhSExCcUNBbGsvSzhw?=
 =?utf-8?B?Um82U0VFM2lMb081K0RmcHJGalVoUTRvNUQwb1hCbDhmcWV6VklhVWhET1Np?=
 =?utf-8?B?YkZOWVZQQi94TXZxd0NwZ2lnM2VzaHUwT1ZiZVFPL25TSkRpSXJjNEZDUTdD?=
 =?utf-8?B?RFA2SzBiN1pMY1ZIRC9GcFI4cXpvSzBaL210R0x3bmorQ0docmd2WmxKNFZh?=
 =?utf-8?B?ZDBRS3BiaFYrTVd3WmljK01JcjNaOGVjQWY2azg2Zk1yU3BabVVyclVUN1Ja?=
 =?utf-8?B?aUVjR0ZydE4zblhsN0ZCYTZ4ZFpqdElGeHJIZzJrTHJNTGFTdXJVbk9wTU10?=
 =?utf-8?B?ZmRtTksxbTk2RjBjUVRoNmRVNkoyUnpHcm5xVWwrZDBXVkgxam9JOUMrRG0y?=
 =?utf-8?B?RnVFcE93K2thbHI0Nm9wMkdaZ253UDJDSzdHaE9hbWh1VkpjT2ZWVDYxNjd3?=
 =?utf-8?B?RFphd3UxOGVZSjRHSzNTUHI1WUhKMDZvRFZ3VHpKZTBycWg4cDRBejJRb3VP?=
 =?utf-8?B?OG5KT1BINUtYTzdrOVRpdDB5WXR0cFVjR1ZYM3U5R3IzZ3dnSHhoVkdoR01o?=
 =?utf-8?B?ViszaWd2VkFLRmJSMlp3OTFxajhaWWxpL25PdTIwaDJyZTVIZFhaYUZoa29N?=
 =?utf-8?B?b2JSRlZ5cTZ1aHM5dHJCYjdLblhEUWV1RVBIbllMbGtSVi9sYVhjUE9qai9z?=
 =?utf-8?B?a010dzBEa25GVHp5N04zOUlrc0ZwTmFTSzNWbDN1UEtYTitmUWx4aTF6ckR0?=
 =?utf-8?B?V1JNRFlibitSQVI3MkFqNHhUVTh1bXZYUDkwNGZrUUpMM1NKSW9BaHNFWEJJ?=
 =?utf-8?B?UkFGTzBFSlRSbmlrTlJTUXZFTm9pVmdDK1FnQzBBc2N1OUdQS25EQkI2VCtn?=
 =?utf-8?B?bERqN2JRMmF5eVNTWkdvRnl4c1JmZjhBWDJPQTlnbk9EUWpiK2lZTUlDUjZR?=
 =?utf-8?B?aUVYNHhqWllXQlBkZHlMdE9OeXg0dCszdFNQR082anFwQXM4ZVg4MWlrdmwz?=
 =?utf-8?B?bllscGtXcmFJTS9aRlROckF0ZlI3ZGdxbzRTQzNRUkVvbGhCWWZqZjdDNGFZ?=
 =?utf-8?B?NWVzYk90WHZwdDFMWFVEZngrYXZEZEFWaElRR3JEbkV5dEZLNmVYbHJkbE5D?=
 =?utf-8?B?VTFmSU44NnlTNm1LdnNHU0l5UGxPRm0wUFpxcHlhWHVFbmh4VVR5VmJoL3dC?=
 =?utf-8?B?NTVER1FEbVk5RTFvR1hCdVVoSmhCd3FDMjFZWUk4R05oTHh0eS84NkpLYXN1?=
 =?utf-8?B?N0VwTzREQXllR2J5NU1sK04zcUwxK1I5ZGN0ZzFmSU9aVnpXS3A5YzJmbUJP?=
 =?utf-8?B?SkpzTk5xSWlOeXBTdVJsalhjOVZ1YjVtbkVMUjU1Wm11a2dqSnV2UEg2QVlv?=
 =?utf-8?B?S3NOdmF5TE0wTEppTlg5MEs4QkJ1TE9rb01xRFd4N0kxY2xnZndIS1JwZmlK?=
 =?utf-8?B?TW8zeDFPOTBhL1oyVk1zZzA0cmdwemttZ25tYmk5WENvMUJZdzRDaFpieTYw?=
 =?utf-8?B?V25rSEcza3ViZHQ4bk1DcDNwYmxiYlZSYVlibHZmc2lRUzFZRk5YeXJoMklm?=
 =?utf-8?B?bk9URFREc25FSWxqeDFlTVhnekpCZDZMSTBlZ3BUM0xlK3JsSkFvNnV2azg3?=
 =?utf-8?B?aCt1QnZIMGdwaG04VFBwRmU3MkVZKzI3bHVpVkMwWCtRbTB1VXNVWmxpalRN?=
 =?utf-8?B?VWlUV3NzTCtHditrdVBONThIbHB1ZWc2cmJ4RHF0RjNqS0lkd0R3QlQ0Mzg3?=
 =?utf-8?B?VXVkbHpUYi9uempCelF2UnVSN1pWdFFrYmdzdFlPajZHbUVFZmdsTS90MEFE?=
 =?utf-8?B?S0M3QmhMVExCK0ZPei90MXFyZGp1RGtlU3Z5SHBsVFBJSmNUNThVSUFpcWpV?=
 =?utf-8?B?MmZNbWFJZFgxWURXbFpzUUxOanFQS0IzcjQ2RDNmeU1tRUhXenNQQWRXZXFt?=
 =?utf-8?B?NlNocysycGxlVW84dmhidFFSTmtyTjQ0U3ZwVXozSjNqUWNOc0pRWVpzR0tj?=
 =?utf-8?B?OFJVUkhCQzVCcEhMTTY2VkwxbTk4b1kxaUs2cHhHUWhnUmtZU2ZEejJCajBt?=
 =?utf-8?B?UFFqd2tUTHA1SDJZaFFZR0NOSWZtNWVIZHpDUmJsM2J6YnU2S1RFNFVpS3pE?=
 =?utf-8?Q?JN8EoFbTjs7aC/6EM3N1Qd0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59cf16ec-8aaa-41af-8033-08d99d728603
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2021 20:02:25.2104
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m49tgOqkts7hfIy2Y5Cyvi/Fm7EfrETeGTKZJWf/sx946dy2cIn1ZG/Cupbns1kT7t8pYq52knHKbBgNMKtTcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5344
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/1/21 2:18 PM, Peter Gonda wrote:
> On Mon, Nov 1, 2021 at 12:41 PM Tom Lendacky <thomas.lendacky@amd.com> wrote:
>> On 11/1/21 12:21 PM, Peter Gonda wrote:

...

>>> +
>>> +     fp = filp_open(init_ex_path, O_RDONLY, 0);
>>> +     if (IS_ERR(fp)) {
>>> +             const int ret = PTR_ERR(fp);
>>
>> I don't think you need the "const" here.
> 
> Sounds good, removed. I normally default to consting a variable if I
> don't expect/want it to change. What guidance should I be following
> here?

Heh, I don't know... I guess since its in such a short scope it just read 
easier to me.  But, you're correct, const is appropriate here, so I guess 
feel free to leave it in if you want.

> 
>>

...

>> "SEV: write successful to NV file\n"
> 
> Updated all messages. Should have noted the "SEV: .." format.

It's not like we were very consistent originally, but it would be nice to 
have the new messages start to maintain a consistency.

Thanks,
Tom

>