Subject: Re: [PATCH V3 4/4] crypto: ccp - Add SEV_INIT_EX support
To:     Peter Gonda <pgonda@google.com>
Cc:     David Rientjes <rientjes@google.com>,
        Marc Orr <marcorr@google.com>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Joerg Roedel <jroedel@suse.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        John Allen <john.allen@amd.com>,
        "David S. Miller" <davem@davemloft.net>,
        Paolo Bonzini <pbonzini@redhat.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211102142331.3753798-1-pgonda@google.com>
 <20211102142331.3753798-5-pgonda@google.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <0701eb12-a60e-381f-ddd0-9ee9a0fa3edb@amd.com>
Date:   Tue, 2 Nov 2021 10:38:02 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211102142331.3753798-5-pgonda@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUxSZnh6c3lmWkc4bncyMWNBZ1ZEaW1OZnppNzhQVllhTERSVDJmV24yZExD?=
 =?utf-8?B?bUVFUmVBc25QdGxnVlZNTnM2c2RxcE00N3ZBTnh5SXNmWHBEYzdzZXZvVlA3?=
 =?utf-8?B?a0pVU0hFcnZ0ajI4dGlzbkF5Ykw2M1pqbS9iMThySnNVQ0Y4aUZyU1ZsQ1Ay?=
 =?utf-8?B?c3JKVDJEME04MGRWdFcyTWRmYXhvN25pbWRYWHN6NkpIRWVtZVBRSllWUVo1?=
 =?utf-8?B?cm9tcXlWVW9HQ1RkbUJmMTZDdmZkdGZ3RTBDeUNnMzdVYWhNcy9FSHFhOGVy?=
 =?utf-8?B?bkhCRnJZcDZBZW5QWXp2U3N0MFBtOFBmZWVvM3p0aFdGcXdKQ0RNT2t0RXFo?=
 =?utf-8?B?ODFDSHFQR3FFWEFSSTNmNUdheDRjcGNwZnY5ZXRyeHdvRjVsWWppQjF1a0JI?=
 =?utf-8?B?dGR5cXp4NHBkaDN6K3pnakxuczNlcW5pVUdiU0U2a0JQOTY3NjlPUnU2Rm1K?=
 =?utf-8?B?NDF4eVRQbHQrU1lnQmwwMDZzMzlNZzZlalBxaDFYNkpqOUhSdjc2ZGN0Y2FI?=
 =?utf-8?B?QVhJTnN0RDVzeUhHSklxZGVCNFRRa1k0TDNPU0dDQ0JqcDdmVDhEZVFJTGdN?=
 =?utf-8?B?QnIvOVdlcU1rS294NHNGU25pdjRvdWRDamtFQnJ2eWIzOUFjdzU4ZEZJV2s0?=
 =?utf-8?B?cW9zaW55Z3hla3VOYUk0RGp5S2RidGdUWFl3ODdmU1JwNDNDQ1VSM2Z4cVdK?=
 =?utf-8?B?emdVRTFXVEs5dGpMak4zMWRXNUh0VGZpRTNlYkpGT0RCVHZ5YkgxR2t2OVgz?=
 =?utf-8?B?QUVpYm5rb0RXc1QzUUFpK1BQNVhITE0zVEZJdjBLUjBBSmRhMXE2ZVRNK21S?=
 =?utf-8?B?RlAxRHNuRWxTNXE2OENLbW16MUlpaWFlaXdDeUdxY3ZZd0RZK3k2dHpvenhI?=
 =?utf-8?B?SndINnVCdVp3bW15V3pVM3YwdzZqZVZlV3Q3Vk0wRVMxVkREamswdTVTN2VZ?=
 =?utf-8?B?Y09xVUtQeHlhbU1OYzNrNUpaZUhUeHlJVVNDOVh0MjBSV3c1TmFQNlYwYkFr?=
 =?utf-8?B?ZTJ2Z0JSZHRUUWI3WGY4K0VGSllzOWJWM3p3TDVGSldrcGROTUcyR2xRVk9R?=
 =?utf-8?B?NUIyZWI0eHEweTlhSTVrSm1vOXVJRjM4OXl2dVloY2xDb2I1SHZNT0ZQNzBJ?=
 =?utf-8?B?ZEc1U0JVTWRzS2d3dnoydklSZnowcXVjeW9NcVV3L2x0OTU2WVY5WVRlVWdL?=
 =?utf-8?B?TG5LMTREWXRqWmJVdzVNQkRrcjdLNENRWE9iSk5FbElTd2ZLR05nTDIvcHR5?=
 =?utf-8?B?VDR1a2MrcGJXTTlKd3lNTjRmK2RuTDRtUE9jNVZkYUNFUEZLRldGSEllRzkz?=
 =?utf-8?B?dGk4YnVzRWRHVlgvSlIvdWJFK3Jlc2FYL0pWTmxmODl1N0R1RUpSZDI5aUZr?=
 =?utf-8?B?TFNwRUZVNXI1SXZXUEo5aTkzNnRvU0h0N0RFRU9TMVFoRG14UGJqYlQ3ejdI?=
 =?utf-8?B?cTZGQWRIcCtMWWNKcGROWjdMVDg2dXFQNFRwWTZSSjZzQ29URjVaRUprajMw?=
 =?utf-8?B?cEdSVzd6TnpLRGwyYmNWSzhRcXNmczJzNTRxOXZrWlJrakJXVGJpMVlTRVdh?=
 =?utf-8?B?OWU2UjA4cEVTcVhUR05xNGttR3p3R3VScGVRZTlXaVliMzBOV284aWNmNUJM?=
 =?utf-8?B?V000OHcwVUQ1Rm5zN0VhZ1pkamQ0cW4xU2FTSHBZdStESmRuWnB3bk5kZDhC?=
 =?utf-8?B?M0FncFdZTXRjKytDdjlURFdJQ1QwMy9CWFA4TnBWWTlvYWF0RDZJRDNaNkFl?=
 =?utf-8?B?enJ1QmlVUUd2NjBQckoybFVGZnF0ak1Ka0UrNEtGdjFYL0dnTkdTVnZPellZ?=
 =?utf-8?B?OFl5NG93T0M2VHgzc0I1WnVFWnpVVEpnZy9zd2EweVFSQm5xOWxicGZQcGxr?=
 =?utf-8?B?TEEvcTJEelVYOVJrcmdPRnpFUGRUOG5kOUcxalY0bHNqZjBTNTZzTWZHQ1dx?=
 =?utf-8?B?OEhkREJncEVQdDNJNlZSVjgzZXQ4VzJ0R05xYU9YRjI2VjROeVZHVzkxRHFx?=
 =?utf-8?B?WHp3dWFGZmhjOStXYStZaUd1eXZpVFV2bUlxbjlXNlhuckhyRkd5TE02ckhE?=
 =?utf-8?B?SEhNZk5ETW56TEN3UzFDNjlpVXBxWHJLZTkzK2wyb1EwRTRPd0M4dWVmV0NI?=
 =?utf-8?B?WTRjekxTRjNrM2hFMlVvWWtkUDRqT1ZTdkgyVGE3T2xFUGx5WmVoL1dSS1Iv?=
 =?utf-8?Q?F+UphjWPrrW0AYfWy4URJpU=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9206e46a-9353-4786-d388-08d99e16c373
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2021 15:38:06.1176
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z1EET06hzbHI7RaNKXotEXOtEHMl1aIRwItS0P2NeuaK6P7zhlnlFiFDH4izu7/1kbq9XkZUInTq6SCgouLVCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5134
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/2/21 9:23 AM, Peter Gonda wrote:
> From: David Rientjes <rientjes@google.com>
> 
> +
> +	nread = kernel_read(fp, sev_init_ex_nv_address, NV_LENGTH, NULL);

Not sure if you missed the previous comment, but kernel_read can return an 
error, shouldn't it be checked and fail on error?

Thanks,
Tom

> +	dev_dbg(psp_master->dev, "SEV: read %ld bytes from NV file\n", nread);
> +	filp_close(fp, NULL);
> +
> +	return 0;
> +}
> +