Date:   Wed, 3 Nov 2021 12:45:27 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Jonas =?iso-8859-1?Q?Dre=DFler?= <verdre@v0yd.nl>,
        Amitkumar Karwar <amitkarwar@gmail.com>,
        Ganapathi Bhat <ganapathi017@gmail.com>,
        Xinming Hu <huxinming820@gmail.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Tsuchiya Yuto <kitakar@gmail.com>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Maximilian Luz <luzmaximilian@gmail.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Subject: Re: [PATCH v3 2/2] mwifiex: Add quirk to disable deep sleep with
 certain hardware revision
Message-ID: <20211103174527.GA701082@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YYLJG1y8owwehew+@smile.fi.intel.com>
Precedence: bulk

On Wed, Nov 03, 2021 at 07:38:35PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 03, 2021 at 06:10:55PM +0100, Jonas Dre?ler wrote:

> > +	if (mwifiex_send_cmd(priv, HostCmd_CMD_VERSION_EXT,
> > +			     HostCmd_ACT_GEN_GET, 0, &ver_ext, false)) {
> > +		mwifiex_dbg(priv->adapter, MSG,
> > +			    "Checking hardware revision failed.\n");
> > +	}
> 
> Checkpatch won't warn you if string literal even > 100. So move it to one line
> and drop curly braces. Ditto for the case(s) below.

I don't understand the advantage of making this one line.  I *do*
understand the advantage of joining a single string so grep can find
it more easily.  But that does make the code a little bit uglier, and
in a case like this, you don't get the benefit of better grepping, so
I don't see the point.