Subject: Re: [PATCH] crypto: hisilicon/hpre - use swap() to make code cleaner
To:     <davidcomponentone@gmail.com>, <xuzaibo@huawei.com>
CC:     <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Yang Guang <yang.guang5@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
References: <20211104061910.1505738-1-yang.guang5@zte.com.cn>
From:   liulongfang <liulongfang@huawei.com>
Message-ID: <5913a9db-6cb7-6752-51ec-f6d09aa612ff@huawei.com>
Date:   Thu, 4 Nov 2021 17:34:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20211104061910.1505738-1-yang.guang5@zte.com.cn>
Content-Type: text/plain; charset="gbk"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/11/4 14:19, davidcomponentone@gmail.com wrote:
> From: Yang Guang <yang.guang5@zte.com.cn>
> 
> Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
> opencoding it.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
> ---
>  drivers/crypto/hisilicon/hpre/hpre_crypto.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> index a032c192ef1d..0f1724d355b8 100644
> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> @@ -1177,13 +1177,10 @@ static void hpre_rsa_exit_tfm(struct crypto_akcipher *tfm)
>  static void hpre_key_to_big_end(u8 *data, int len)
>  {
>  	int i, j;
> -	u8 tmp;
>  
>  	for (i = 0; i < len / 2; i++) {
>  		j = len - i - 1;
> -		tmp = data[j];
> -		data[j] = data[i];
> -		data[i] = tmp;
> +		swap(data[j], data[i]);
>  	}
>  }
>  >
OK!
Thanks.

Longfang.