Message-ID: <2bd55f74-be52-f182-b210-1d2d88fd8fdf@gmail.com>
Date:   Fri, 5 Nov 2021 22:31:03 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH] staging: r8188eu: core: remove the unused variable
 pAdapter
Content-Language: en-GB
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        straube.linux@gmail.com, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
References: <YYNSAqGgDPhV1IE1@Sauravs-MacBook-Air.local>
 <YYT/s7TABtElQTnC@kroah.com>
From:   Saurav Girepunje <saurav.girepunje@gmail.com>
In-Reply-To: <YYT/s7TABtElQTnC@kroah.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 05/11/21 3:26 pm, Greg KH wrote:
> On Thu, Nov 04, 2021 at 08:52:42AM +0530, Saurav Girepunje wrote:
>> Remove the unused variable pAdapter from Efuse_Write1ByteToFakeContent
>> This variable is not used in the function.
>>
>> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
>> ---
>>  drivers/staging/r8188eu/core/rtw_efuse.c | 7 ++-----
>>  1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
>> index 03c8431b2ed3..39c77f6b06ef 100644
>> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
>> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
>> @@ -40,10 +40,7 @@ static bool Efuse_Read1ByteFromFakeContent(u16 Offset, u8 *Value)
>>  }
>>
>>  static bool
>> -Efuse_Write1ByteToFakeContent(
>> -			struct adapter *pAdapter,
>> -			u16 Offset,
>> -			u8 Value)
>> +Efuse_Write1ByteToFakeContent(u16 Offset, u8 Value)s
> 
> You can do this same thing in drivers/staging/rtl8723bs/core/rtw_efuse.c
> if you want to.
> 
> thanks,
> 
> greg k-h
> 

Yes, Now I have sent patch for drivers/staging/rtl8723bs/core/rtw_efuse.c also.
Thanks for pointing this.

Regards,
Saurav