Subject: Re: [PATCH 1/2] add binding for iio adc driver for TI ADS1018
To:     Iain Hunter <drhunter95@gmail.com>
Cc:     iain@hunterembedded.co.uk, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>, linux-iio@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20211108184327.439460-1-drhunter95@gmail.com>
From:   Daniel Baluta <daniel.baluta@nxp.com>
Message-ID: <08278938-2a19-efc8-b111-73aa9ab2c28d@nxp.com>
Date:   Mon, 8 Nov 2021 20:45:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
In-Reply-To: <20211108184327.439460-1-drhunter95@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0gvRzAva094SSswVisxNlNQbkpHV3kvcThIT1RZUFdYR1BpaHJBWE9YTHBI?=
 =?utf-8?B?TGNpN2V1K2VVRlFuQlhhYk9WS1VZNWxnNzhIVWo4Y2JEbjhtQjJCak00dTRR?=
 =?utf-8?B?VGJQVklkejRTTkY5VWJIV2FxUHRyUEljaEdMNnJ3eFBhZ1R5UGFmbHV4TFVM?=
 =?utf-8?B?MzVIempuSzkxRkg4WXFTQ3NaK09ydG16VkdPYUV0NHBEOWZqOUZ3Sno5ZWNQ?=
 =?utf-8?B?UnF3aWExWUJicm5KdmxDVjhCcHB6UHcyclJLRjB1VHpNSnpoQWNuUlZPN21o?=
 =?utf-8?B?cmJBc2NBWHh0Vmhqd2M0cjVrYlVXK3p4ZXdUVWlVNkFWV3hTQXEyQTZvNElP?=
 =?utf-8?B?d1ZwWkgvdlpmK0ZlbVlzZjVSVzNxZW1HRnJtZ0JScHJaMm9vN1Y3NHNFcFIx?=
 =?utf-8?B?NzF0OFh0dDJrVllBVkpGTm5vMmYvcVlMdTVudUxPQjMzL1hjbDRVVFRRZWh6?=
 =?utf-8?B?K0Izd3ZaQjlISWoxVG5BMzJjVnE5ZW9NY2xqT0Z6M1Z0UVh1eG9sNTZ5aUhS?=
 =?utf-8?B?STNUNkRIdnB4YVcyUVNod3RVRXpvNnY1b01QWjVRS0JUcEoyc0oxZkdNcnI5?=
 =?utf-8?B?RjBsMHZCUG9vcjl4TnIxWmVxWVJMNzNJM1A1ZU1NNEsyWXZra1VWcXMwVU1i?=
 =?utf-8?B?MTA1ZVpsNDZOZDdSSnVsK2Z4Y004L1ozZWgxb2V0Qy9CQUFQSGhNYjBnZUhZ?=
 =?utf-8?B?RUlyNWwxRDIyTVZBK0haYkpBbVl4WWluUmRiazArK2w1ZU5pQWpaQjJyWjRs?=
 =?utf-8?B?dlQ0RGJ5WFNzT1RqcDErKzBoZi95Q3NPVGlrYkxWZXJIOGJBYklvbkhyT0hh?=
 =?utf-8?B?QWZpZUZITmx0MXViMXdWVDhpTVlJNFpjSmgyT2p4VkJiVlUyem9UOEgxVnlM?=
 =?utf-8?B?aVpaaFpxb0VKc2ZJZG5nWVFtaWsxcklPeVM3dEhXYkI0QjQ1cEYxQ0pKLzZF?=
 =?utf-8?B?WUxzek80UVJ0UTFPVzE4YVRDaFpYWVQ0SnhnTFRqQ1Z3dDQ1OGZ3c3A0UHRJ?=
 =?utf-8?B?TFRwWFl4Vy92SkZxb3ZYeE1RTUJFZTc2SnJZZU5qUVhxaU5ObnNML2hhTHRR?=
 =?utf-8?B?c1ZtVWtaTkl1VWFmK2VaK0dOMEFXUFVJNGFaaHdvMEp2VTBrUHlGYysxczdw?=
 =?utf-8?B?ejhFcWI3UWI1aWFORnZvZ21GNUFPUkRCc3dhR2gvUzhzc256NzBkVm0xRS90?=
 =?utf-8?B?MkJyUGJtanl0QzRyYU1zWTJrM09hajBCRmtwWTFDNmU4Ry9idXhqYmFuWCs2?=
 =?utf-8?B?cTFWMjNCYTdTR0xVN1VQb0ZVQVZtY0VvUDA1Y3hyRUJEempZZUtZaXdCT0xN?=
 =?utf-8?B?dW9CWlJSaGNWTEptanVVQXpLdXFjQ243VG1wV0R2Z25jVHhOUlIzSHZ3UzRB?=
 =?utf-8?B?MTZRTW53d2JWMFBDM2ZYNzFmNmJXN3hXQ1p3bVNrdXhwWW03ZmdPQzdQOVJX?=
 =?utf-8?B?NU82b29mN0lIbnJMeFlhSDBHYVJvT3RRYmhDc3N6ZVhSTGF2eXpEYVdFNjhR?=
 =?utf-8?B?eW16eFpXS09yV2hjUzQ4OStWVE0wWDZqSWVXQUNWR3YwdXBhMUgzYU4yNDJR?=
 =?utf-8?B?QVJvVUZ0eG8wWEJwZVY4Q0hHVTVEYUc0MWRjSitsSGxOOHRWRHpqUVVkZ2sz?=
 =?utf-8?B?OFFyYTlaZUh2TmdvSzF6akJVMFBDcVhCakk5L2o5YmNqekxtODNxZFFYMVky?=
 =?utf-8?B?bjRJdGYvRytCV0Z3MDY2cUpDeTFST001UDRseUZ2NDYwZS9yY3lrVERidGRI?=
 =?utf-8?B?b3pCejkzem9DUVFoZng3dVI5cVE0S0tOVHNMV2FycFdpTUFpM2JJaHFIUHNl?=
 =?utf-8?B?dWoyOERtb1I1THJJV1dPc2dNK2hvd0ZoMFBXMUxqc2srcTVPbjMreFc3RTFn?=
 =?utf-8?B?WDg0SThVcWtPYmowTnJ4Nms1bzkzNkd2VnV0NmlqTElpcGJZYjFObURrV2dX?=
 =?utf-8?B?cy9ybHZNMGdxTlZ0SDJMQ21pQWpvTTZiNzIrMzRSUHVPV1VVZU1VZzlNaFZS?=
 =?utf-8?B?MFNtekpEOCtLWXZKSXFYM05qUWVtY2JRckx6YmZwOWZtTThpbWE4Z05lRTBr?=
 =?utf-8?B?ckEwMTRFYWhSSklnWktjNGpyV1FwUTQxQXJrNW9lUkRSdGQybVUxVWdsNWFC?=
 =?utf-8?B?V3A4cmIwWFptbFdFRVd4eVB2eXEwbmh0M3kvR0JBRUFkdC8zMkpZc0NQMGE5?=
 =?utf-8?B?WmVZa2ovRVc4enB5VHN2VUwyQzIySURzQTA1NHA5bk9UVVRGWE5PWVVPb0Vw?=
 =?utf-8?Q?Cy1O0FCuwIyyCIwvsVDJ+eX1RoZhkr+KUPrqdTvbHw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2736f1c-61d4-4136-b5f2-08d9a2e7f9bb
X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB5145.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2021 18:45:46.4287
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I/555eKHOJ3LGAToH7T1WG7bIjXzFuMq4BrK7Itgqb/W/OxC06HMolz4ISBTnJp26qQ+p1w+ZBE99HwmmCRIbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2773
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This looks good to me with the only mention that I don't actually have 
time to maintain this :(.

Perhaps you can add yourself?

On 11/8/21 8:43 PM, Iain Hunter wrote:
> Add a new binding for new IIO ADS1018 driver.
>
> Signed-off-by: Iain Hunter <drhunter95@gmail.com>
> ---
>   .../bindings/iio/adc/ti,ads1018.yaml          | 109 ++++++++++++++++++
>   1 file changed, 109 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> new file mode 100644
> index 000000000000..ba0fdfba2c45
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1018.yaml
> @@ -0,0 +1,109 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1018.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI ADS1018 4 channel SPI analog to digital converter
> +
> +maintainers:
> +  - Daniel Baluta <daniel.baluta@nxp.com>
> +
> +description: |
> +  Datasheet at: https://www.ti.com/lit/gpn/ads1018
> +  Supports both single ended and differential channels.
> +
> +properties:
> +  compatible:
> +    const: ti,ads1018
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#address-cells":
> +    const: 1
> +
> +  "#size-cells":
> +    const: 0
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false
> +
> +patternProperties:
> +  "^channel@[0-7]+$":
> +    type: object
> +    description:
> +      Child nodes needed for each channel that the platform uses.
> +
> +    properties:
> +      reg:
> +        description: |
> +          0: Voltage over AIN0 and AIN1.
> +          1: Voltage over AIN0 and AIN3.
> +          2: Voltage over AIN1 and AIN3.
> +          3: Voltage over AIN2 and AIN3.
> +          4: Voltage over AIN0 and GND.
> +          5: Voltage over AIN1 and GND.
> +          6: Voltage over AIN2 and GND.
> +          7: Voltage over AIN3 and GND.
> +        items:
> +          - minimum: 0
> +            maximum: 7
> +
> +      ti,gain:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 5
> +        description: |
> +          pga is the programmable gain amplifier (values are full scale)
> +          0: +/- 6.144 V
> +          1: +/- 4.096 V
> +          2: +/- 2.048 V (default)
> +          3: +/- 1.024 V
> +          4: +/- 0.512 V
> +          5: +/- 0.256 V
> +
> +      ti,datarate:
> +        $ref: /schemas/types.yaml#/definitions/uint32
> +        minimum: 0
> +        maximum: 6
> +        description: |
> +          Data acquisition rate in samples per second
> +          0: 128
> +          1: 250
> +          2: 490
> +          3: 920
> +          4: 1600 (default)
> +          5: 2400
> +          6: 3300
> +
> +    required:
> +      - reg
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@1 {
> +            compatible = "ti,ads1018";
> +            reg = <0x1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            channel@4 {
> +              reg = <4>;
> +              ti,gain = <3>;
> +              ti,datarate = <5>;
> +            };
> +        };
> +    };
> +...