From:   Rob Herring <robh@kernel.org>
To:     conor.dooley@microchip.com
Cc:     ivan.griffin@microchip.com, jassisinghbrar@gmail.com,
        geert@linux-m68k.org, lewis.hanly@microchip.com,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
        aou@eecs.berkeley.edu, paul.walmsley@sifive.com,
        broonie@kernel.org, atish.patra@wdc.com,
        linux-riscv@lists.infradead.org, linux-i2c@vger.kernel.org,
        palmer@dabbelt.com, gregkh@linuxfoundation.org,
        linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        bin.meng@windriver.com, robh+dt@kernel.org,
        linux-crypto@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com,
        a.zummo@towertech.it, linus.walleij@linaro.org,
        daire.mcnamara@microchip.com, alexandre.belloni@bootlin.com,
        krzysztof.kozlowski@canonical.com
In-Reply-To: <20211108150554.4457-12-conor.dooley@microchip.com>
References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-12-conor.dooley@microchip.com>
Subject: Re: [PATCH 11/13] dt-bindings: usb: add bindings for microchip mpfs musb
Date:   Mon, 08 Nov 2021 22:06:29 -0600
Message-Id: <1636430789.946637.743044.nullmailer@robh.at.kernel.org>
Precedence: bulk

On Mon, 08 Nov 2021 15:05:52 +0000, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Add device tree bindings for the usb controller on
> the Microchip PolarFire SoC.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
>  .../bindings/usb/microchip,mpfs-usb-host.yaml | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: properties:interrupt-names: 'oneOf' conditional failed, one must be fixed:
	[{'const': 'dma'}, {'const': 'mc'}] is too long
	[{'const': 'dma'}, {'const': 'mc'}] is too short
	False schema does not allow 2
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml: ignoring, error in schema: properties: interrupt-names
warning: no schema found in file: ./Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.yaml
Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory
   19 |         #include "dt-bindings/clock/microchip,mpfs-clock.h"
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/usb/microchip,mpfs-usb-host.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1441: dt_binding_check] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1552389

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.