Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\))
Subject: Re: [PATCH 1/1] power: supply: Introduces bypass charging property
From:   "Rivera-Matos, Ricardo" <rriveram@opensource.cirrus.com>
In-Reply-To: <20211104144444.rulz4br3xu4qc7yh@earth.universe>
Date:   Wed, 10 Nov 2021 09:52:08 -0600
CC:     <patches@opensource.cirrus.com>, <linux-pm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <75DE78A9-572A-46EC-932E-057EFB7F6421@opensource.cirrus.com>
References: <20211104135027.2352874-1-rriveram@opensource.cirrus.com>
 <20211104135027.2352874-2-rriveram@opensource.cirrus.com>
 <20211104144444.rulz4br3xu4qc7yh@earth.universe>
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Precedence: bulk

Hello,

> On Nov 4, 2021, at 9:44 AM, Sebastian Reichel =
<sebastian.reichel@collabora.com> wrote:
>=20
> Hi,
>=20
> On Thu, Nov 04, 2021 at 08:50:27AM -0500, Ricardo Rivera-Matos wrote:
>> Adds a POWER_SUPPLY_CHARGE_TYPE_BYPASS option to the =
POWER_SUPPLY_PROP_CHARGE_TYPE
>> property to facilitate bypass charging operation.
>>=20
>> In bypass charging operation, the charger bypasses the charging path =
around the
>> integrated converter allowing for a "smart" wall adaptor to perform =
the power
>> conversion externally.
>>=20
>> This operational mode is critical for the USB PPS standard of power =
adaptors and is
>> becoming a common feature in modern charging ICs such as:
>>=20
>> - BQ25980
>> - BQ25975
>> - BQ25960
>> - LN8000
>> - LN8410
>>=20
>> Signed-off-by: Ricardo Rivera-Matos <rriveram@opensource.cirrus.com>
>> ---
>=20
> Please always send API changes together with a user (e.g. in this
> case you could update bq25980_charger driver to use this property).

Ack, I will send out a v2 patch series with an update to the =
bq25980_charger driver.
>=20
> =E2=80=94 Sebastian

Best Regards,
Ricardo
>=20
>> drivers/power/supply/power_supply_sysfs.c | 1 +
>> include/linux/power_supply.h              | 1 +
>> 2 files changed, 2 insertions(+)
>>=20
>> diff --git a/drivers/power/supply/power_supply_sysfs.c =
b/drivers/power/supply/power_supply_sysfs.c
>> index c3d7cbcd4fad..1368e13dc94b 100644
>> --- a/drivers/power/supply/power_supply_sysfs.c
>> +++ b/drivers/power/supply/power_supply_sysfs.c
>> @@ -89,6 +89,7 @@ static const char * const =
POWER_SUPPLY_CHARGE_TYPE_TEXT[] =3D {
>> 	[POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE]	=3D "Adaptive",
>> 	[POWER_SUPPLY_CHARGE_TYPE_CUSTOM]	=3D "Custom",
>> 	[POWER_SUPPLY_CHARGE_TYPE_LONGLIFE]	=3D "Long Life",
>> +	[POWER_SUPPLY_CHARGE_TYPE_BYPASS]	=3D "Bypass",
>> };
>>=20
>> static const char * const POWER_SUPPLY_HEALTH_TEXT[] =3D {
>> diff --git a/include/linux/power_supply.h =
b/include/linux/power_supply.h
>> index 9ca1f120a211..9432234d7900 100644
>> --- a/include/linux/power_supply.h
>> +++ b/include/linux/power_supply.h
>> @@ -49,6 +49,7 @@ enum {
>> 	POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE,	/* dynamically adjusted =
speed */
>> 	POWER_SUPPLY_CHARGE_TYPE_CUSTOM,	/* use CHARGE_CONTROL_* =
props */
>> 	POWER_SUPPLY_CHARGE_TYPE_LONGLIFE,	/* slow speed, longer =
life */
>> +	POWER_SUPPLY_CHARGE_TYPE_BYPASS,	/* bypassing the charger =
*/
>> };
>>=20
>> enum {
>> --=20
>> 2.25.1
>>=20