Date:   Wed, 10 Nov 2021 16:27:27 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Michael Walle <michael@walle.cc>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [RFC PATCH] spi: fix use-after-free of the add_lock mutex
Message-ID: <YYvy79HfTvy8hC5/@sirena.org.uk>
References: <20211110160836.3304104-1-michael@walle.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PeOhnV+CH9K7nNWV"
Content-Disposition: inline
In-Reply-To: <20211110160836.3304104-1-michael@walle.cc>
Precedence: bulk


--PeOhnV+CH9K7nNWV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 10, 2021 at 05:08:36PM +0100, Michael Walle wrote:
> Commit 6098475d4cb4 ("spi: Fix deadlock when adding SPI controllers on
> SPI buses") introduced a per-controller mutex. But mutex_unlock() of
> said lock is called after the controller is already freed:
>=20
>   spi_unregister_controller(ctlr)
>    -> put_device(&ctlr->dev)
>     -> spi_controller_release(dev)
>   mutex_unlock(&ctrl->add_lock)
>=20
> Move the put_device() after the mutex_unlock().

Do we even need to unlock the mutex here?

>=20
> For reference, the kernel oops is:
> [   20.242505] Unable to handle kernel paging request at virtual address =
0042a2203dc65260
> [   20.250468] Mem abort info:
> [   20.253270]   ESR =3D 0x96000044

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--PeOhnV+CH9K7nNWV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGL8u8ACgkQJNaLcl1U
h9ARQAf/QJ1CMUYtqZJT5IKWPYvlRJ9hbMIp39/Bidz/cPAyf3uR6csWmKleqMJo
ZBoHP4N0wujtU1gGubHMvXkw2lUfTmSwYfxIoL8eocL28OMWbfNIVArMDCPa4SCI
WlUlgxJ7sMbjdDsB/Amsme2buFWLetDcYx+7iztRj7mizSmRGgeP9NB2+HuuRRjQ
vxG4sADx5bi6zbJS4c5dCr7jpl5/jBzHnk7NPDIuRvIGp4KPMcMQ3ilMb+X87wlL
G/IyRKpN1aauDko7FHmYJTBhNP10el5TWGSs+T5sNMDLchq+1J7pWLE0aRKIWixQ
4o8b/yj0xosjTaf3rvoD3h2GQyj+jQ==
=Ks+F
-----END PGP SIGNATURE-----

--PeOhnV+CH9K7nNWV--