MIME-Version: 1.0
References: <1635752903-14968-1-git-send-email-hammer.hsieh@sunplus.com> <1636530670-6995-1-git-send-email-hammer.hsieh@sunplus.com>
In-Reply-To: <1636530670-6995-1-git-send-email-hammer.hsieh@sunplus.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 10 Nov 2021 18:41:25 +0200
Message-ID: <CAHp75VcZuN0-zJjQUk5Afgqd-ON5PjVzMSjfM2Mouiq-EXjcWw@mail.gmail.com>
Subject: Re: [PATCH v2 0/2] Add UART driver for Suplus SP7021 SoC
To:     Hammer Hsieh <hammerh0314@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>, tony.huang@sunplus.com,
        wells.lu@sunplus.com, Hammer Hsieh <hammer.hsieh@sunplus.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 10, 2021 at 9:51 AM Hammer Hsieh <hammerh0314@gmail.com> wrote:
>
> This is a patch series for UART driver for Suplus SP7021 SoC.
>
> Sunplus SP7021 is an ARM Cortex A7 (4 cores) based SoC. It integrates
> many peripherals (ex: UART. I2C, SPI, SDIO, eMMC, USB, SD card and
> etc.) into a single chip. It is designed for industrial control.
>
> Refer to:
> https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
> https://tibbo.com/store/plus1.html

...

>  drivers/tty/serial/sunplus-uart.c                  | 1591 ++++++++++++++++++++
>  include/soc/sunplus/sp_uart.h                      |  147 ++

Sorry, but I do not believe this driver requires so many LOCs. Please,
try to get it under 1000, I am pretty sure it's possible and
achievable.

-- 
With Best Regards,
Andy Shevchenko