Message-ID: <91db431e-d5db-be5c-b0d2-382e45786886@kernel.org>
Date:   Wed, 10 Nov 2021 18:45:38 +0200
MIME-Version: 1.0
Subject: Re: [RFC] psi: Add additional PSI counters for each type of memory
 pressure
Content-Language: en-US
To:     Michal Hocko <mhocko@suse.com>,
        Georgi Djakov <quic_c_gdjako@quicinc.com>
Cc:     hannes@cmpxchg.org, vincent.guittot@linaro.org,
        juri.lelli@redhat.com, peterz@infradead.org, mingo@redhat.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vdavydov.dev@gmail.com, tj@kernel.org,
        axboe@kernel.dk, cgroups@vger.kernel.org,
        linux-block@vger.kernel.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com>
 <YYvuRUqcxW0Vu9vp@dhcp22.suse.cz>
From:   Georgi Djakov <djakov@kernel.org>
In-Reply-To: <YYvuRUqcxW0Vu9vp@dhcp22.suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10.11.21 18:07, Michal Hocko wrote:
> On Wed 10-11-21 07:36:37, Georgi Djakov wrote:
>> From: Carlos Ramirez <carlrami@codeaurora.org>
>>
>> Calculates psi totals for memory pressure subevents:
>> compaction, thrashing, direct compaction, direct reclaim, and kswapd0.
>> Uses upper 16 bits of psi_flags to track memory subevents.
> 
> Could you elaborate on the definition of those events please? That
> should also go to Documentation (Documentation/accounting/psi.rst)

Sure, will add them to the Documentation! The idea is to add some 
statistics for the memory pressure subevents that helps to figure
out the sources of the pressure. This is just an RFC to gather
initial feedback if such approach would be acceptable.

Thanks!
Georgi