Subject: Re: [PATCH/RFC] of: Shrink struct of_device_id
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linuxppc-dev@lists.ozlabs.org, linux-mips@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <ef59d6fd3b2201b912d5eaa7f7a037d8f9adb744.1636561068.git.geert+renesas@glider.be>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Message-ID: <ddcfa4b9-f7f4-04f5-89f2-b04c284e1945@prevas.dk>
Date:   Wed, 10 Nov 2021 17:51:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <ef59d6fd3b2201b912d5eaa7f7a037d8f9adb744.1636561068.git.geert+renesas@glider.be>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?Windows-1252?Q?Kv/o7w7c5nvCkxqOs8ma/Lx1UOUEqRIexIURDTnbM4+Vp5tuTDcSS13x?=
 =?Windows-1252?Q?DLA+jXIRzn0JJV73qc+T8B1rTgY7T/J39M7MMlHcqZlByVgbboriEouZ?=
 =?Windows-1252?Q?24JMB2MfAt4ezSQ5uKsO55/+yevChJG4wASoAIauMEK8Uia1AfZugSQo?=
 =?Windows-1252?Q?6nCJSDv3N/BcwJG2oJB0WVWjqeK9Sj+5BXdyMstzOKKxjQQskt0INtTj?=
 =?Windows-1252?Q?Sbk6QvrKna1sA3DrDA7j1XuIS0HRhjp89H51Jxy6AHvbcEzfc6mRdBlj?=
 =?Windows-1252?Q?7NGK3LTnRoJtK3VtYzKLg1v0wQU5LYg7/CgvoAAKOARvHabUR2u8Fio/?=
 =?Windows-1252?Q?aZqVY6J4EdKndz7p0Zlv/PHYWWjTjZy/ZN/9qc3qSn9Dz1e1Nvyx+dt2?=
 =?Windows-1252?Q?XnFKxH9WcOfjQjGeB6I0QM1YlYS+Nk8wxhP7xxyMe4u+5F0R6FqBWU75?=
 =?Windows-1252?Q?oLwNUCxWtvc2TXmv+fAEoPaN3rPfo1b/fUlGxeiX5CSOTwYywYpCqJUo?=
 =?Windows-1252?Q?g3V/zfBVgYjT5X5meE1x+fGM2xHmmj/7oJ3Z4JK2Z3rFRSnk23mLhwIB?=
 =?Windows-1252?Q?QhH4TMUTw5pvU4wiarVVEHgJxMRlGJ9bVSJGtjphwLCNO7McUK/qTMSy?=
 =?Windows-1252?Q?I7AF2UtvcpXax1x744W1k7n1WKzH2bm+OaSNsqO6FlS/FN/RvEGK6coj?=
 =?Windows-1252?Q?Ljh9rayAyeK2rVDgD/abpOAs50WhNW0I6Pg72z+aTkRqjCx811KPj54c?=
 =?Windows-1252?Q?uM96imMbStwzx8/ra1bGdFLC9GZSp0ncXwIamDVxwRIl06lCVQy/KwBN?=
 =?Windows-1252?Q?hiZdrVHCB15IT4ScHy4UztNz4YU+FtR+geNwY3foA5y5QdO+Sk8nJWiK?=
 =?Windows-1252?Q?MO3cqx4iQ5jW+3txs1PCC26ccceVTSg3Dl/eWFFNsRxjhiu/GKNDX9MI?=
 =?Windows-1252?Q?wqrdSl2XnGpp73D/G+8mel2reYM7hoQOKEN0/Ay6V5S0D8Mc2bYYcOT+?=
 =?Windows-1252?Q?HRwedlPGQLeZut5/7SayLshUhy9CR1LD1BTDAjToqf9lNxBZy5aa/gGf?=
 =?Windows-1252?Q?1VmmakQ7mK0zcQjoLc054EKVXVH2lhnSwh87jwl1oFOfKKUZszePjPgO?=
 =?Windows-1252?Q?QbHTpSZzqiWQYQuwSp7G6xdEls8mgZRxxh8eRM8FN48o70802+q5U2TT?=
 =?Windows-1252?Q?BBaMnx8pRRkDgDke3vnnwwpkOtwka7BWkcF8J3lg0+kLHXGMBvUdHiDq?=
 =?Windows-1252?Q?yayuzN8u6RDlnUEIGOh0Mc6sTQ5sCnMG6T0eQHDeENqHwY46WC+AteWc?=
 =?Windows-1252?Q?oBqoOm9U88EwJPylf9u3xtCAqZrm3/C5jUToZzSBAFH/j2q7Acd8Of0y?=
 =?Windows-1252?Q?Aczpz/uOvCYYgJb/VH26GsB/JG+6aHXU2A23O/VpgZlH3jFjwuaBmY9I?=
 =?Windows-1252?Q?OlY/wefbaJnVS+MTtkBudLpLaSLM03GCVnEtToHLkmT4jzasi2fQc1OH?=
 =?Windows-1252?Q?W9Nu4uIiRFmymjKR/0MOadMTC9e52q/JfZW6ASe5gB/4pdNI8Oszu/NU?=
 =?Windows-1252?Q?eJBYGR9KgFw224b3hy0+g2n+N19YIaYNN0FfjTKN3NuTS558BwOiqIIg?=
 =?Windows-1252?Q?dMO2e2kVEzoOv6SsJpI0ETWFrlYTkwlu6h1b84Kfczub5CQwKExZdsp3?=
 =?Windows-1252?Q?uvqsqG0t0SWIxfuwjQ548VyYMWph2uJ8wTpkbXOje+atM7Rrm88E4akU?=
 =?Windows-1252?Q?6+jsH7M1+3482LSJ9GRvkZl7PmPvZlWF24Wea2//q+eA6Cjnt8ZyIyXO?=
 =?Windows-1252?Q?RzJ3iA=3D=3D?=
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 423e78d4-ac44-49f8-f17e-08d9a46a605a
X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB4239.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 16:51:44.2405
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XYGkjPINYhhr8igrnCFE3ygqaAfeakQX0gXW68P54+ZCiIJzoD07FvQiq1fUoFlrKRPWP3u7n9tni57QcpZdtbGTqq642a/ggXdiEvahmXw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB4336
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/11/2021 17.23, Geert Uytterhoeven wrote:
> Currently struct of_device_id is 196 (32-bit) or 200 (64-bit) bytes
> large.  It contains fixed-size strings for a name, a type, and a
> compatible value, but the first two are barely used.
> OF device ID tables contain multiple entries, plus an empty sentinel
> entry.
> 
> Statistics for my current kernel source tree:
>   - 4487 tables with 16836 entries (3367200 bytes)
>   - 176 names (average 6.7 max 23 chars)
>   - 66 types (average 5.1 max 21 chars)
>   - 12192 compatible values (average 18.0 max 45 chars)
> Taking into account the minimum needed size to store the strings, only
> 6.9% of the allocated space is used...
> 
> Reduce kernel size by reducing the sizes of the fixed strings by one
> half.

Tried something like this 2.5 years ago:
https://lore.kernel.org/lkml/20190425203101.9403-1-linux@rasmusvillemoes.dk/

I think that there might be some not-in-tree code that relies on the
existing layout. I considered adding a CONFIG_ knob, either for these
sizes in particular, or more generally a def_bool y "CONFIG_LEGACY"
which embedded folks that build the entire distro from source and don't
have any legacy things can turn off, and then get more sensible defaults
all around.

Including fx in the TCP stack where some CVE fix required changing some
parameter, but the kernel itself couldn't ship a sane default because
no-regressions, so userspace had to learn to set yet another sysctl
properly.

Rasmus