Date:   Wed, 10 Nov 2021 21:45:25 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Saurav Girepunje <saurav.girepunje@gmail.com>
Cc:     Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
        gregkh@linuxfoundation.org, straube.linux@gmail.com,
        martin@kaiser.cx, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove goto statement
Message-ID: <20211110184525.GM2001@kadam>
References: <YYwMq15pQYf7nvt9@Sauravs-MacBook-Air.local>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YYwMq15pQYf7nvt9@Sauravs-MacBook-Air.local>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZHPFbt8ZaG9JDmpbEzpdj6XRmQu1y+9Jx5lJ3XHh1EnlbHckBaJtTYubJpZp?=
 =?us-ascii?Q?qEmta00t3N68kfxHlgIrqSaz2XsSYLbwoyihDng4ggDWWLzoIf3hlZhRO6b2?=
 =?us-ascii?Q?RYzngkbcaSKXylQk12sKXCjcgmq0STGw/NwLpyiDQ5+AOM2XsSN6LfckjPM1?=
 =?us-ascii?Q?E3ExV/9vpc5MoEFCZXJAWsoR4Ij6eS7P1PcgHXpqrWlHOxIfCcb2FwLCzJfl?=
 =?us-ascii?Q?21fXzhe97A+KPxuq18n7vgPD/lFmOuBCRj+eBzVcT+1pSKXCbvP2uCkHd2Ab?=
 =?us-ascii?Q?DmwVmT/ZX+aexFf5DKxMODxtEWSgY67C6ryXRZeUTDxHNIuwPRVSr6GN4NSI?=
 =?us-ascii?Q?zBD/hne1SZ/XDJPQnLRLu26+9rL+cRNowR0wsnKQOUZlgN8ol24EgAsZh+PQ?=
 =?us-ascii?Q?1sbND+jzY3EJWBIXIMQ4RUHCLbVeFGoLMmfiFq/BxDa0MfZ7pu64U8gTTEjl?=
 =?us-ascii?Q?LDcjRg9f5vmNLRkvb0BoH0EVx9yM/0/sil9kYqpeCevbtD0ydtEUmYSdLW+K?=
 =?us-ascii?Q?DW+WPv6yg4kHayS7kQsjJq++wSdzD/VdGKep6VFajiD+B14J24MS3zLfAkAk?=
 =?us-ascii?Q?eoGJTh0Lbo4CEpre6uEEoUvu5xopXJ4vRkwYyIO7wXU3WSuQN7SEDcFkOLIR?=
 =?us-ascii?Q?5GYUyZRqgB77SoDP/zH3RWgu+zNELVOKsm8ezJnB9bNJzYtiYpZOkixUBJR3?=
 =?us-ascii?Q?6BBSRpEzHVnJB+bqAIiP1ZAXBjoxK850OKcvjj0cPVpR4/azQB/z7MBIlGes?=
 =?us-ascii?Q?8lVMe/qFBxF+2xwwPjckYEKxO4Wor5Ft3t7uvhSYFLpr9lHJ7JUZRsM2HFgr?=
 =?us-ascii?Q?TasydEeMj3oO3uVjGFQrUbstGHwBwV+mZbnH1nBx742ZEYo2ydyMY/uzDl1f?=
 =?us-ascii?Q?9xA2HOeq4eLF4jEzxsmIILalt/DeXcEHiifrYK5XTeTD4aaVcUrkn5AaQkVe?=
 =?us-ascii?Q?2d2I7xeSh0dUWcEK9NpKQWvN5jyD54/FepWkAZ/XKZOuOk2Ujut5N+7YmQ5j?=
 =?us-ascii?Q?GBLtAelJ1Dm4KNlnxgwQVtDG5hDHF3u0MZMtQN5LB7PvJp1B7pm/uem+MtI1?=
 =?us-ascii?Q?St18EkX20syGHBVhjpG6sztuar/jTTwL+8vnqG5LLBI2Jq4VFu+3e6lIdEdS?=
 =?us-ascii?Q?HqovrNQx9GY3dFQ+5kYSS+Hdf6wO4RK3Vky6MFmRKyQlN4+Xfce8I4bYYXoc?=
 =?us-ascii?Q?NLGBxjKAFUf7szw6twG5b663sUK/4av7Ty5XPCqWiP2ECnu5oy1Wt3bENWmr?=
 =?us-ascii?Q?yiPJyn1uNVirOHBt0Z0ci6MA0C8MBUZa4DZRK2oasfWhHZvANYFRlfHQJJxc?=
 =?us-ascii?Q?Cd8b9/PW+0D+LQmPNxpSKwySApQi1ZiXNHwtMa2AxhP6mzhC3x1qqNA4njSk?=
 =?us-ascii?Q?tJDgSrm0L4VAuJphDJAzOjIXWwaXON+j9moO5ii7FgjNPMUozHBvCDEUq6kF?=
 =?us-ascii?Q?U/R5wi80AM3oGx5ildwrewUsh2nVsGwxFVQAX7q8gGQWMbOOK5U0G4/UMZDV?=
 =?us-ascii?Q?SWKsKuBbnxMIgkaH9c1tufJtdn+3ZgrhqHoRYZ36cBi1+CWh5u3f5/i3rmat?=
 =?us-ascii?Q?71D00nFub6ABA7g4mjKGOoWnL26jjexRpG4grTYPcg0U45KbgDsh733vOk2H?=
 =?us-ascii?Q?3Ap+Ooffzka+U7S8LcakQjWTXEHnjaCZWN0OenPKWHZZGCpqGuNErt3alNkX?=
 =?us-ascii?Q?qpsuML0deOLnIAxYszE+al3V3RE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6391d0c-17c7-4ab2-20ba-08d9a47a4fbf
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 18:45:48.2266
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RacyVv3GlMgHxfkwgnyGSssgan7U0GNGIqjrruLi0DfDY0cPZ8jPYy79ZuZKH7X4Q9SNfRvIoGZyyQVd6b07NGREppEfngPOi41e8wVo/Rw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4628
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10164 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0
 suspectscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2111100093
X-Proofpoint-ORIG-GUID: DloKM4kO9KEef6a0Wi8NnR3VJz_iiytp
X-Proofpoint-GUID: DloKM4kO9KEef6a0Wi8NnR3VJz_iiytp
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 10, 2021 at 11:47:15PM +0530, Saurav Girepunje wrote:
> Remove the goto statement from _rtw_init_recv_priv(). In this function goto
> can be replace by return statement. As on goto label exit, function
> only return it is not performing any cleanup. Avoiding goto will
> improve the function readability.
> 
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>  drivers/staging/r8188eu/core/rtw_recv.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c
> index 51a13262a226..b38af76f3a67 100644
> --- a/drivers/staging/r8188eu/core/rtw_recv.c
> +++ b/drivers/staging/r8188eu/core/rtw_recv.c
> @@ -58,10 +58,8 @@ int _rtw_init_recv_priv(struct recv_priv *precvpriv, struct adapter *padapter)
> 
>  	precvpriv->pallocated_frame_buf = vzalloc(NR_RECVFRAME * sizeof(struct recv_frame) + RXFRAME_ALIGN_SZ);
> 
> -	if (!precvpriv->pallocated_frame_buf) {
> -		res = _FAIL;
> -		goto exit;
> -	}
> +	if (!precvpriv->pallocated_frame_buf)
> +		return _FAIL;


I hate pointless "goto exit;" labels, but there isn't a rule against
them and I feel like this is not a good enough patch on its own.  There
is so much other stuff wrong with this function.  It probably *should*
have some error handling for example.

I don't think this patch really adds enough value.  Take a look at the
function and almost every line can be improved...

regards,
dan carpenter