Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B98E9C433F5 for ; Wed, 10 Nov 2021 19:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A230A610A0 for ; Wed, 10 Nov 2021 19:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232845AbhKJTUA (ORCPT ); Wed, 10 Nov 2021 14:20:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232490AbhKJTT6 (ORCPT ); Wed, 10 Nov 2021 14:19:58 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FF56C061764; Wed, 10 Nov 2021 11:17:11 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id y1so3802330plk.10; Wed, 10 Nov 2021 11:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=hdOTGadr8Ex9gtj+XAkOSOOv2nJ7N3DNP23DIr6L3AU=; b=dWAaFqKZgag1WzlhK1qHQzqMSbfeL2u/9jwQcv88GAuiEFAb5CFSU8NXxgC11WdBu/ /YI/WRCGZjn1rjSyMBQu4VJJwBUVbDvT2RptRFRxCxgKsHhgWoYy6nSaGrcfVP8M7/ZE /+qXbTC9nubxzaeMNume8Olae40ijS5T1xHpjjqtBoC6RPvxvqLtor38omj9/0Rf8Zsb k1PzmOlf9R/V5UHgdyGDMLEXfFMmBkltm+cewdOioqMNS86O1NkQx7W3/cIN/acYJFdl vykrMk8FnPiG8MoOMtU1ueROsKRSRNo6OQRuFE2F+q+WmdNmdKc++PBaegDAeO6FJ0Ts ZxYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=hdOTGadr8Ex9gtj+XAkOSOOv2nJ7N3DNP23DIr6L3AU=; b=aRo+y7mDastLmXJyVFtuDTprY283zS1iynCENitRlD/wXiimczX3I3Vk/YZ/XYK2CP eHHyOI2NPJwABBVDxseWvcJzo0owW7BZVMvMtRCHYtrMh7oUIzh8Opge6QMVDvrHx2QB tqF4pBKcy0HgJvXbONm1Q/9KeN6zZPRDnMsk90ghj8ycoMJJLiFWL+8uI20a56UThFBD VIg5G5Mur+sAAXQ9vQi15KfJ8xBOotea4eXVBDZPQq/s30mSZx8fSZhSTUQgunzS+zr/ 5/CdlM7AeKJLhdJnME/jkyFMCrRF6ll5wZdaIHSCuM7Z6x8PGfbrQduNTooqIUzA8qM3 DHVA== X-Gm-Message-State: AOAM530GanoUAOqbnVJJuhesjtFsfgE4TAtNyHfDwOnj2o8Mxrcel7n5 mNUlKv4qdE69EQ/ZCArNBz9YTpbijQ+rsZN3VfQ= X-Google-Smtp-Source: ABdhPJwwYf9qtGwKi7uBwZ5ak9iN48PyE4XlwlVfIyvxwwOM3xYUZNxh6R4MKJqIcWRl11rsffaGwQ== X-Received: by 2002:a17:90b:4b0e:: with SMTP id lx14mr18179761pjb.160.1636571830331; Wed, 10 Nov 2021 11:17:10 -0800 (PST) Received: from makvihas ([103.85.8.15]) by smtp.gmail.com with ESMTPSA id fw21sm6138095pjb.25.2021.11.10.11.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 11:17:09 -0800 (PST) Date: Thu, 11 Nov 2021 00:47:07 +0530 From: Vihas Mak To: ssantosh@kernel.org Cc: nm@ti.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH] soc: ti: Use DEFINE_DEBUGFS_ATTRIBUTE Message-ID: <20211110191707.GA98778@makvihas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE as pm_sr_fops is used to create a debugfs file. This solves following warning generated by coccicheck: ./drivers/soc/ti/smartreflex.c:815:0-23: WARNING: pm_sr_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE Signed-off-by: Vihas Mak --- drivers/soc/ti/smartreflex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c index b5b2fa538..14b69307d 100644 --- a/drivers/soc/ti/smartreflex.c +++ b/drivers/soc/ti/smartreflex.c @@ -812,7 +812,7 @@ static int omap_sr_autocomp_store(void *data, u64 val) return 0; } -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show, omap_sr_autocomp_store, "%llu\n"); static int omap_sr_probe(struct platform_device *pdev) -- 2.25.1