Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36F6AC433FE for ; Wed, 10 Nov 2021 19:39:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16BB76113E for ; Wed, 10 Nov 2021 19:39:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232970AbhKJTmF (ORCPT ); Wed, 10 Nov 2021 14:42:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231979AbhKJTmE (ORCPT ); Wed, 10 Nov 2021 14:42:04 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADF75C061764 for ; Wed, 10 Nov 2021 11:39:16 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id c3so4151389iob.6 for ; Wed, 10 Nov 2021 11:39:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3SMO6CvmxSEBfAp8KRqD5IqUtmLkFi+eG/hFeuiApP8=; b=iWKXYgP9R3gSr4gDRcARv/crjntS2rM0iP2PE/LljM8uKwf0j1yR5MlUvbJg8d/xTD +9yLepHT95qJ7Fwacjeek0WliLgYmr2VKtLQ9ZcbooDP5LgbMBUO2sBAdfbyeYUaa+LK ingTWUTI0t/8h1OB4pQs1fkjtOkwdO5dPDRUS0BRal0usDL3P7Egah95an25GExQxmWj 99AZ1yLqaRMP4vpmsqNt+sonVhYvyYt+INZQeGJyoLrjVxOhMSiLA6yFPqTp6lzYqPm3 ZX2x5WB/AeJtabBly0XYS9Czdz1mB3cQsbTKS6XVMHzJFgRngnen5+dosoWpYFSOIre8 EAHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3SMO6CvmxSEBfAp8KRqD5IqUtmLkFi+eG/hFeuiApP8=; b=25eO3C5nL6N8usLooQSyKm5m4s/1Km9NvxAMlD9YdcC7esTJ9h/rqoP/sfKL0/yQZj bYe7dVdxLoQgARWe2Ih4eg00BSkiqhuK7VK4vf3MiF3etyL2u8dpz2oeYOOtDTs75N51 45ics+qSDFQg57Ngjy3rnUBVi7C+LsQyNX5Ghq+xNogqdyU7/Jgsec8TY0ftJNnIuFyu XD41NvNrV2J4l4xG9cTj02jc27Katxrq7LhQ3bPnXmPDi34gGJaNldJy6227AZRoSPKv JxacnCEJIbiLJP1eJA5xZfv6XYMDRIup5pR4QDfm37UF7IwJl1IMRMkRHP2JvWROJw7D nL6Q== X-Gm-Message-State: AOAM531WtdPbT5nDD29t/7oEdZadhdLSh1eOW6M0RevQU+eCOQvpX6t9 QWLb564Hvv5QkV8aVT+VJl4AkQdDeyexJt/ckBdKCw== X-Google-Smtp-Source: ABdhPJwVnD0vAGqngGi1Bc5alFWYVWNyYEvf9pOTUc2f5EnygsxhdxmMwhBXDb8EVLNsL6FIhsyRL5X672qOA8Iglpo= X-Received: by 2002:a6b:2cc5:: with SMTP id s188mr1078380ios.218.1636573155950; Wed, 10 Nov 2021 11:39:15 -0800 (PST) MIME-Version: 1.0 References: <20210921095838.GA17357@ashkalra_ubuntu_server> <20210922121008.GA18744@ashkalra_ubuntu_server> <2213EC9B-E3EC-4F23-BC1A-B11DF6288EE3@amd.com> In-Reply-To: From: Steve Rutherford Date: Wed, 10 Nov 2021 11:38:39 -0800 Message-ID: Subject: Re: [PATCH v6 1/5] x86/kvm: Add AMD SEV specific Hypercall3 To: Borislav Petkov Cc: "Kalra, Ashish" , Sean Christopherson , "pbonzini@redhat.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "hpa@zytor.com" , "joro@8bytes.org" , "Lendacky, Thomas" , "x86@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Singh, Brijesh" , "dovmurik@linux.ibm.com" , "tobin@linux.ibm.com" , "jejb@linux.ibm.com" , "dgilbert@redhat.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 29, 2021 at 4:44 AM Borislav Petkov wrote: > > On Tue, Sep 28, 2021 at 07:26:32PM +0000, Kalra, Ashish wrote: > > Yes that=E2=80=99s what I mentioned to Boris. > > Right, and as far as I'm concerned, the x86 bits look ok to me and I'm > fine with this going through the kvm tree. > > There will be a conflict with this: > > https://lkml.kernel.org/r/20210928191009.32551-1-bp@alien8.de > > resulting in: > > arch/x86/kernel/kvm.c: In function =E2=80=98setup_efi_kvm_sev_migration= =E2=80=99: > arch/x86/kernel/kvm.c:563:7: error: implicit declaration of function =E2= =80=98sev_active=E2=80=99; did you mean =E2=80=98cpu_active=E2=80=99? [-Wer= ror=3Dimplicit-function-declaration] > 563 | if (!sev_active() || > | ^~~~~~~~~~ > | cpu_active > cc1: some warnings being treated as errors > make[2]: *** [scripts/Makefile.build:277: arch/x86/kernel/kvm.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[1]: *** [scripts/Makefile.build:540: arch/x86/kernel] Error 2 > make: *** [Makefile:1868: arch/x86] Error 2 > make: *** Waiting for unfinished jobs.... > > but Paolo and I will figure out what to do - I'll likely have a separate > branch out which he can merge and that sev_active() will need to be > converted to > > if (!cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)) > > which is trivial. > > Thx. > > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette Hey All, Bumping this thread again, since I believe these patches are good to go. Let me know if there is anything I can do to help here, Thanks, Steve