Date:   Wed, 10 Nov 2021 20:57:24 +0100
From:   Ansuel Smith <ansuelsmth@gmail.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Pavel Machek <pavel@ucw.cz>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-leds@vger.kernel.org,
        Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>
Subject: Re: [RFC PATCH v3 4/8] leds: trigger: netdev: rename and expose
 NETDEV trigger enum modes
Message-ID: <YYwkJPQeej3/eRUl@Ansuel-xps.localdomain>
References: <20211109022608.11109-1-ansuelsmth@gmail.com>
 <20211109022608.11109-5-ansuelsmth@gmail.com>
 <YYrg870zccL13+Mk@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YYrg870zccL13+Mk@lunn.ch>
Precedence: bulk

On Tue, Nov 09, 2021 at 09:58:27PM +0100, Andrew Lunn wrote:
> On Tue, Nov 09, 2021 at 03:26:04AM +0100, Ansuel Smith wrote:
> > Rename NETDEV trigger enum modes to a more simbolic name and move them
> 
> symbolic. Randy is slipping :-)
> 
> > in leds.h to make them accessible by any user.
> 
> any user? I would be more specific than that. Other triggers dealing
> with netdev states?
>

Ok will be more specific. A LED driver require to explicitly support the
trigger to run in hardware mode. The LED driver will take the
trigger_data and elaborate his struct to parse all the option
(blink_mode bitmap, interval)

So the user would be a LED driver that adds support for that specific
trigger. That is also the reason we need to export them.

> > +++ b/include/linux/leds.h
> > @@ -548,6 +548,13 @@ static inline void *led_get_trigger_data(struct led_classdev *led_cdev)
> >  
> >  #endif /* CONFIG_LEDS_TRIGGERS */
> >  
> > +/* Trigger specific enum */
> 
> You probably want netdev in the comment above. Things could get
> interesting if other ledtrig-*.c started using them.
> 
> > +enum led_trigger_netdev_modes {
> > +	TRIGGER_NETDEV_LINK,
> > +	TRIGGER_NETDEV_TX,
> > +	TRIGGER_NETDEV_RX,
> > +};
> > +
> >  /* Trigger specific functions */
> >  #ifdef CONFIG_LEDS_TRIGGER_DISK
> >  void ledtrig_disk_activity(bool write);
> > -- 
> > 2.32.0
> > 

-- 
	Ansuel