From:   Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
To:     Xu Wang <vulab@iscas.ac.cn>, "jic23@kernel.org" <jic23@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>
CC:     "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function
 dev_err()
Thread-Topic: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function
 dev_err()
Thread-Index: AQHX0egr9Ta7f0JlM06cDVlwkp1KDKv9Zldw
Date:   Wed, 10 Nov 2021 22:50:03 +0000
Message-ID: <OSZPR01MB7019A331812449B03157D0C8AA939@OSZPR01MB7019.jpnprd01.prod.outlook.com>
References: <20211105015504.39226-1-vulab@iscas.ac.cn>
In-Reply-To: <20211105015504.39226-1-vulab@iscas.ac.cn>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iLsid6JSMdVZFaG/3TZKg3+XAZN3uR5tVheeZIZT65q8VDEU4AxOCpX8+oiu?=
 =?us-ascii?Q?NeJATigRt2QExbPaeV2Hygcq7L1ZuKVyx38g1AuzPfBTvMRZ0MDLmIDhA/Y+?=
 =?us-ascii?Q?FArHG2d7/7G+2cq26xWNDjNmAtlPt5mC0NwcqcWRWhSkPEu+/NpHMBTGkWx5?=
 =?us-ascii?Q?SAU3GpscOVSlWHwCweEmRjI7g+Q9caJ7N8BC+tOXmQccZS0VIQc3rlLUsuYP?=
 =?us-ascii?Q?ZZ1a224C9iHewozVnNkvJU7bRDtSoUYaVEf93Th3R1gBP7aqxV994WIvPIAa?=
 =?us-ascii?Q?2DkoNlCJwTJz9GA8DACgA/nwFsBRDh5cNg2u6uB3EgnN1kpxgnHawmgQT6xc?=
 =?us-ascii?Q?bdKNHWzBaSuaGvVOFDTJ+L9vcTXyowHvQ+BLBiVOUNWRwPC7NrkMsJrbpZQC?=
 =?us-ascii?Q?m33DbST4q3hUj0YkbczA1mZFWhYOJWH7Vvu9ytljTymsMyxVciiluT/5+4TB?=
 =?us-ascii?Q?KDbIe0RNkfKrTMUgDIGynAX/9WXvt8jFxdRAgFNjblq8UHp7RgwGpcsoikom?=
 =?us-ascii?Q?4eYlMU1QJgEYddy2QaEi6/KC+UM+TFedSbiDubJlknn39ueVeewLKCA0xLGg?=
 =?us-ascii?Q?EbLlovHF8VkOr3FysY1Hifv0H5AGvM914PtowxrPh++aIhSwYUdzDa6zNN2d?=
 =?us-ascii?Q?KhETC2Ci1ThMBTApzlIS9hoHGB6xqA3QXxDOBJhEPHFWAHsEpFL9gmDOx8cf?=
 =?us-ascii?Q?CSsjGtuVtNGGeT0M+Y81EDsJMk47sOs4FJpNHWYiLO4KskmWpTUsLGOYcwkR?=
 =?us-ascii?Q?7q41oFURa2DubdVfPMk/4SPCff3u+GzU4Jg6RpcVF9RP8ynZFUD0lsifuxyM?=
 =?us-ascii?Q?eh/tQ1ME6WU+dl6tOKp3Qm84/RpGo8V+wO7pcdRyF+lS14cRAKaj5Ajlns1D?=
 =?us-ascii?Q?iIHWDhiEHiVsUK3KnYhp9xtVFPFxrDEyFFCcxrgkqcGcK7xjF1/9CzA91XTN?=
 =?us-ascii?Q?/6/jiVlP0gm8cwbfNGeLVGphZblsNq/A8DomGHXwC37UMSYi6MneZvrZbjJR?=
 =?us-ascii?Q?fXdUFVhQPBfZ1i9l/9prTUcRIXmTbFsrg9izMptbLr2LGsV98EZFuvDsXXBd?=
 =?us-ascii?Q?Indt9zqRlidHrKWBqo1wsaXCiqrDtf3CEpptY/gduHbzaM0UtyWWoribFX/p?=
 =?us-ascii?Q?YZNjqyrf0TI45Qn9faQDZrSTtrXza9oAANfBmcfnXh+y0Di0hGTr69UE7Nau?=
 =?us-ascii?Q?wWcpUYhOFVF/sSCQ075E6mB3oaXGMwCKXjdQP+ivBFVY1iFi0O5U5D/4jtGJ?=
 =?us-ascii?Q?YpSPwJ6w/asho2xc7LrI1B7TPlPqJNNMXnmnGxpsm35EfmPHN3EdKq73vI5h?=
 =?us-ascii?Q?vbj4XzTKWGnyNb4+Bwx3TtgkiLP9eq3EHa1ATWdzRgCqSHQdoPB4MO9NpKsF?=
 =?us-ascii?Q?Kxd57f1qKHfYscezVGCtrH74vv+YhF+4GTajNp+ZlR0ksnVMenNacvNVjLOy?=
 =?us-ascii?Q?yKqIkZwdrx1WNVvgd3xAEpVGJ9p2DPgjaQEoFtJGONRNjgcHskgAXokwUpRK?=
 =?us-ascii?Q?W7qTTV3Fyp9vxB/en173yRbv7WteVJXp/PDui0YSXrI3x8W4vkIc9dfYJxP8?=
 =?us-ascii?Q?/mBcsX9ydfMTA7KDUv6xHaNam5E+NXh9rMiiX03g4FEKNt7tt5Lzef823fbJ?=
 =?us-ascii?Q?N+DurutmSj2nuPufdXOxCluiLLgs6SvbyRQANYTAJqMvqUjT4zzN3nqyvbN9?=
 =?us-ascii?Q?gZ7TWOm6o/PqnNXGeVn23Ofjt07sA9ZghhFjR31McC9EouC8uyEIFNxHKqjH?=
 =?us-ascii?Q?zS2+/9NUKQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSZPR01MB7019.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3a1f0cbf-2e69-4813-5209-08d9a49c6f6a
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Nov 2021 22:50:03.6835
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nGAIXshc9KEe7pyvWIgB39wroTb7mG6ScvPyeUzibC/yOPzrlV0VjKBO8g+fL3axWSBbhfQ+N2vi0b8chb6uSNxMtliq40eiW4jUZLtw7Bm1iDxNY5jH9uwshuJqEi+t
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB1461
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Xu,

Thank you for the patch.

> -----Original Message-----
> From: Xu Wang <vulab@iscas.ac.cn>
> Sent: 05 November 2021 01:55
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; jic2=
3@kernel.org; lars@metafoo.de
> Cc: linux-iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-k=
ernel@vger.kernel.org
> Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function d=
ev_err()
>=20
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>=20
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/iio/adc/rzg2l_adc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c in=
dex
> 32fbf57c362f..9d5be52bd948 100644
> --- a/drivers/iio/adc/rzg2l_adc.c
> +++ b/drivers/iio/adc/rzg2l_adc.c
> @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *p=
dev)
>  	}
>=20
>  	irq =3D platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(dev, "no irq resource\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>=20
>  	ret =3D devm_request_irq(dev, irq, rzg2l_adc_isr,
>  			       0, dev_name(dev), adc);
> --
> 2.25.1